chaoyli commented on a change in pull request #567: Add publish version task
URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249668036
##########
File path: be/src/olap/txn_manager.cpp
##########
@@ -190,11 +189,7 @@ void TxnManager::get_txn_related_tablets(const
TTransactionId transaction_id,
// each tablet
for (auto& load_info : load_info_map) {
const TabletInfo& tablet_info = load_info.first;
- tablet_infos->push_back(tablet_info);
- if (rowset_infos != NULL) {
- // TODO(ygl) check rowsetptr is null?
- rowset_infos->push_back(load_info.second.second);
- }
+
tablet_infos->insert(std::make_pair(tablet_info,load_info.second.second));
Review comment:
emplace_back(tablet_info, load_info.second.second) will be better than
tablet_infos->insert(std::make_pair(tablet_info,load_info.second.second));
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
