chaoyli commented on a change in pull request #536: Add Rowset and RowsetBuilder for PushHandler URL: https://github.com/apache/incubator-doris/pull/536#discussion_r249741597
########## File path: be/src/olap/delta_writer.cpp ########## @@ -115,9 +121,9 @@ OLAPStatus DeltaWriter::init() { .set_load_id(_req.load_id); RowsetWriterContext writer_context = context_builder.build(); - // TODO: new RowsetWriter according to tablet storage type - _rowset_writer.reset(new AlphaRowsetWriter()); - OLAPStatus status = _rowset_writer->init(writer_context); + // TODO: new RowsetBuilder according to tablet storage type + _rowset_builder.reset(new AlphaRowsetBuilder()); + status = _rowset_builder->init(builder_context); Review comment: _rowset_writer ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org