kangpinghuang commented on a change in pull request #567: Add publish version 
task
URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249744156
 
 

 ##########
 File path: be/src/olap/txn_manager.cpp
 ##########
 @@ -190,17 +188,13 @@ void TxnManager::get_txn_related_tablets(const 
TTransactionId transaction_id,
     // each tablet
     for (auto& load_info : load_info_map) {
         const TabletInfo& tablet_info = load_info.first;
-        tablet_infos->push_back(tablet_info);
-        if (rowset_infos != NULL) {
-            // TODO(ygl) check rowsetptr is null?
-            rowset_infos->push_back(load_info.second.second);
-        }
+           tablet_infos->emplace_back(tablet_info,load_info.second.second);
 
 Review comment:
   add space before load_info

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org

Reply via email to