Re: [ALL] CRLF line endings causing problems

2025-01-18 Thread Alex Herbert
On Sat, 18 Jan 2025 at 18:05, Piotr P. Karwasz wrote: > Hi Alex, > > On 18.01.2025 18:06, Alex Herbert wrote: > > $ echo "* text=auto" >>.gitattributes > > $ rm .git/index # Remove the index to force Git to > > $ git reset # re-

Re: [ALL] CRLF line endings causing problems

2025-01-18 Thread Alex Herbert
e index to force Git to $ git reset # re-scan the working directory $ git status# Show files that will be normalized $ git add -u $ git add .gitattributes $ git commit -m "Introduce end-of-line normalization" Alex [1] https://git-scm.com/docs/gitattributes/2.6.7 On

Re: [collections] BloomFilterExtractor.flatten()

2024-10-04 Thread Alex Herbert
not mandate any prerequisites on the Predicate for the filters. So for example you could have many filters of different sizes and a predicate that tests if they all contain a given IndexProducer. Alex On Fri, 4 Oct 2024 at 18:02, Gary Gregory wrote: > > OK, but how do you create an empty

Re: [collection] AbstractLinkedListForJava21 ?

2024-09-11 Thread Alex Herbert
AbstractLinkedListForJava21. If this is not clear from the javadoc and linked issue in the commit log then we should do a better job explaining this. Alex On Wed, 11 Sept 2024 at 21:52, Gary D. Gregory wrote: > > Hi All: > > Added in 4.5.0-M2, I see a new class called AbstractLinkedL

[ANNOUNCE] Apache Commons Statistics Version 1.1 Released

2024-08-20 Thread Alex Herbert
S-71: Add commons-statistics-descriptive module for implementations of univariate statistics. Contains base interfaces for statistics and implementations for individual statistics (e.g. Min, Max, Sum, Mean, Variance) and combinations of statistics.

Re: [VOTE] Release Apache Commons Statistics 1.1 based on RC1

2024-08-20 Thread Alex Herbert
This vote passes with the following result: +1: Bruno Kinoshita (binding) +1: Gary Gregory (binding) +1: Alex Herbert (binding) Thanks to everyone who reviewed the candidate. I will proceed with the release. Alex On Tue, 20 Aug 2024 at 10:12, Alex Herbert wrote: > > My +1 > > On

Re: [VOTE] Release Apache Commons Statistics 1.1 based on RC1

2024-08-20 Thread Alex Herbert
My +1 On Mon, 19 Aug 2024 at 12:59, Gary Gregory wrote: > > On Mon, Aug 19, 2024 at 7:21 AM Alex Herbert > wrote: > > > On Sat, 17 Aug 2024 at 17:24, Gary Gregory wrote: > > > > > > Thank you for the details Alex. > > > > > > WRT SBOM gen

Re: [VOTE] Release Apache Commons Statistics 1.1 based on RC1

2024-08-19 Thread Alex Herbert
On Sat, 17 Aug 2024 at 17:24, Gary Gregory wrote: > > Thank you for the details Alex. > > WRT SBOM generation, I think this will be become more important as > time goes on, so anything we can do to improve the ecosystem will benefit > us all IMO. FYI: I traced the warning

Re: [VOTE] Release Apache Commons Statistics 1.1 based on RC1

2024-08-17 Thread Alex Herbert
look as it may require some particular maven build targets to be run in the dependency projects for javadoc. Note that only the inference module depends on other modules (ranking; distribution). However I believe there is nothing in the public API from the other modules. So it cannot be known

[VOTE] Release Apache Commons Statistics 1.1 based on RC1

2024-08-16 Thread Alex Herbert
[ ] -0 OK, but really should fix... [ ] -1 I oppose this release because... Thank you, Alex Herbert, Release Manager (using key BC87A3FD0A54480F0BADBEBD21939FF0CA2A6567) The following is intended as a helper and refresher for reviewers. Validating a release candidate ==

[release] No description on staged Nexus repo

2024-08-16 Thread Alex Herbert
To release managers, During the staging of Statistics 1.1 RC1 I made an error and did not add a description when closing Nexus repo 1773. The repository contents are OK. Please do not drop this repo during housekeeping. Alex

[ANNOUNCE] Apache Commons Numbers Version 1.2 Released

2024-08-12 Thread Alex Herbert
uot;ArithmeticUtils": Improve performance of GCD for longs. Thanks to Matthias Langer. o "ArithmeticUtils": Improve performance of remainderUnsigned and divideUnsigned. Thanks to Sebb, Alex Herbert. o NUMBERS-199: "Precision": Document inaccurate decimal valu

Re: [VOTE][RESULT] Release Apache Commons Numbers 1.2 based on RC1

2024-08-12 Thread Alex Herbert
This vote passes with the following result: +1: Bruno Kinoshita (binding) +1: Gary Gregory (binding) +1: Tomas Lanik +1: Gilles Sadowski (binding) +1: Alex Herbert (binding) Thanks to everyone who voted. Alex On Mon, 12 Aug 2024 at 10:27, Alex Herbert wrote: > > My +1. > > Ale

Re: [VOTE] Release Apache Commons Numbers 1.2 based on RC1

2024-08-12 Thread Alex Herbert
My +1. Alex On Sat, 10 Aug 2024 at 01:25, Gilles Sadowski wrote: > > Hi. > > $ git clone https://gitbox.apache.org/repos/asf/commons-numbers.git > --branch commons-numbers-1.2-RC1 commons-numbers-1.2-RC1 > $ cd commons-numbers-1.2-RC1 > $ git tag -v commons-numbers-1.2-

Re: [VOTE] Release Apache Commons Numbers 1.2 based on RC1

2024-08-08 Thread Alex Herbert
Thanks Bruno. The site I put up is not from a clean build so these files are generated by the release and then reported on by a second build for the site. I will add exclusions for them to checkstyle. Alex On Thu, 8 Aug 2024, 21:14 Bruno Kinoshita, wrote: > +1 > > Build from tag pas

[VOTE] Release Apache Commons Numbers 1.2 based on RC1

2024-08-08 Thread Alex Herbert
he.org/commons/KEYS Please review the release candidate and vote. This vote will close no sooner than 72 hours from now. [ ] +1 Release these artifacts [ ] +0 OK, but... [ ] -0 OK, but really should fix... [ ] -1 I oppose this release because... Thank you, Alex Herbert, Release Manag

Re: [numbers][release] Nexus staging error for numbers 1.2 RC1

2024-08-08 Thread Alex Herbert
A reroll has fixed the nexus staging issue. On Thu, 8 Aug 2024 at 15:24, Alex Herbert wrote: > > I have just staged a release candidate for Commons Numbers 1.2 RC1. > However nexus has created two repository IDs: > 1765: contains all the expected module jars and signatures > 176

[numbers][release] Nexus staging error for numbers 1.2 RC1

2024-08-08 Thread Alex Herbert
-numbers-parent-1.2.pom.asc commons-numbers-parent-1.2.pom.md5 Staging did take a long time for the initial (parent) module. I am assuming a timeout error created a second staging repo. I will drop both nexus repositories and reroll. Alex

[ANNOUNCE] Apache Commons RNG 1.6 released

2024-07-16 Thread Alex Herbert
The Apache Commons Team is pleased to announce the availability of version 1.6 of "Apache Commons RNG". Apache Commons RNG provides Java implementations of pseudo-random numbers generators. Changes in this version include: New features: o RNG-186: Correct the module OSGi exports. Use of multipl

Re: [VOTE] Release Apache Commons Codec 1.17.1 based on RC1

2024-07-15 Thread Alex Herbert
c.tar.gz Lots of warnings from PMD, CPD and SpotBugs. These have been around a while. Perhaps a tidy up with some rule exclusions could be made for things that will not be fixed before 2.0 (e.g. naming conventions). +1: release these artifacts Alex On Mon, 15 Jul 2024 at 07:48, Tomas Lanik wr

Re: [VOTE][RESULT] Release Apache Commons RNG 1.6 based on RC2

2024-07-15 Thread Alex Herbert
This vote passes with the following votes: +1: Gilles Sadowski (binding) +1: Gary Gregory (binding) +1: Alex Herbert (binding) Thanks to all who inspected RC1 and 2. Alex On Fri, 12 Jul 2024 at 14:51, Gary D. Gregory wrote: > +1 > > I tested the src zip file: > - SHA512 O

Re: [CANCEL][VOTE] Release Apache Commons RNG 1.6 based on RC1

2024-07-15 Thread Alex Herbert
RC1 is cancelled for RC2 On Tue, 9 Jul 2024 at 12:12, Gary Gregory wrote: > Thanks Alex! > > Gary > > On Mon, Jul 8, 2024, 4:22 PM Alex Herbert > wrote: > > > Hi Gary, > > > > Thanks for the feedback. I'll fix the docs module tomorrow. It is only &

Re: [VOTE] Release Apache Commons RNG 1.6 based on RC2

2024-07-12 Thread Alex Herbert
My +1 Another review would be appreciated. On Thu, 11 Jul 2024 at 21:13, Alex Herbert wrote: > RC2 is still ok. Only nits with the site generation so far. > > On Thu, 11 Jul 2024, 19:31 Gary Gregory, wrote: > >> Is RC2 still alive or are there changes coming due to this di

Re: [VOTE] Release Apache Commons RNG 1.6 based on RC2

2024-07-11 Thread Alex Herbert
> > > On Jul 11, 2024, at 1:57 PM, Alex Herbert > > wrote: > > > > > > Hi Gilles, > > > > > > Thanks for the feedback. It seems that revapi is not a robust plugin, > but > > > japicmp also has issues without the packaged ja

Re: [VOTE] Release Apache Commons RNG 1.6 based on RC2

2024-07-11 Thread Alex Herbert
t; > Le mar. 9 juil. 2024 à 14:22, Alex Herbert a écrit : > > > > We have fixed a few bugs and added enhancements since Apache Commons RNG > > 1.5 was released, so I would like to release Apache Commons RNG 1.6. > > > > Apache Commons RNG 1.6 RC2 is available for

Re: [VOTE] Release Apache Commons RNG 1.6 based on RC2

2024-07-11 Thread Alex Herbert
ot contain a jar file then japicmp also fails (i.e. it does not use locally installed jar files from the m2 repo). So here japicmp does require a local jar file, but revapi does not work with a local jar file after the first module. So this is a bug in revapi when creating the site after a previous run to create the package. Alex

Re: [VOTE] Release Apache Commons RNG 1.6 based on RC2

2024-07-09 Thread Alex Herbert
compatibility checks as a previous release change was flagged as binary incompatible by JApiCmp but was not by revapi. This required some exclusions for JApiCmp. The build still retains configuration for both plugins. Alex On Tue, 9 Jul 2024 at 13:21, Alex Herbert wrote: > We have fixed a few bugs

[VOTE] Release Apache Commons RNG 1.6 based on RC2

2024-07-09 Thread Alex Herbert
OK, but... [ ] -0 OK, but really should fix... [ ] -1 I oppose this release because... Thank you, Alex Herbert, Release Manager (using key BC87A3FD0A54480F0BADBEBD21939FF0CA2A6567) The following is intended as a helper and refresher for reviewers. Validating a release candidate ===

Re: [VOTE] Release Apache Commons RNG 1.6 based on RC1

2024-07-08 Thread Alex Herbert
this will be 1 in a billion. But there are thousands of tests. The build fail rate is closer to 1 in 1000 but I haven't done the analysis on it for a while. Hope that helps. Alex On Mon, 8 Jul 2024, 21:30 Rob Tompkins, wrote: > I was running the build on java 21 and got this: > Resul

Re: [VOTE] Release Apache Commons RNG 1.6 based on RC1

2024-07-08 Thread Alex Herbert
separately and put it in a personal Apache site. This makes it easy to see all the site including the examples (which are not officially released but documented in the site). Note: I cancelled this vote as some intentionally private constructors were public. Alex On Mon, 8 Jul 2024 at 18:52,

[VOTE] Release Apache Commons RNG 1.6 based on RC1

2024-07-05 Thread Alex Herbert
. This vote will close no sooner than 72 hours from now. [ ] +1 Release these artifacts [ ] +0 OK, but... [ ] -0 OK, but really should fix... [ ] -1 I oppose this release because... Thank you, Alex Herbert, Release Manager (using key BC87A3FD0A54480F0BADBEBD21939FF0CA2A6567) The foll

Re: [parent] Possibe change to moditect configuration for internal packages

2024-07-04 Thread Alex Herbert
n provides example configuration to do this for an internal package, which is what I am suggesting here. Alex On Thu, 4 Jul 2024 at 14:25, Gary Gregory wrote: > Can this alternatively be solved with Java's sealed class feature? That > would require Java 17 though... > > Gary >

[parent] Possibe change to moditect configuration for internal packages

2024-07-04 Thread Alex Herbert
*; *; This could be integrated to commons parent. However it may affect binary compatibility on Java 9+ for any that do and have been released with the default export of all packages. Are there any other components that use internal packages? Alex

[rng][numbers][statistics] Release latest dev versions

2024-07-04 Thread Alex Herbert
items to integrate but let me know if there is something else to include. Alex

Re: TEST fails for commons-compress:1.26

2024-06-26 Thread Alex Herbert
ll provide your build platform details so we can try and reproduce the issue. Thanks, Alex On Wed, 26 Jun 2024 at 17:28, sumera sum wrote: > Hi Team, > I am able to build commons-compress from source code, but while trying to > run the tests it fails with the following error. Please a

Re: [LANG] Add Any Checks for Not Checks in StringUtils

2024-06-12 Thread Alex Herbert
On Wed, 12 Jun 2024 at 18:03, Department 8 wrote: > Sorry Alex just now saw your email, before sending out the PR! > > I had done just for isAllEmpty and isAllBlank. > > Can you tell me more on what can be done, when you said the following: > > If you are simply negating

Re: [LANG] Add Any Checks for Not Checks in StringUtils

2024-06-12 Thread Alex Herbert
larly negated: isAllEmpty isAllLowerCase isAllUpperCase If you are simply negating the result of another method then this use case may be better served with addition of a suitable example to the javadoc of the method you are negating. Alex

Re: [COLLECTIONS/Bloomfilter] A question of streams

2024-06-11 Thread Alex Herbert
stream; and how critical is the runtime performance for this process? Alex On Wed, 12 Jun 2024 at 07:37, Claude Warren wrote: > There is/was a discussion in Cassandra Dev recently about the overhead of > Java Streaming vs simple loops/iteration. The consensus there is that > streams shou

Re: [Collections] Implementation of EnhancedDoubleHasher

2024-05-18 Thread Alex Herbert
Tracking this with: https://issues.apache.org/jira/browse/COLLECTIONS-855 On Sat, 18 May 2024 at 08:26, Alex Herbert wrote: > Thanks for highlighting this. I did not use the original paper and based > the implementation on Wikipedia. > > I think the issue is that we use i in [0

Re: [Collections] Implementation of EnhancedDoubleHasher

2024-05-18 Thread Alex Herbert
. Regards, Alex On Sat, 18 May 2024 at 07:23, Juan Manuel Gimeno Illa wrote: > The code in the implementation of the EnhancedDoubleHasher is based on the > wikipedia article https://en.wikipedia.org/wiki/Double_hashing. > > The code that appears in the article is: > > stru

Re: [COLLECTIONS] Is the changes.xml file automatically updated by pull merge?

2024-05-12 Thread Alex Herbert
No. Just add it as a second commit after merge. On Sun, 12 May 2024, 11:12 Claude Warren, wrote: > -- > LinkedIn: http://www.linkedin.com/in/claudewarren >

Re: [Collections] Suppliers, Iterables, and Producers

2024-04-30 Thread Alex Herbert
at use "BitMap" in the same > but I think I am more comfortable with the term reuse now. > > The question that remains is must it be public? Since the Javadoc mentions > it is about indices and bit positions, could all these methods be moved to > the package-private IndexUtils? My concern is to reduce the public and > protected API surface we will have to support and keep for the lifetime of > the 4.x code base. > It was originally package-private and Claude requested it be made public for general re-use. We could use the name BitMaps, in keeping with the pluralisation of classes seen in the JDK when working with elements of a given type: Executors, Collections, etc. Alex

Re: [Collections] Suppliers, Iterables, and Producers

2024-04-28 Thread Alex Herbert
with the same shape. This is not an extensible design as you can only iterate over a pair of filters, and not n filters of the same shape. The use case is in standard set operations such as union and intersect which are used to generate metrics used in the literature (see

Re: [Collections] Bloom filter package's Hasher to extend Function

2024-04-25 Thread Alex Herbert
Shape. So at present I cannot see a common use case for the chaining methods (compose, apply) that come with the Function interface. Alex

Re: [Collections-BloomFilter][Discuss] missing functionality?

2024-04-20 Thread Alex Herbert
IndexProducer indexProducer, Consumer result) Why else do you require indices of layers? If there is no use case other than layer retrieval then this seems to be the wrong API. Alex > Claude > > On Fri, Apr 19, 2024 at 11:06 AM Alex Herbert > wrote: > > > On Fri, 19 Apr 2024 at

Re: [Collections-BloomFilter][Discuss] missing functionality?

2024-04-19 Thread Alex Herbert
t.next(); if (i == 3) { it.remove(); } } System.out.println(d); prints: [1, 2, 4, 5] So it is easy to iterate the layers and remove them in Order(1) time (per removal). Alex > > On Wed, Apr 17, 2024 at 2:17 PM Alex Herbert > wrote: > > > Looks good t

Re: [Collections-BloomFilter][Discuss] missing functionality?

2024-04-17 Thread Alex Herbert
about how any custom downstream code is currently using the collection of layers. Alex On Wed, 17 Apr 2024 at 10:00, Claude Warren wrote: > I have an open pull request to fix this problem. I could use another > review: https://github.com/apache/commons-collections/pull/476 > > >

Re: [Collections-BloomFilter][Discuss] missing functionality?

2024-04-09 Thread Alex Herbert
om the start or end of the list (whichever is closer) to find the element. This can use the iterator/descendingIterator method of Deque for the same performance (but the code to do this has to be written). Alex On Tue, 9 Apr 2024 at 08:45, Claude Warren wrote: > Greetings, > >

Re: [Collections] New release candidate for 4.5.0-beta1 or -M1 and new Bloom Filter package

2024-03-25 Thread Alex Herbert
be changed to the same API as JDK 21. This would leave the 4.X branch compile time limited to LTS JDKs up to 17. Alex [1] https://issues.apache.org/jira/browse/COLLECTIONS-842

Re: [Net] JUnit 5 migration discussion

2024-02-29 Thread Alex Herbert
asses than on JUnit 3 or 4. I would try and upgrade one test and see if it works. Alex On Thu, 29 Feb 2024 at 20:43, Gary Gregory wrote: > Thank you for digging into this Eric. > > Another component to consider for JUnit 5 migration is Commons VFS. This > one is challenging due to s

Re: New to community-Introducing myself

2023-12-31 Thread Alex Herbert
is mailing list using the component as a message subject prefix in square brackets, e.g. [math] my idea is ... Alex [1] https://commons.apache.org/ [2] https://issues.apache.org/jira [3] https://github.com/apache/commons-math [4] https://issues.apache.org/jira/projects/MATH [5] https://comm

Re: (commons-numbers) branch master updated: Simplify conversion of numbers to unsigned

2023-12-24 Thread Alex Herbert
he.org/repos/asf/commons-numbers.git > > > > > > The following commit(s) were added to refs/heads/master by this push: > > new a15b3e68 Simplify conversion of numbers to unsigned > > a15b3e68 is described below > > > > commit a15b3e68136dd94ea20e4085afc45aa73d4

Re: [MATH][NUMBERS] Method to convert unsigned long to BigInteger

2023-12-24 Thread Alex Herbert
On Sun, 24 Dec 2023 at 16:31, sebb wrote: > > On Sun, 24 Dec 2023 at 16:14, Alex Herbert wrote: > > > > On Sun, 24 Dec 2023 at 13:58, sebb wrote: > > > > > > On Sun, 24 Dec 2023 at 13:16, Alex Herbert > > > wrote: > > > > &g

Re: [MATH][NUMBERS] Method to convert unsigned long to BigInteger

2023-12-24 Thread Alex Herbert
On Sun, 24 Dec 2023 at 13:58, sebb wrote: > > On Sun, 24 Dec 2023 at 13:16, Alex Herbert wrote: > > > > On Sun, 24 Dec 2023 at 11:45, Elliotte Rusty Harold > > wrote: > > > > > > On Sun, Dec 24, 2023 at 9:59 AM sebb wrote: > > > > >

Re: (commons-numbers) 01/01: Use Java 1.8 methods to simplify the ArithmeticUtils methods remainderUnsigned and divideUnsigned (both int and long)

2023-12-24 Thread Alex Herbert
is still not an intrinsic method [1]. My only issue with the Numbers methods is they are based on the Hacker's Delight book which is not free, thus it is not easy to check the implementation against the source. Alex [1] https://chriswhocodes.com/hotspot_intrinsics_openjdk21.html On Sun, 2

Re: (commons-numbers) branch java8-simplify created (now 2f60d424)

2023-12-24 Thread Alex Herbert
l not an intrinsic method [1]. My only issue with the Numbers methods is they are based on the Hacker's Delight book which is not free, thus it is not easy to check the implementation against the source. Alex [1] https://chriswhocodes.com/hotspot_intrinsics_openjdk21.html ---

Re: [MATH][NUMBERS] Method to convert unsigned long to BigInteger

2023-12-24 Thread Alex Herbert
nd the support of the JDK methods is in scope. Without a use case it would just be code bloat. Alex - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Re: [ALL] Deploying SNAPSHOTS from GH workflows

2023-12-20 Thread Alex Herbert
os and subsequently PRs? Alex - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Re: [NUMBERS] GH deploy snapshot test

2023-12-20 Thread Alex Herbert
On Wed, 20 Dec 2023 at 13:19, sebb wrote: > > On Tue, 19 Dec 2023 at 16:08, Alex Herbert wrote: > > > > Thanks Sebb, > > > > Note that previously the GH action was running the default goal: > > 'clean verify javadoc:javadoc'. > > > >

Re: [NUMBERS] GH deploy snapshot test

2023-12-19 Thread Alex Herbert
Thanks Sebb, Note that previously the GH action was running the default goal: 'clean verify javadoc:javadoc'. Since we now need to specify the 'deploy' goal as well the above defaults can be switched in for your additions when Infra have created the credentials. Alex On Tu

Re: [ALL] Deploying SNAPSHOTS from GH workflows

2023-12-19 Thread Alex Herbert
ears they have been running. So this feature is not essential. I would be happy to trial a simpler (than Crypto) deploy of snapshots using GH for one of these components, e.g. Numbers/RNG which have no dependencies. Alex > > Sebb > [1] e.g. https://issues.apache.org/jira/browse/INFR

Re: Apache Common Lang -- How do I compile or did I find a bug

2023-12-12 Thread Alex Herbert
indly report any build issues." This should provide a first indicator to a user that the JDK must be up-to-date and welcomes any feedback on building. This text may not be suitable for all repos if they do not test across all LTS versions of the JDK so may need some revision for th

Re: Apache Common Lang -- How do I compile or did I find a bug

2023-12-12 Thread Alex Herbert
name: "mac os x", version: "13.4.1", arch: "aarch64", family: "mac" So this is a JDK issue. Alex On Tue, 12 Dec 2023 at 11:51, Gary Gregory wrote: > > See the GutHub builds as well. Make sure you have the latest Java version > of the major relea

Re: Apache Common Lang -- How do I compile or did I find a bug

2023-12-12 Thread Alex Herbert
tform encoding: UTF-8 OS name: "linux", version: "5.4.0-167-generic", arch: "amd64", family: "unix" The GH actions builds are green for MacOS latest on all JDKs. I see you are using a similar OS version to my mac. So this may be a MacOS Sonoma 14 vs MacOS V

Re: [LAZY] was: [VOTE] Release Apache Commons Parent 65 based on RC1

2023-11-18 Thread Alex Herbert
On Sat, 18 Nov 2023 at 12:49, Gary Gregory wrote: > > On Sat, Nov 18, 2023 at 3:36 AM Alex Herbert wrote: > > > > Installed from the maven tag. > > > > Built lang and statistics using JDK 8 and 11: > > > > Apache Maven 3.9.4 (dfbb324ad4a7c8fb0bf182e6d91b

Re: [LAZY] was: [VOTE] Release Apache Commons Parent 65 based on RC1

2023-11-18 Thread Alex Herbert
ks. I did not fix the source. statistics: Fails on SpotBugs with 1 error in the inference module. Fixed in the source. Fails on checkstyle under JDK 11 with errors due to private final classes not declared as final. This is a strange one as IIRC other tools state that the keyword is redundant. I

Re: [CRYPTO] Basic SSL 3.x support added

2023-11-17 Thread Alex Remily
e352 Cipher AES/CTR/NoPadding instance created OK: org.apache.commons.crypto.cipher.OpenSslCipher@673c4f6e On Tue, Nov 14, 2023 at 8:27 AM sebb wrote: > On Tue, 14 Nov 2023 at 13:17, Alex Remily wrote: > > > > That's fantastic. I read that there were big API changes with the mov

Re: [CRYPTO] Basic SSL 3.x support added

2023-11-14 Thread Alex Remily
That's fantastic. I read that there were big API changes with the move to OpenSSL 3, but maybe those changes were not in the functionality that commons crypto exposes. Have you merged into master yet? I look forward to playing around with it. Alex On Wed, Nov 8, 2023 at 7:12 PM sebb

Re: [CRYPTO] Drop support for OpenSSL < 1.1 ?

2023-11-08 Thread Alex Remily
Or something else? > > > > Note I am not suggesting dropping support for 1.1.0 yet, but for > > versions before that, i.e. 1.0.x. > > > > > Gary > > > > > > On Sun, Oct 29, 2023 at 8:49 PM Alex Remily > wrote: > > > > > > > >

[CRYPTO] JNI Debug Config

2023-11-04 Thread Alex Remily
table with VSCode if you have a good JNI debug configuration for it. I use GDB. Alex

Re: [CRYPTO] Why does Makefile use CXX (C++) for linking?

2023-11-01 Thread Alex Remily
I believe it is for cross compilation, owing to the comments in the makefile: # for cross-compilation on Ubuntu, install the g++-mingw-w64-x86-64 package # for cross-compilation on Ubuntu, install the g++-arm-linux-gnueabi package # for cross-compilation on Ubuntu, install the g++-arm-linux-gnuea

Re: [CRYPTO] Which native builds are supported in binary releases?

2023-11-01 Thread Alex Remily
e that out. Alex On Wed, Nov 1, 2023 at 11:36 AM sebb wrote: > The Crypto makefile includes a lot of different OS and architecture > combinations. > > Not all of these are included in the binary jar. > > I don't think we need to generate native binaries for all the > com

Re: (commons-rng) branch master updated: Normalize spelling to US English

2023-10-31 Thread Alex Herbert
_SOURCE_64_MODE = "Unrecognized > source64 mode: "; Change the constant name too. > +/** Message for an unrecognized native output type. */ > +private static final String UNRECOGNISED_NATIVE_TYPE = "Unrecognized > native output typ

Re: [CRYPTO] Drop support for OpenSSL < 1.1 ?

2023-10-29 Thread Alex Remily
dropping legacy OpenSSL support in the next commons crypto release. Alex On Sun, Oct 29, 2023 at 9:15 AM sebb wrote: > There is quite a lot of Crypto code that depends on the check: > > if (dlsym_OpenSSL_version_num() < VERSION_1_1_X) > where > VERSION_1_1_X = 0x1010; >

Re: [lang] RandomStringUtilsTest.testRandomStringUtilsHomog fails a lot

2023-10-20 Thread Alex Herbert
method by other means. Alex On Fri, 20 Oct 2023 at 20:16, Gary D. Gregory wrote: > > Hi Alex, > > I'd prefer if you could give a shot at adjusting this test when you can take > the time. > > TY, > Gary > > On 2023/10/20 18:17:35 Alex Herbert wrote: > > O

Re: [lang] RandomStringUtilsTest.testRandomStringUtilsHomog fails a lot

2023-10-20 Thread Alex Herbert
On Fri, 20 Oct 2023 at 18:55, Alex Herbert wrote: > > The chi-square critical value (13.82) is correct: > > >>> from scipy.stats import chi2 > >>> chi2(2).isf(0.001) > 13.815510557964274 > > The test seems to fail with the expected frequency when run loca

Re: [lang] RandomStringUtilsTest.testRandomStringUtilsHomog fails a lot

2023-10-20 Thread Alex Herbert
m(0xdeadbeef) gen = RandomStringUtils.random(6, 0, 3, false, false, chars, rng); You will see a drop in coverage by not exercising the public API. The alternative is to change the chi-square critical value: 1 in 10,000: 18.420680743952364 1 in 100,000: 23.025850929940457 1 in 1,000,000: 27.631021115928547

Re: [ALL] Java CI badge does not agree with workflow status

2023-10-20 Thread Alex Herbert
. Another working version from Statistics is the same E.g.: https://github.com/apache/commons-statistics/actions/workflows/maven.yml/badge.svg So try a badge update with a different URL. Alex On Fri, 20 Oct 2023 at 16:03, sebb wrote: > > The build-plugin readme shows a failing Java CI

Re: [Text] Java 21 failure with a double

2023-10-20 Thread Alex Herbert
check against the digits output from Double.toString to ensure all digits are present. Alex [1] https://github.com/apache/commons-text/pull/467 On Mon, 16 Oct 2023 at 18:37, Alex Herbert wrote: > > TLDR; The Double.toString(double) value is different for > -9.354004711977437E17 on JDK 2

Re: [Text] Java 21 failure with a double

2023-10-16 Thread Alex Herbert
lement fix 1, plus add a test for full length precision using only the root locale. This can quickly test the output is at the limit by checking the string creates the original input double using Double.parseDouble, i.e. the DoubleFormat has captured the entire information required to uniquely recrea

Re: [ALL] Standardise Maven defaultGoal in components?

2023-10-08 Thread Alex Herbert
mponent uses 'clean verify javadoc:javadoc' but executes PMD, SpotBugs and Checkstyle in executions bound to the verify phase. There are also some plugins that have executions bound to verify but activated by the presence of a file, for example RevAPI/JApiCmp for modules b

Re: [VOTE][LAZY] Release Apache Commons Parent 63 based on RC2

2023-10-02 Thread Alex Herbert
Release plugin but I cannot find 'commons.conf.dir' referenced in the current release plugin code. Alex On Mon, 2 Oct 2023 at 13:28, Gary Gregory wrote: > > We have fixed a few bugs and added some enhancements since Apache > Commons Parent 62 was released, so I would lik

Re: [BUILD-PLUGIN] Drop component list from README template?

2023-10-02 Thread Alex Herbert
applied to every one of them, to ensure they are up to date. > > This is an unnecessary maintenance burden. > > I think this local list should be dropped, and replaced with a link to > the main website. +1 Alex ---

[statistics] descriptive module

2023-09-26 Thread Alex Herbert
provided by changing the final class back to abstract with different implementations. Alex - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Re: [MATH] Inconsistent artifactId for parent pom

2023-09-20 Thread Alex Herbert
.0-beta2) The current parent was probably copied from one of the derived multi-module projects (e.g. RNG/Numbers) which are still on major version 1. Feel free to fix it in git master. Alex - To unsubscribe, e-mail: dev-unsubscr...@

Re: [DRAFT][REPORT] September 2023

2023-09-13 Thread Alex Herbert
You could add that we had a successful participant in Google Summer of Code 2023 working on the statistics sub-project. This may apply to the community section. Alex On Wed, 13 Sept 2023 at 02:59, Gary Gregory wrote: > > Here is the report I plan on filing, probably in the A

Re: [CRYPTO] test failures with JNA

2023-09-12 Thread Alex Remily
How to reproduce these test failures? On Sat, Sep 9, 2023 at 12:33 PM sebb wrote: > Some of the test runs fail when testing with the class: > > org.apache.commons.crypto.jna.OpenSslJna > > It looks like all the OSes complete the test OK if the default JNA > library is used. > > However for some

Re: [commons-crypto] OpenSSL 3.x, FIPS, digests, and HMAC

2023-09-08 Thread Alex Remily
Gary, Can you have a look at this? https://github.com/apache/commons-crypto/pull/242 Alex On Sun, Aug 27, 2023 at 8:38 AM Gary Gregory wrote: > On Fri, Aug 25, 2023 at 9:48 PM Alex Remily wrote: > > > > Breakup > > the current module into different maven modu

Re: [collections] AbstractLinkedList is source incompatible with JDK 21

2023-09-08 Thread Alex Herbert
On Fri, 8 Sept 2023 at 13:46, Alex Herbert wrote: > The problem then becomes how to support AbstractLinkedList and > CursorableLinkedList. Currently collections4 will not be source > compatible with JDK 21. Any downstream project that extends these > classes will not be source com

[collections] AbstractLinkedList is source incompatible with JDK 21

2023-09-08 Thread Alex Herbert
r a major revision bump. Note the new bloomfilter package is as yet unreleased. So choosing this option provides the ability to release a 5-beta to receive community feedback on the bloomfilter API before an official release. Any other options are welcomed for discussion. Alex [1] ht

Re: [commons-crypto] OpenSSL 3.x, FIPS, digests, and HMAC

2023-08-28 Thread Alex Remily
penssl.org/source/ Thoughts? Alex On Sun, Aug 27, 2023 at 8:38 AM Gary Gregory wrote: > On Fri, Aug 25, 2023 at 9:48 PM Alex Remily wrote: > > > > Breakup > > the current module into different maven modules? Not support both?> > > > > Agreed. Just to provide

Re: [commons-crypto] OpenSSL 3.x, FIPS, digests, and HMAC

2023-08-25 Thread Alex Remily
we limited to this distro or do we have other options? How do we form teams? What is our governance model? How do we make decisions? FYI: There's already issues on the backlog for OpenSSL 3 and HMAC: https://issues.apache.org/jira/browse/CRYPTO-165 https://issues.apache.org/jira/browse/CRYPT

Re: [commons-crypto] OpenSSL 3.x, FIPS, digests, and HMAC

2023-08-23 Thread Alex Remily
o generate some momentum. I would be happy to collaborate on this effort if it gains traction. Alex On Wed, Aug 23, 2023 at 5:21 PM Matt Sicker wrote: > You may find this project (also Apache licensed, so fairly safe for reuse > with commons-crypto updates) to be helpful for that aspect of me

Re: [Crypto] Compile From Source and Openssl3 Support

2023-08-09 Thread Alex Remily
a look if you haven't already. Alex On Wed, Aug 9, 2023, 2:01 PM Daniel Thertell wrote: > ya that's totally fine! > I will continue to try and figure this out. > > Thanks, > Dan Thertell > > > On Wed, Aug 9, 2023 at 4:53 PM Gary Gregory > wrote: > > &

Re: [commons-math] function or Number class to count/track number of significant figures

2023-08-09 Thread Alex Herbert
. And for this: 12345 + 10.0 12345 + 10 12345 + 1 12345 + 1.0 12345 + 1.00 You have to track the overlap of significant digits somehow. Alex - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional

Re: [commons-math] function or Number class to count/track number of significant figures

2023-08-09 Thread Alex Herbert
ity on the provider of the data to follow a format; and some on the parser to know what fields to analyse. Alex - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Re: [commons-math] function or Number class to count/track number of significant figures

2023-08-09 Thread Alex Herbert
ified using the text input. Support of significant zeros is limited to the full length of the trailing zeros, or the first zero if no decimal point is provided. This could be handled with a parse method that returns both the BigDecimal and the significant figures. Alex [1] https://issues.ap

Re: [VOTE][LAZY] Release Apache Commons Parent 59 based on RC1

2023-07-24 Thread Alex Herbert
I installed it locally from the git tag. I build the following projects with their default mvn goal using: Apache Maven 3.9.0 (9b58d2bad23a66be161c4664ef21ce219c2c8584) Maven home: /usr/local/apache-maven-3 Java version: 1.8.0_362, vendor: Private Build, runtime: /usr/lib/jvm/java-8-openjdk-amd64/

Re: [Pool] Toward version 2.12.0 and 3.0

2023-07-19 Thread Alex Herbert
a move would restrict downstream consumers of the library. Alex - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Re: Move math algorithms from all projects to math libraries

2023-07-18 Thread Alex Herbert
w module in numbers would be a chance to revisit the code. But it is a large and complex class. I would not change its implementation without a very thorough set of tests against other comparable unlimited precision number implementations in other libraries (Python mpmath; Maxima; Matlab vpa; e

  1   2   3   4   5   6   7   8   9   10   >