This vote passes with the following votes: +1: Gilles Sadowski (binding) +1: Gary Gregory (binding) +1: Alex Herbert (binding)
Thanks to all who inspected RC1 and 2. Alex On Fri, 12 Jul 2024 at 14:51, Gary D. Gregory <ggreg...@apache.org> wrote: > +1 > > I tested the src zip file: > - SHA512 OK > - ASC OK > - Running 'mvn' (default goal) OK, BUT: > > [INFO] --- javadoc:3.7.0:javadoc (default-cli) @ commons-rng-docs --- > [ERROR] Error fetching link: > C:\Users\ggregory\rc\commons-rng-1.6-src\commons-rng-client-api\target\apidocs. > Ignored it. > [ERROR] Error fetching link: > C:\Users\ggregory\rc\commons-rng-1.6-src\commons-rng-core\target\apidocs. > Ignored it. > [ERROR] Error fetching link: > C:\Users\ggregory\rc\commons-rng-1.6-src\commons-rng-simple\target\apidocs. > Ignored it. > [ERROR] Error fetching link: > C:\Users\ggregory\rc\commons-rng-1.6-src\commons-rng-sampling\target\apidocs. > Ignored it. > [INFO] No previous run data found, generating javadoc. > > Using: > > Apache Maven 3.9.8 (36645f6c9b5079805ea5009217e36f2cffd34256) > Maven home: C:\java\apache-maven-3.9.8 > Java version: 17.0.11, vendor: Eclipse Adoptium, runtime: C:\Program > Files\Eclipse Adoptium\jdk-17.0.11.9-hotspot > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" > > Gary > > On 2024/07/09 12:21:56 Alex Herbert wrote: > > We have fixed a few bugs and added enhancements since Apache Commons RNG > > 1.5 was released, so I would like to release Apache Commons RNG 1.6. > > > > Apache Commons RNG 1.6 RC2 is available for review here: > > https://dist.apache.org/repos/dist/dev/commons/rng/1.6-RC2 (svn > > revision 70197) > > > > The Git tag commons-rng-1.6-RC2 commit for this RC is commons-rng-1.6-RC2 > > which you can browse here: > > > > > https://gitbox.apache.org/repos/asf?p=commons-rng.git;a=commit;h=commons-rng-1.6-RC2 > > You may checkout this tag using: > > git clone https://gitbox.apache.org/repos/asf/commons-rng.git > --branch > > commons-rng-1.6-RC2 commons-rng-1.6-RC2 > > > > Maven artifacts are here: > > > > > https://repository.apache.org/content/repositories/orgapachecommons-1755/org/apache/commons/commons-rng/1.6/ > > > > These are the artifacts and their hashes: > > > > #Release SHA-512s > > #Tue Jul 09 12:29:41 BST 2024 > > > commons-rng-1.6-bin.tar.gz=ede8acdf030d658d5ee2164185cb4e4e3b402f3b7032202d29016df76946f1355c0e968677fcae6eafcff3a8d6439c70e3514013c07fa34048c3f33e2005e7e4 > > > commons-rng-1.6-bin.zip=6011e1ea66226592168e6fb67d0c2740cf537edc0d4b549423e5ba7761084cb7222982fdf09ef9a6b8ea29c45e4a6cd09137d4d9ffd20172008f26a8a0804486 > > > commons-rng-1.6-src.tar.gz=8cb6e78b7a27aaf9492f549848465987838fd490a97996c5f7d516a648093db777d63544cd4be7550de22d69b80b070fdfa5e1f6dd143c2e75c70db684a39e2e > > > commons-rng-1.6-src.zip=57e999f5f76155046cde915eaf33781f6361588a5e0d8776d4451149eca4d07fcf2b49612c5e6829181b75ad697e60f6243c0fedff0d932130315e44fe0a3237 > > > > Signatures may be validated on a system supporting a bash Unix shell by > > executing: > > svn co https://dist.apache.org/repos/dist/dev/commons/rng/1.6-RC2/ > > cd 1.6-RC2 > > chmod +x ./signature-validator.sh > > for m in client-api core simple sampling bom; do > > ./signature-validator.sh > > > https://repository.apache.org/content/repositories/orgapachecommons-1755/org/apache/commons/commons-rng-${m}/1.6/ > ; > > done > > > > The source code contains examples that are not part of the public API. > > These examples contain Java 11 modules and are enabled using a profile > (see > > below). > > > > Note: Testing randomness using statistical thresholds results in failures > > at a given probability. The 'maven-surefire-plugin' is configured to > re-run > > tests that fail, and pass the build if they succeed within the allotted > > number of reruns (the test will be marked as 'flaky' in the report). > > > > I have tested this with 'mvn clean install' and 'mvn clean package site > > site:stage -Pcommons-rng-examples' using: > > > > Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae) > > Maven home: /Users/ah403/software/apache-maven-3 > > Java version: 11.0.23, vendor: Eclipse Adoptium, runtime: > > /Library/Java/JavaVirtualMachines/temurin-11.jdk/Contents/Home > > Default locale: en_GB, platform encoding: UTF-8 > > OS name: "mac os x", version: "14.5", arch: "aarch64", family: "mac" > > > > > > Details of changes since 1.5 are in the release notes: > > > > > https://dist.apache.org/repos/dist/dev/commons/rng/1.6-RC2/RELEASE-NOTES.txt > > > > > https://home.apache.org/~aherbert/commons-rng-1.6-RC2-site/changes-report.html > > > > Site: > > > https://home.apache.org/~aherbert/commons-rng-1.6-RC2-site/index.html > > (note some *relative* links are broken and the 1.6 directories are > not > > yet created - these will be OK once the site is deployed.) > > > > The site has been staged in a personal Apache space as it includes the > > examples modules documentation. These are not > > staged to the SVN dev staging area as these are not part of the official > > release artifacts. > > > > JApiCmp Report (compared to 1.5): > > > > > https://home.apache.org/~aherbert/commons-rng-1.6-RC2-site/commons-rng-client-api/japicmp.html > > > > > https://home.apache.org/~aherbert/commons-rng-1.6-RC2-site/commons-rng-core/japicmp.html > > > > > https://home.apache.org/~aherbert/commons-rng-1.6-RC2-site/commons-rng-simple/japicmp.html > > > > > https://home.apache.org/~aherbert/commons-rng-1.6-RC2-site/commons-rng-sampling/japicmp.html > > > > RAT Report: > > > > > https://home.apache.org/~aherbert/commons-rng-1.6-RC2-site/rat-report.html > > > > KEYS: > > https://downloads.apache.org/commons/KEYS > > > > Please review the release candidate and vote. > > This vote will close no sooner than 72 hours from now. > > > > [ ] +1 Release these artifacts > > [ ] +0 OK, but... > > [ ] -0 OK, but really should fix... > > [ ] -1 I oppose this release because... > > > > Thank you, > > > > Alex Herbert, > > Release Manager (using key BC87A3FD0A54480F0BADBEBD21939FF0CA2A6567) > > > > The following is intended as a helper and refresher for reviewers. > > > > Validating a release candidate > > ============================== > > > > These guidelines are NOT complete. > > > > Requirements: Git, Java, Maven. > > > > You can validate a release from a release candidate (RC) tag as follows. > > > > 1a) Clone and checkout the RC tag > > > > git clone https://gitbox.apache.org/repos/asf/commons-rng.git --branch > > commons-rng-1.6-RC2 commons-rng-1.6-RC2 > > cd commons-rng-1.6-RC2 > > > > 1b) Download and unpack the source archive from: > > > > https://dist.apache.org/repos/dist/dev/commons/rng/1.6-RC2/source > > > > 2) Check Apache licenses > > > > This step is not required if the site includes a RAT report page which > you > > then must check. > > > > mvn apache-rat:check > > > > 3) Check binary compatibility > > > > Newer components use JApiCmp with the japicmp Maven Profile: > > > > This step is not required if the site includes a JApiCmp report page > which > > you then must check. > > > > mvn install -DskipTests -P japicmp japicmp:cmp > > > > 4) Build the package > > > > mvn -V clean package > > > > You can record the Maven and Java version produced by -V in your VOTE > reply. > > To gather OS information from a command line: > > Windows: ver > > Linux: uname -a > > > > 5) Build the site for a multi-module project > > > > mvn site > > mvn site:stage > > Check the site reports in: > > - Windows: target\site\index.html > > - Linux: target/site/index.html > > > > Note that the project reports are created for each module. > > Modules can be accessed using the 'Project Modules' link under > > the 'Project Information' menu (see <path-to-site>/modules.html). > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
