Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

xiaoxiang781216 commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083870748 ## drivers/misc/optee.c: ## @@ -1155,38 +1223,31 @@ int optee_shm_alloc(FAR struct optee_priv_data *priv, FAR void *addr, * ***

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

xiaoxiang781216 commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083955863 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on PR #16356: URL: https://github.com/apache/nuttx/pull/16356#issuecomment-2871033430 Had to remove `CONFIG_EXAMPLES_OPTEE` as it introduces a circular dependency with https://github.com/apache/nuttx-apps/pull/3074. I'll enable examples to `imx93-evk:koptee` in a ne

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083810701 ## drivers/misc/optee.c: ## @@ -925,20 +987,27 @@ optee_ioctl_shm_register(FAR struct optee_priv_data *priv, return -EFAULT; } - if (rdata->flags & TEE_

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083810701 ## drivers/misc/optee.c: ## @@ -925,20 +987,27 @@ optee_ioctl_shm_register(FAR struct optee_priv_data *priv, return -EFAULT; } - if (rdata->flags & TEE_

Re: [PR] sched/wdog: watchdog timer improvements. [nuttx]

Fix-Point commented on PR #16343: URL: https://github.com/apache/nuttx/pull/16343#issuecomment-2870721999 > @Fix-Point please fix: > > ``` > /home/runner/work/nuttx/nuttx/nuttx/include/nuttx/clock.h:601: leapyear ==> leap year > ``` Done. -- This is an automated messa

Re: [PR] arch/arm: fix arm-7a mmu using l1entry swap, we should use per-process mmu table, can speed up for above 10 times. [nuttx]

jasonbu commented on code in PR #16344: URL: https://github.com/apache/nuttx/pull/16344#discussion_r2083768247 ## arch/arm/src/armv7-a/arm_addrenv_utils.c: ## @@ -97,7 +97,14 @@ int arm_addrenv_create_region(uintptr_t **list, unsigned int listlen, nmapped = 0; for (i = 0;

Re: [PR] arch/arm: fix arm-7a mmu using l1entry swap, we should use per-process mmu table, can speed up for above 10 times. [nuttx]

jasonbu commented on code in PR #16344: URL: https://github.com/apache/nuttx/pull/16344#discussion_r2083763048 ## arch/arm/include/armv7-a/irq.h: ## @@ -303,13 +303,15 @@ struct xcptcontext #ifdef CONFIG_ARCH_ADDRENV #ifdef CONFIG_ARCH_STACK_DYNAMIC - /* This array holds th

Re: [PR] sched/wdog: watchdog timer improvements. [nuttx]

xiaoxiang781216 commented on PR #16343: URL: https://github.com/apache/nuttx/pull/16343#issuecomment-2870687790 @Fix-Point please fix: ``` /home/runner/work/nuttx/nuttx/nuttx/include/nuttx/clock.h:601: leapyear ==> leap year ``` -- This is an automated message from the Apache Gi

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

xiaoxiang781216 commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083737378 ## drivers/misc/optee.c: ## @@ -555,23 +555,22 @@ static int optee_close(FAR struct file *filep) return 0; } +#ifdef CONFIG_OPTEE_OPENVELA_COMPAT Review

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

xiaoxiang781216 commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083736499 ## drivers/misc/optee.c: ## @@ -533,7 +538,16 @@ static int optee_close(FAR struct file *filep) idr_for_each_entry(priv->shms, shm, id) { - optee

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

xiaoxiang781216 commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083736238 ## drivers/misc/optee.c: ## @@ -925,20 +987,27 @@ optee_ioctl_shm_register(FAR struct optee_priv_data *priv, return -EFAULT; } - if (rdata->flags

Re: [PR] Documentation: fix spelling [nuttx]

xiaoxiang781216 commented on PR #16318: URL: https://github.com/apache/nuttx/pull/16318#issuecomment-2870575447 > > > I would like to wrap this PR up. Is there anything missing? > > > > > > still has error not fix yet: https://github.com/apache/nuttx/actions/runs/14902428691/job/4

(nuttx-website) branch asf-site updated: Publishing web: 16e1777b863bd27e3a00b7b779baf0131af07df6 docs: b05ec7729d9b7fe85a6f11bfbb2da979255f44b7

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 18dfefcf9 Publishing web: 16e1777

Re: [PR] sched/wdog: watchdog timer improvements. [nuttx]

acassis commented on PR #16343: URL: https://github.com/apache/nuttx/pull/16343#issuecomment-2870205560 @lupyuen how can I add my milkv_duos to the CI? It should be nice if we could run this test automatically without calling the nuttxpr bot manually -- This is an automated message from t

Re: [PR] Documentation: fix spelling [nuttx]

sumpfralle commented on PR #16318: URL: https://github.com/apache/nuttx/pull/16318#issuecomment-2870190208 > > I would like to wrap this PR up. Is there anything missing? > > still has error not fix yet: https://github.com/apache/nuttx/actions/runs/14902428691/job/41857195862?pr=16318

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083587575 ## drivers/misc/optee.c: ## @@ -555,23 +555,22 @@ static int optee_close(FAR struct file *filep) return 0; } +#ifdef CONFIG_OPTEE_OPENVELA_COMPAT Review Comment

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083587575 ## drivers/misc/optee.c: ## @@ -555,23 +555,22 @@ static int optee_close(FAR struct file *filep) return 0; } +#ifdef CONFIG_OPTEE_OPENVELA_COMPAT Review Comment

Re: [PR] fix misspelled names in locally scoped code [nuttx]

sumpfralle commented on PR #16319: URL: https://github.com/apache/nuttx/pull/16319#issuecomment-2870029622 > @sumpfralle not all spell error in the touch files fixed: yes, that's what I described before: I grouped my fixes into different categories in order to allow an easier review (

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083581080 ## drivers/misc/optee.c: ## @@ -533,7 +538,16 @@ static int optee_close(FAR struct file *filep) idr_for_each_entry(priv->shms, shm, id) { - optee_shm_fr

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

xiaoxiang781216 commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083574539 ## drivers/misc/optee.c: ## @@ -533,7 +538,16 @@ static int optee_close(FAR struct file *filep) idr_for_each_entry(priv->shms, shm, id) { - optee

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083567372 ## drivers/misc/optee.c: ## @@ -533,7 +538,16 @@ static int optee_close(FAR struct file *filep) idr_for_each_entry(priv->shms, shm, id) { - optee_shm_fr

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083567372 ## drivers/misc/optee.c: ## @@ -533,7 +538,16 @@ static int optee_close(FAR struct file *filep) idr_for_each_entry(priv->shms, shm, id) { - optee_shm_fr

Re: [PR] fix misspelled names in locally scoped code [nuttx]

xiaoxiang781216 commented on PR #16319: URL: https://github.com/apache/nuttx/pull/16319#issuecomment-2869965904 @sumpfralle not all spell error in the touch files fixed: ``` ../nuttx/tools/checkpatch.sh -c -u -m -g b05ec7729d9b7fe85a6f11bfbb2da979255f44b7..HEAD Used config files:

Re: [PR] fix misspelled names in locally scoped code [nuttx]

sumpfralle commented on code in PR #16319: URL: https://github.com/apache/nuttx/pull/16319#discussion_r2083545595 ## libs/libc/wchar/lib_wcslcat.c: ## @@ -42,27 +42,27 @@ * Name: wcslcat * * Description: - * Appends src to string dst of size siz (unlike wcsncat, siz i

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

xiaoxiang781216 commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083543407 ## drivers/misc/optee.h: ## @@ -46,17 +45,19 @@ * Public Types / -struct optee

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

xiaoxiang781216 commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083542832 ## drivers/misc/optee.c: ## @@ -890,21 +941,32 @@ optee_ioctl_shm_alloc(FAR struct tee_ioctl_shm_alloc_data *data) if (ftruncate(memfd, data->size) < 0)

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

xiaoxiang781216 commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083542478 ## drivers/misc/optee.c: ## @@ -555,23 +555,22 @@ static int optee_close(FAR struct file *filep) return 0; } +#ifdef CONFIG_OPTEE_OPENVELA_COMPAT Review

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

xiaoxiang781216 commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083541883 ## tools/nxstyle.c: ## @@ -212,6 +212,7 @@ static const char *g_white_prefix[] = "luaL_", /* Ref: apps/interpreters/lua/lua-5.x.x/src/lauxlib.h */ "V4L

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

xiaoxiang781216 commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083540768 ## drivers/misc/optee.c: ## @@ -533,7 +538,16 @@ static int optee_close(FAR struct file *filep) idr_for_each_entry(priv->shms, shm, id) { - optee

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

xiaoxiang781216 commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083540768 ## drivers/misc/optee.c: ## @@ -533,7 +538,16 @@ static int optee_close(FAR struct file *filep) idr_for_each_entry(priv->shms, shm, id) { - optee

Re: [PR] fix misspelled names in locally scoped code [nuttx]

xiaoxiang781216 commented on PR #16319: URL: https://github.com/apache/nuttx/pull/16319#issuecomment-2869895349 > > yes, not all errors are fixed yet. All patch need pass ci check before get merging: [..] > > I would prefer, to postpone this. > > Locally I have another two or t

Re: [PR] fix misspelled names in locally scoped code [nuttx]

xiaoxiang781216 commented on code in PR #16319: URL: https://github.com/apache/nuttx/pull/16319#discussion_r2083538730 ## libs/libc/wchar/lib_wcslcat.c: ## @@ -42,27 +42,27 @@ * Name: wcslcat * * Description: - * Appends src to string dst of size siz (unlike wcsncat,

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083534871 ## drivers/misc/optee.c: ## @@ -555,23 +555,22 @@ static int optee_close(FAR struct file *filep) return 0; } +#ifdef CONFIG_OPTEE_OPENVELA_COMPAT Review Comment

Re: [I] [esp32] [nuttx]

461911662 commented on issue #16357: URL: https://github.com/apache/nuttx/issues/16357#issuecomment-2869879785 **Current defconfig:** liangliang@DESKTOP-BNU9SN9:~/wk/boss/nuttx_va$ cat defconfig # # This file is autogenerated: PLEASE DO NOT EDIT IT. # # You can use "make menuco

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083534871 ## drivers/misc/optee.c: ## @@ -555,23 +555,22 @@ static int optee_close(FAR struct file *filep) return 0; } +#ifdef CONFIG_OPTEE_OPENVELA_COMPAT Review Comment

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083466728 ## drivers/misc/optee.c: ## @@ -925,20 +987,27 @@ optee_ioctl_shm_register(FAR struct optee_priv_data *priv, return -EFAULT; } - if (rdata->flags & TEE_

[I] [esp32] [nuttx]

461911662 opened a new issue, #16357: URL: https://github.com/apache/nuttx/issues/16357 ### Description / Steps to reproduce the issue wifi set softap, can't work. **my config:** ./tools/configure.sh -a vendor/boss/app/nuttx-apps esp32-devkitc:wifi && make -j4 flash nuttx

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083531007 ## tools/nxstyle.c: ## @@ -212,6 +212,7 @@ static const char *g_white_prefix[] = "luaL_", /* Ref: apps/interpreters/lua/lua-5.x.x/src/lauxlib.h */ "V4L2_",

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083531007 ## tools/nxstyle.c: ## @@ -212,6 +212,7 @@ static const char *g_white_prefix[] = "luaL_", /* Ref: apps/interpreters/lua/lua-5.x.x/src/lauxlib.h */ "V4L2_",

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083525313 ## drivers/misc/optee.c: ## @@ -533,7 +538,16 @@ static int optee_close(FAR struct file *filep) idr_for_each_entry(priv->shms, shm, id) { - optee_shm_fr

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083525313 ## drivers/misc/optee.c: ## @@ -533,7 +538,16 @@ static int optee_close(FAR struct file *filep) idr_for_each_entry(priv->shms, shm, id) { - optee_shm_fr

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083525313 ## drivers/misc/optee.c: ## @@ -533,7 +538,16 @@ static int optee_close(FAR struct file *filep) idr_for_each_entry(priv->shms, shm, id) { - optee_shm_fr

Re: [PR] fix misspelled names in locally scoped code [nuttx]

sumpfralle commented on PR #16319: URL: https://github.com/apache/nuttx/pull/16319#issuecomment-2869830631 > yes, not all errors are fixed yet. All patch need pass ci check before get merging: [..] I would prefer, to postpone this. Locally I have another two or three PRs waitin

Re: [PR] boards:Using pwm on nuttx bp (Button and LED changes) [nuttx]

xiaoxiang781216 closed pull request #13151: boards:Using pwm on nuttx bp (Button and LED changes) URL: https://github.com/apache/nuttx/pull/13151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] drivers/mmcsd/mmcsd_sdio.c: use dma to receive setup if dma is enabled [nuttx]

xiaoxiang781216 merged PR #13164: URL: https://github.com/apache/nuttx/pull/13164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) branch master updated: drivers/mmcsd/mmcsd_sdio.c: use dma to receive setup if dma is enabled

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new b05ec7729d drivers/mmcsd/mmcsd_sdio.c: use dma

Re: [PR] [BREAKING] drivers/sensor: Add timestamp for GNSS data [nuttx]

xiaoxiang781216 merged PR #16355: URL: https://github.com/apache/nuttx/pull/16355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) branch master updated (36a4d5feaf -> 5fc950e608)

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 36a4d5feaf sched/wqueue: Improve performance of the work_queue. add fda251aad0 drivers/sensor: Add timestamp fo

Re: [PR] Add GlobalPlatform API client library (libteec) and example app (optee_gp) [nuttx-apps]

xiaoxiang781216 commented on code in PR #3074: URL: https://github.com/apache/nuttx-apps/pull/3074#discussion_r2083510940 ## examples/optee/optee_main.c: ## @@ -235,9 +243,8 @@ static int tee_shm_mmap(int fd, tee_shm_t *shm, bool reg) return ret; } -#endif -static int te

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

xiaoxiang781216 commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083510622 ## drivers/misc/optee.c: ## @@ -555,23 +555,22 @@ static int optee_close(FAR struct file *filep) return 0; } +#ifdef CONFIG_OPTEE_OPENVELA_COMPAT Review

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

xiaoxiang781216 commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083509981 ## tools/nxstyle.c: ## @@ -212,6 +212,7 @@ static const char *g_white_prefix[] = "luaL_", /* Ref: apps/interpreters/lua/lua-5.x.x/src/lauxlib.h */ "V4L

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

xiaoxiang781216 commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083509798 ## drivers/misc/optee.c: ## @@ -533,7 +538,16 @@ static int optee_close(FAR struct file *filep) idr_for_each_entry(priv->shms, shm, id) { - optee

Re: [PR] Added a small usability improve for Unix.mk savedefconfig [nuttx]

acassis commented on code in PR #16312: URL: https://github.com/apache/nuttx/pull/16312#discussion_r2083497065 ## tools/Unix.mk: ## @@ -768,6 +768,7 @@ savedefconfig: apps_preconfig $(Q) rm -f warning.tmp $(Q) rm -f defconfig.tmp $(Q) rm -f sortedconfig.t

Re: [PR] Added a small usability improve for Unix.mk savedefconfig [nuttx]

anchao commented on code in PR #16312: URL: https://github.com/apache/nuttx/pull/16312#discussion_r2083495087 ## tools/Unix.mk: ## @@ -768,6 +768,7 @@ savedefconfig: apps_preconfig $(Q) rm -f warning.tmp $(Q) rm -f defconfig.tmp $(Q) rm -f sortedconfig.tm

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083487421 ## drivers/misc/optee.c: ## @@ -555,23 +555,22 @@ static int optee_close(FAR struct file *filep) return 0; } +#ifdef CONFIG_OPTEE_OPENVELA_COMPAT Review Comment

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083487421 ## drivers/misc/optee.c: ## @@ -555,23 +555,22 @@ static int optee_close(FAR struct file *filep) return 0; } +#ifdef CONFIG_OPTEE_OPENVELA_COMPAT Review Comment

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083467486 ## drivers/misc/optee.c: ## @@ -890,21 +941,32 @@ optee_ioctl_shm_alloc(FAR struct tee_ioctl_shm_alloc_data *data) if (ftruncate(memfd, data->size) < 0) { +

Re: [PR] Added a small usability improve for Unix.mk savedefconfig [nuttx]

anchao commented on code in PR #16312: URL: https://github.com/apache/nuttx/pull/16312#discussion_r2083493875 ## tools/Unix.mk: ## @@ -768,6 +768,7 @@ savedefconfig: apps_preconfig $(Q) rm -f warning.tmp $(Q) rm -f defconfig.tmp $(Q) rm -f sortedconfig.tm

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083487421 ## drivers/misc/optee.c: ## @@ -555,23 +555,22 @@ static int optee_close(FAR struct file *filep) return 0; } +#ifdef CONFIG_OPTEE_OPENVELA_COMPAT Review Comment

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083486427 ## tools/nxstyle.c: ## @@ -212,6 +212,7 @@ static const char *g_white_prefix[] = "luaL_", /* Ref: apps/interpreters/lua/lua-5.x.x/src/lauxlib.h */ "V4L2_",

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083480191 ## drivers/misc/optee.c: ## @@ -533,7 +538,16 @@ static int optee_close(FAR struct file *filep) idr_for_each_entry(priv->shms, shm, id) { - optee_shm_fr

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083464712 ## drivers/misc/optee.h: ## @@ -46,17 +45,19 @@ * Public Types / -struct optee_shm_en

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083481142 ## drivers/misc/optee.c: ## @@ -568,20 +628,7 @@ static int optee_to_msg_param(FAR struct optee_msg_param *mparams, case TEE_IOCTL_PARAM_ATTR_TYPE_MEMREF_I

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083480191 ## drivers/misc/optee.c: ## @@ -533,7 +538,16 @@ static int optee_close(FAR struct file *filep) idr_for_each_entry(priv->shms, shm, id) { - optee_shm_fr

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083480191 ## drivers/misc/optee.c: ## @@ -533,7 +538,16 @@ static int optee_close(FAR struct file *filep) idr_for_each_entry(priv->shms, shm, id) { - optee_shm_fr

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083480191 ## drivers/misc/optee.c: ## @@ -533,7 +538,16 @@ static int optee_close(FAR struct file *filep) idr_for_each_entry(priv->shms, shm, id) { - optee_shm_fr

Re: [PR] Added a small usability improve for Unix.mk savedefconfig [nuttx]

acassis commented on code in PR #16312: URL: https://github.com/apache/nuttx/pull/16312#discussion_r2083478973 ## tools/Unix.mk: ## @@ -768,6 +768,7 @@ savedefconfig: apps_preconfig $(Q) rm -f warning.tmp $(Q) rm -f defconfig.tmp $(Q) rm -f sortedconfig.t

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083467486 ## drivers/misc/optee.c: ## @@ -890,21 +941,32 @@ optee_ioctl_shm_alloc(FAR struct tee_ioctl_shm_alloc_data *data) if (ftruncate(memfd, data->size) < 0) { +

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083466728 ## drivers/misc/optee.c: ## @@ -925,20 +987,27 @@ optee_ioctl_shm_register(FAR struct optee_priv_data *priv, return -EFAULT; } - if (rdata->flags & TEE_

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083464712 ## drivers/misc/optee.h: ## @@ -46,17 +45,19 @@ * Public Types / -struct optee_shm_en

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083464712 ## drivers/misc/optee.h: ## @@ -46,17 +45,19 @@ * Public Types / -struct optee_shm_en

Re: [PR] Add GlobalPlatform API client library (libteec) and example app (optee_gp) [nuttx-apps]

gpoulios commented on code in PR #3074: URL: https://github.com/apache/nuttx-apps/pull/3074#discussion_r2083437970 ## examples/optee/optee_main.c: ## @@ -235,9 +243,8 @@ static int tee_shm_mmap(int fd, tee_shm_t *shm, bool reg) return ret; } -#endif -static int tee_shm_a

Re: [PR] Add GlobalPlatform API client library (libteec) and example app (optee_gp) [nuttx-apps]

gpoulios commented on code in PR #3074: URL: https://github.com/apache/nuttx-apps/pull/3074#discussion_r2083437970 ## examples/optee/optee_main.c: ## @@ -235,9 +243,8 @@ static int tee_shm_mmap(int fd, tee_shm_t *shm, bool reg) return ret; } -#endif -static int tee_shm_a