xiaoxiang781216 commented on code in PR #16356:
URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083540768
##########
drivers/misc/optee.c:
##########
@@ -533,7 +538,16 @@ static int optee_close(FAR struct file *filep)
idr_for_each_entry(priv->shms, shm, id)
{
- optee_shm_free(shm);
+ if (shm->fd > -1)
+ {
+ /* The user did not call close(), do it here */
+
+ nx_close(shm->fd);
Review Comment:
because the user may close shm handler manually, which may:
1. close return EBADF if the same handle doesn't reuse by open yet
2. close the wrong handle with succeed if the same handle reuse by open
The first is minor issue, but the second one is fatal problem which must be
fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
