xiaoxiang781216 commented on PR #16318: URL: https://github.com/apache/nuttx/pull/16318#issuecomment-2870575447
> > > I would like to wrap this PR up. Is there anything missing? > > > > > > still has error not fix yet: https://github.com/apache/nuttx/actions/runs/14902428691/job/41857195862?pr=16318 https://github.com/apache/nuttx/actions/runs/14902428711/job/41857195812?pr=16318 > > These remaining issues were beyound my understanding of the original author's intention. Thus, I cecided to refrain from guessing (and potentially breaking) their meaning. > > I think, [my comment from #16319](https://github.com/apache/nuttx/pull/16319#issuecomment-2870029622) applies here, as well: I think, I prepared the spelling fixes commits with a good amount of care and diligence. But I do not think, we should burden my commits for "fixing 99% of spelling issues" with the task of really fixing 100% of the issues, just because I introduced the new CI checks _before_ all of my commits were merged. why not fix the spell error file by file? so you can group the reasonable number of files in one patch and fix all spelling problem in them. All members include PMC have to follow the guide enforce by the community, which require: 1. Pass all CI check 2. the breaking change need be voted and passed in community 3. At least two people approve the change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
