gpoulios commented on code in PR #16356:
URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083810701
##########
drivers/misc/optee.c:
##########
@@ -925,20 +987,27 @@ optee_ioctl_shm_register(FAR struct optee_priv_data *priv,
return -EFAULT;
}
- if (rdata->flags & TEE_SHM_ALLOC)
+ if (rdata->flags)
{
return -EINVAL;
}
ret = optee_shm_alloc(priv, (FAR void *)(uintptr_t)rdata->addr,
Review Comment:
Funny how we make a full circle: That’s also my question in my first ever
email to you before my PRs. I did not put the mmap there.
But, with the proper implementation, we do need to get the **pagelist** to
pass during invocation, and I guess we would have to do it (the mmap) again, so
better do it once here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
