jasonbu commented on code in PR #16344:
URL: https://github.com/apache/nuttx/pull/16344#discussion_r2083768247
##########
arch/arm/src/armv7-a/arm_addrenv_utils.c:
##########
@@ -97,7 +97,14 @@ int arm_addrenv_create_region(uintptr_t **list, unsigned int
listlen,
nmapped = 0;
for (i = 0; i < nlist; i++)
{
- /* Allocate one physical page for the L2 page table */
+ /* Allocate one physical page for the L2 page table
+ * Makesure physical page is contiguous, alloc all l2 table first.
+ *
+ * REVISIT: Drivers should not expect the physical page is contiguous
Review Comment:
dropped the contiguous requirements patch, as it should not done in arch
layer, should be fixed in driver. x86/riscv/arm64 all use same layout before
the change. also there is no requirements in community code. let's only solve
the performance issue in this pull request at first. then create a new patch
to solve the driver va_to_pa as a instead. or change all arch to modify the mmu
table layout to ensure contiguous.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
