gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083534871
########## drivers/misc/optee.c: ########## @@ -555,23 +555,22 @@ static int optee_close(FAR struct file *filep) return 0; } +#ifdef CONFIG_OPTEE_OPENVELA_COMPAT Review Comment: My point is, why should my PR get delayed for something that existed from day-1 of this driver? Just because I’m raising awareness? Socket developer (or whoever introduced this) can remove it at their own convenience, once ready, with a new PR. It’s just removal, should be straightforward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
