gpoulios commented on code in PR #16356:
URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083567372
##########
drivers/misc/optee.c:
##########
@@ -533,7 +538,16 @@ static int optee_close(FAR struct file *filep)
idr_for_each_entry(priv->shms, shm, id)
{
- optee_shm_free(shm);
+ if (shm->fd > -1)
+ {
+ /* The user did not call close(), do it here */
+
+ nx_close(shm->fd);
Review Comment:
@xiaoxiang781216 What is the appropriate interface to do this?
I tried to use `fs_reffilep()/fs_putfilep()` on the optee `filep` but as
soon as I call `fs_reffilep()` it crashes (I'm still troubleshooting it).
And I don't see many uses of `fs_reffilep()`, contrary to `fs_putfilep()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
