Re: [PR] arm: remove up_set_current_regs/up_current_regs [nuttx]

2024-11-25 Thread via GitHub
anchao commented on PR #14865: URL: https://github.com/apache/nuttx/pull/14865#issuecomment-2499916205 > > I don't see any optimization for the current code in this commit, it's just an API rename, up_set_current_regs / up_current_regs - > > current_regs doesn't save/restore anymore b

Re: [PR] spin_lock_irqsave+sched_lock [nuttx]

2024-11-25 Thread via GitHub
anchao commented on code in PR #14578: URL: https://github.com/apache/nuttx/pull/14578#discussion_r1857900343 ## sched/sched/sched_unlock.c: ## @@ -37,281 +37,178 @@ #include "sched/sched.h" / - * Pu

Re: [PR] Fix compilation errors [nuttx]

2024-11-25 Thread via GitHub
nuttxpr commented on PR #14945: URL: https://github.com/apache/nuttx/pull/14945#issuecomment-2499824971 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) ## Does this PR meet the NuttX Requirements? Please be

Re: [PR] trace: replace all *_wo_note to *_notrace to make api define more approachable [nuttx]

2024-11-25 Thread via GitHub
anchao commented on code in PR #14943: URL: https://github.com/apache/nuttx/pull/14943#discussion_r1857925648 ## drivers/note/note_driver.c: ## @@ -1837,7 +1837,7 @@ void sched_note_filter_mode(FAR struct note_filter_named_mode_s *oldm, irqstate_t irq_mask; FAR struct not

[PR] boards/xtensa/esp32s3: Treat return value that greater than zero as succ [nuttx]

2024-11-25 Thread via GitHub
JianyuWang0623 opened a new pull request, #14949: URL: https://github.com/apache/nuttx/pull/14949 ## Summary Treat return value that greater than zero as succ. `parse_mtd_partition()` may return value that greater than zero when succ. e.g: board_spiflash_init() => init_storage_partit

Re: [PR] Fix compilation errors [nuttx]

2024-11-25 Thread via GitHub
anchao commented on code in PR #14945: URL: https://github.com/apache/nuttx/pull/14945#discussion_r1857913819 ## libs/libbuiltin/libgcc/gcov.c: ## @@ -205,6 +205,11 @@ static int gcov_process_path(FAR char *prefix, int strip, prefix_count = token_count; token = strtok(pa

Re: [PR] lfs_vfs:Use provided lfs_getattr / lfs_setattr instead of lfs_file_getattr / lfs_ file_setattr [nuttx]

2024-11-25 Thread via GitHub
xiaoxiang781216 commented on code in PR #14901: URL: https://github.com/apache/nuttx/pull/14901#discussion_r1857893655 ## fs/littlefs/lfs_vfs.c: ## @@ -816,16 +834,31 @@ static int littlefs_fchstat(FAR const struct file *filep, inode = filep->f_inode; fs= inode->i_priv

Re: [PR] lfs_vfs:Use provided lfs_getattr / lfs_setattr instead of lfs_file_getattr / lfs_ file_setattr [nuttx]

2024-11-25 Thread via GitHub
yamt commented on code in PR #14901: URL: https://github.com/apache/nuttx/pull/14901#discussion_r1857866334 ## fs/littlefs/lfs_vfs.c: ## @@ -816,16 +834,31 @@ static int littlefs_fchstat(FAR const struct file *filep, inode = filep->f_inode; fs= inode->i_private; + p

Re: [PR] gcov: Add usage documentation [nuttx]

2024-11-25 Thread via GitHub
xiaoxiang781216 commented on PR #14946: URL: https://github.com/apache/nuttx/pull/14946#issuecomment-2499747683 Please fix: ``` /home/runner/work/nuttx/nuttx/Documentation/applications/system/gcov/index.rst:32:Option list ends without a blank line; unexpected unindent. make: *** [M

Re: [PR] spin_lock_irqsave+sched_lock [nuttx]

2024-11-25 Thread via GitHub
hujun260 commented on code in PR #14578: URL: https://github.com/apache/nuttx/pull/14578#discussion_r1857850907 ## sched/sched/sched_unlock.c: ## @@ -37,281 +37,178 @@ #include "sched/sched.h" / - *

Re: [PR] libc/stdout: add an option to redirect standard output stream to syslog [nuttx]

2024-11-25 Thread via GitHub
yamt commented on code in PR #14923: URL: https://github.com/apache/nuttx/pull/14923#discussion_r1857848632 ## drivers/syslog/Kconfig: ## @@ -407,5 +407,25 @@ config SYSLOG_REGISTER ---help--- This option will support register the syslog channel dynamica

Re: [PR] spin_lock_irqsave+sched_lock [nuttx]

2024-11-25 Thread via GitHub
hujun260 commented on code in PR #14578: URL: https://github.com/apache/nuttx/pull/14578#discussion_r1857850942 ## sched/sched/sched_unlock.c: ## @@ -37,281 +37,178 @@ #include "sched/sched.h" / - *

Re: [PR] trace: replace all *_wo_note to *_notrace to make api define more approachable [nuttx]

2024-11-25 Thread via GitHub
xiaoxiang781216 commented on code in PR #14943: URL: https://github.com/apache/nuttx/pull/14943#discussion_r1857849917 ## drivers/note/note_driver.c: ## @@ -1837,7 +1837,7 @@ void sched_note_filter_mode(FAR struct note_filter_named_mode_s *oldm, irqstate_t irq_mask; FAR s

(nuttx) branch master updated (d2dc2c796d -> 22e8e65789)

2024-11-25 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from d2dc2c796d Path Error add 22e8e65789 boards/esp32s3: Add depends ESP32-S3-WROOM-1-N8R8 for ESP32S3_DEVKIT No

Re: [PR] boards/esp32s3: Add ESP32-S3-WROOM-1-N8R8 depends for ESP32S3_DEVKIT [nuttx]

2024-11-25 Thread via GitHub
xiaoxiang781216 merged PR #14947: URL: https://github.com/apache/nuttx/pull/14947 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] spin_lock_irqsave+sched_lock [nuttx]

2024-11-25 Thread via GitHub
hujun260 commented on code in PR #14578: URL: https://github.com/apache/nuttx/pull/14578#discussion_r1857850443 ## include/sys/syscall_lookup.h: ## @@ -41,10 +41,12 @@ SYSCALL_LOOKUP(sched_getparam, 2) SYSCALL_LOOKUP(sched_getscheduler, 1) SYSCALL_LOOKUP(sc

Re: [PR] libc/stdout: add an option to redirect standard output stream to syslog [nuttx]

2024-11-25 Thread via GitHub
yamt commented on code in PR #14923: URL: https://github.com/apache/nuttx/pull/14923#discussion_r1857845192 ## drivers/syslog/Kconfig: ## @@ -407,5 +407,25 @@ config SYSLOG_REGISTER ---help--- This option will support register the syslog channel dynamica

(nuttx) branch master updated (3e24aab208 -> d2dc2c796d)

2024-11-25 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 3e24aab208 stream_getc: use lib_stream_eof instead of EOF add d2dc2c796d Path Error No new revisions were adde

Re: [PR] Fix path Error [nuttx]

2024-11-25 Thread via GitHub
xiaoxiang781216 merged PR #14944: URL: https://github.com/apache/nuttx/pull/14944 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] Fix path Error [nuttx]

2024-11-25 Thread via GitHub
xiaoxiang781216 commented on PR #14944: URL: https://github.com/apache/nuttx/pull/14944#issuecomment-2499719833 let's ignore the riscv known ct error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] libc/stdout: add an option to redirect standard output stream to syslog [nuttx]

2024-11-25 Thread via GitHub
yamt commented on code in PR #14923: URL: https://github.com/apache/nuttx/pull/14923#discussion_r1857803776 ## drivers/syslog/Kconfig: ## @@ -407,5 +407,25 @@ config SYSLOG_REGISTER ---help--- This option will support register the syslog channel dynamica

Re: [PR] libc/stdout: add an option to redirect standard output stream to syslog [nuttx]

2024-11-25 Thread via GitHub
anchao commented on code in PR #14923: URL: https://github.com/apache/nuttx/pull/14923#discussion_r1857802387 ## drivers/syslog/Kconfig: ## @@ -407,5 +407,25 @@ config SYSLOG_REGISTER ---help--- This option will support register the syslog channel dynami

Re: [PR] libc/stdout: add an option to redirect standard output stream to syslog [nuttx]

2024-11-25 Thread via GitHub
yamt commented on code in PR #14923: URL: https://github.com/apache/nuttx/pull/14923#discussion_r1857788934 ## drivers/syslog/Kconfig: ## @@ -407,5 +407,25 @@ config SYSLOG_REGISTER ---help--- This option will support register the syslog channel dynamica

Re: [PR] libc/stdout: add an option to redirect standard output stream to syslog [nuttx]

2024-11-25 Thread via GitHub
anchao commented on code in PR #14923: URL: https://github.com/apache/nuttx/pull/14923#discussion_r1857784368 ## drivers/syslog/Kconfig: ## @@ -407,5 +407,25 @@ config SYSLOG_REGISTER ---help--- This option will support register the syslog channel dynami

Re: [PR] libc/stdout: add an option to redirect standard output stream to syslog [nuttx]

2024-11-25 Thread via GitHub
yamt commented on code in PR #14923: URL: https://github.com/apache/nuttx/pull/14923#discussion_r1857773567 ## drivers/syslog/Kconfig: ## @@ -407,5 +407,25 @@ config SYSLOG_REGISTER ---help--- This option will support register the syslog channel dynamica

[PR] fs/partition/txtable: Fix panic when no txtable was found in last eraseblock [nuttx]

2024-11-25 Thread via GitHub
JianyuWang0623 opened a new pull request, #14948: URL: https://github.com/apache/nuttx/pull/14948 ## Summary Panic occured if no txtable was found in last eraseblock of MTD device and `CONFIG_TXTABLE_DEFAULT_PARTITION` was disabled Backtrace ``` sched_dumpstack /worksp

Re: [PR] arm: remove up_set_current_regs/up_current_regs [nuttx]

2024-11-25 Thread via GitHub
xiaoxiang781216 commented on PR #14865: URL: https://github.com/apache/nuttx/pull/14865#issuecomment-2499631737 > I don't see any optimization for the current code in this commit, it's just an API rename, up_set_current_regs / up_current_regs - current_regs doesn't save/restore anymor

[PR] boards/esp32s3: Add ESP32-S3-WROOM-1-N8R8 for ESP32S3_DEVKIT [nuttx]

2024-11-25 Thread via GitHub
JianyuWang0623 opened a new pull request, #14947: URL: https://github.com/apache/nuttx/pull/14947 ## Summary Env ``` esp32s3-devkit:usbnsh ``` Problem # The `CONFIG_ARCH_BOARD_ESP32S3_DEVKIT` will be disabled if `CONFIG_ARCH_CHIP_ESP32S3WROOM1N8R8` select

Re: [PR] arm: remove up_set_current_regs/up_current_regs [nuttx]

2024-11-25 Thread via GitHub
xiaoxiang781216 commented on code in PR #14865: URL: https://github.com/apache/nuttx/pull/14865#discussion_r1857745905 ## arch/arm/src/dm320/dm320_decodeirq.c: ## @@ -109,11 +102,9 @@ uint32_t *arm_decodeirq(uint32_t *regs) } #endif - /* Set current_regs

Re: [PR] gcov: Add usage documentation [nuttx]

2024-11-25 Thread via GitHub
nuttxpr commented on PR #14946: URL: https://github.com/apache/nuttx/pull/14946#issuecomment-2499613219 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR template itself meets the NuttX requirements by

Re: [PR] spin_lock_irqsave+sched_lock [nuttx]

2024-11-25 Thread via GitHub
anchao commented on code in PR #14578: URL: https://github.com/apache/nuttx/pull/14578#discussion_r1857739020 ## sched/sched/sched_unlock.c: ## @@ -37,281 +37,178 @@ #include "sched/sched.h" / - * Pu

Re: [PR] arm: remove up_set_current_regs/up_current_regs [nuttx]

2024-11-25 Thread via GitHub
anchao commented on code in PR #14865: URL: https://github.com/apache/nuttx/pull/14865#discussion_r1857733706 ## arch/arm/src/dm320/dm320_decodeirq.c: ## @@ -109,11 +102,9 @@ uint32_t *arm_decodeirq(uint32_t *regs) } #endif - /* Set current_regs to NULL

[PR] gcov: Add usage documentation [nuttx]

2024-11-25 Thread via GitHub
W-M-R opened a new pull request, #14946: URL: https://github.com/apache/nuttx/pull/14946 *Note: Please adhere to [Contributing Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).* ## Summary *Update this section with information on why change is necessary,

Re: [PR] spin_lock_irqsave+sched_lock [nuttx]

2024-11-25 Thread via GitHub
anchao commented on code in PR #14578: URL: https://github.com/apache/nuttx/pull/14578#discussion_r1857722335 ## include/sys/syscall_lookup.h: ## @@ -41,10 +41,12 @@ SYSCALL_LOOKUP(sched_getparam, 2) SYSCALL_LOOKUP(sched_getscheduler, 1) SYSCALL_LOOKUP(sche

[PR] Fix compilation errors [nuttx]

2024-11-25 Thread via GitHub
W-M-R opened a new pull request, #14945: URL: https://github.com/apache/nuttx/pull/14945 ## Summary CC: gcov.c gcov.c: In function 'gcov_stdout_dump': gcov.c:146:50: error: passing argument 3 of '__gcov_info_to_gcda' from incompatible pointer type [-Werror=incompatible-poi

Re: [PR] Fix compilation errors [nuttx]

2024-11-25 Thread via GitHub
anchao commented on code in PR #14945: URL: https://github.com/apache/nuttx/pull/14945#discussion_r1857714126 ## libs/libbuiltin/libgcc/gcov.c: ## @@ -185,8 +185,8 @@ static int gcov_process_path(FAR char *prefix, int strip, FAR char *path, FAR char

[PR] Fix path Error [nuttx]

2024-11-25 Thread via GitHub
W-M-R opened a new pull request, #14944: URL: https://github.com/apache/nuttx/pull/14944 *Note: Please adhere to [Contributing Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).* ## Summary *Update this section with information on why change is necessary,

(nuttx) branch master updated: stream_getc: use lib_stream_eof instead of EOF

2024-11-25 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 3e24aab208 stream_getc: use lib_stream_eof ins

Re: [PR] stream_getc: use lib_stream_eof instead of EOF [nuttx]

2024-11-25 Thread via GitHub
xiaoxiang781216 merged PR #14924: URL: https://github.com/apache/nuttx/pull/14924 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) branch master updated: armv8-r/libc: optimize libc string apis with asm

2024-11-25 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new f3213efc7f armv8-r/libc: optimize libc string

Re: [PR] armv8-r/libc: optimize libc string apis with asm [nuttx]

2024-11-25 Thread via GitHub
xiaoxiang781216 merged PR #14928: URL: https://github.com/apache/nuttx/pull/14928 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] trace: replace all *_wo_note to *_notrace to make api define more approachable [nuttx]

2024-11-25 Thread via GitHub
anchao commented on code in PR #14943: URL: https://github.com/apache/nuttx/pull/14943#discussion_r1857667174 ## drivers/note/note_driver.c: ## @@ -1837,7 +1837,7 @@ void sched_note_filter_mode(FAR struct note_filter_named_mode_s *oldm, irqstate_t irq_mask; FAR struct not

Re: [PR] spinlock: remove recursive locks with write_lock_irqsave/read_lock_irqsave [nuttx]

2024-11-25 Thread via GitHub
xiaoxiang781216 merged PR #14939: URL: https://github.com/apache/nuttx/pull/14939 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) branch master updated: spinlock: remove recursive locks with write_lock_irqsave/read_lock_irqsave

2024-11-25 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new f5136b2afa spinlock: remove recursive locks wi

(nuttx) branch master updated: use spin_lock_wo_note replace spin_lock in csection

2024-11-25 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 33226a9bb7 use spin_lock_wo_note replace spin_

Re: [PR] use spin_lock_wo_note replace spin_lock in csection [nuttx]

2024-11-25 Thread via GitHub
xiaoxiang781216 merged PR #14930: URL: https://github.com/apache/nuttx/pull/14930 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] [ci] platforms: added toolchains [nuttx]

2024-11-25 Thread via GitHub
xiaoxiang781216 merged PR #14934: URL: https://github.com/apache/nuttx/pull/14934 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] note: Remove enter_critical_section from the sched_note module [nuttx]

2024-11-25 Thread via GitHub
xiaoxiang781216 merged PR #14926: URL: https://github.com/apache/nuttx/pull/14926 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) branch master updated: [ci] platforms: added toolchains

2024-11-25 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 00f831028f [ci] platforms: added toolchains 00

(nuttx) branch master updated (111a0746c2 -> eb65c5a8cd)

2024-11-25 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 111a0746c2 arm64: change name saved_reg to saved_regs add eb65c5a8cd note: Remove enter_critical_section from t

Re: [PR] build(deps): bump codelytv/pr-size-labeler from 1.10.1 to 1.10.2 [nuttx-apps]

2024-11-25 Thread via GitHub
xiaoxiang781216 merged PR #2866: URL: https://github.com/apache/nuttx-apps/pull/2866 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

(nuttx-apps) branch dependabot/github_actions/codelytv/pr-size-labeler-1.10.2 deleted (was abc11b022)

2024-11-25 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/github_actions/codelytv/pr-size-labeler-1.10.2 in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git was abc11b022 build(deps): bump codelytv/pr-size-labeler from

(nuttx-apps) branch master updated: build(deps): bump codelytv/pr-size-labeler from 1.10.1 to 1.10.2

2024-11-25 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 3f418f482 build(deps): bump codelytv/pr-s

Re: [PR] arm64: change name saved_reg to saved_regs [nuttx]

2024-11-25 Thread via GitHub
xiaoxiang781216 merged PR #14940: URL: https://github.com/apache/nuttx/pull/14940 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) branch master updated: arm64: change name saved_reg to saved_regs

2024-11-25 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 111a0746c2 arm64: change name saved_reg to sav

Re: [PR] trace: replace all *_wo_note to *_notrace to make api define more approachable [nuttx]

2024-11-25 Thread via GitHub
xiaoxiang781216 commented on code in PR #14943: URL: https://github.com/apache/nuttx/pull/14943#discussion_r1857562807 ## drivers/note/note_driver.c: ## @@ -1837,7 +1837,7 @@ void sched_note_filter_mode(FAR struct note_filter_named_mode_s *oldm, irqstate_t irq_mask; FAR s

Re: [PR] spin_lock_irqsave+sched_lock [nuttx]

2024-11-25 Thread via GitHub
hujun260 commented on code in PR #14578: URL: https://github.com/apache/nuttx/pull/14578#discussion_r1857550677 ## sched/sched/sched_unlock.c: ## @@ -40,278 +40,155 @@ * Public Functions / -/**

Re: [PR] espressif/mcpwm: fix compile error [nuttx]

2024-11-25 Thread via GitHub
nuttxpr commented on PR #14942: URL: https://github.com/apache/nuttx/pull/14942#issuecomment-2499369060 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements.

Re: [PR] trace: replace all *_wo_note to *_notrace to make api define more approachable [nuttx]

2024-11-25 Thread via GitHub
nuttxpr commented on PR #14943: URL: https://github.com/apache/nuttx/pull/14943#issuecomment-2499361984 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements.

[PR] trace: replace all *_wo_note to _notrace to make api define more approachable [nuttx]

2024-11-25 Thread via GitHub
anchao opened a new pull request, #14943: URL: https://github.com/apache/nuttx/pull/14943 ## Summary trace: replace all *_wo_note to _notrace to make api define more approachable Follow the linux naming style: https://github.com/torvalds/linux/blob/master/include/lin

[PR] espressif/mcpwm: fix compile error [nuttx]

2024-11-25 Thread via GitHub
anchao opened a new pull request, #14942: URL: https://github.com/apache/nuttx/pull/14942 ## Summary espressif/mcpwm: fix compile error continue work of PR #14938 Signed-off-by: chao an ## Impact N/A ## Testing ci-check -- This is a

Re: [PR] sched/lockcount: replace all lockcount check to nxsched_islocked_tcb() [nuttx]

2024-11-25 Thread via GitHub
nuttxpr commented on PR #14941: URL: https://github.com/apache/nuttx/pull/14941#issuecomment-2499344385 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements.

(nuttx) branch master updated: fix build error

2024-11-25 Thread archer
This is an automated email from the ASF dual-hosted git repository. archer pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 53548509b1 fix build error 53548509b1 is describe

Re: [PR] fix build error [nuttx]

2024-11-25 Thread via GitHub
anchao merged PR #14938: URL: https://github.com/apache/nuttx/pull/14938 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apach

[PR] sched/lockcount: replace all lockcount check to nxsched_islocked_tcb() [nuttx]

2024-11-25 Thread via GitHub
anchao opened a new pull request, #14941: URL: https://github.com/apache/nuttx/pull/14941 ## Summary sched/lockcount: replace all lockcount check to nxsched_islocked_tcb() replace all lockcount check to nxsched_islocked_tcb() Signed-off-by: chao an ## Impact

(nuttx-website) branch asf-site updated: Publishing web: b0df2aeab6e41e7f7f2ff29ca7dee29d2f62f031 docs: 92b9a30878169cd354cc67b31749fa575042afe7

2024-11-25 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new e51d4ce53 Publishing web: b0df2ae

Re: [PR] spin_lock_irqsave+sched_lock [nuttx]

2024-11-25 Thread via GitHub
anchao commented on code in PR #14578: URL: https://github.com/apache/nuttx/pull/14578#discussion_r1857511553 ## sched/sched/sched_unlock.c: ## @@ -40,278 +40,155 @@ * Public Functions / -/

[PR] arm64: change name saved_reg to saved_regs [nuttx]

2024-11-25 Thread via GitHub
hujun260 opened a new pull request, #14940: URL: https://github.com/apache/nuttx/pull/14940 ## Summary arm64: change name saved_reg to saved_regs reason: saved_regs is more meaningful and used by all other arch ## Impact none ## Testing ci -- This i

Re: [PR] spinlock: remove recursive locks with write_lock_irqsave/read_lock_irqsave [nuttx]

2024-11-25 Thread via GitHub
nuttxpr commented on PR #14939: URL: https://github.com/apache/nuttx/pull/14939#issuecomment-2499275574 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements.

[PR] spinlock: remove recursive locks with write_lock_irqsave/read_lock_irqsave [nuttx]

2024-11-25 Thread via GitHub
hujun260 opened a new pull request, #14939: URL: https://github.com/apache/nuttx/pull/14939 ## Summary spinlock: remove recursive locks with write_lock_irqsave/read_lock_irqsave reason: 1 There is a similar PR, https://github.com/apache/nuttx/pull/14079, 2 Currently, no on

Re: [PR] fix build error [nuttx]

2024-11-25 Thread via GitHub
nuttxpr commented on PR #14938: URL: https://github.com/apache/nuttx/pull/14938#issuecomment-2499260441 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does **not** meet the NuttX requirements.

[PR] fix build error [nuttx]

2024-11-25 Thread via GitHub
hujun260 opened a new pull request, #14938: URL: https://github.com/apache/nuttx/pull/14938 ## Summary common/espressif/esp_rmt.c: In function 'rmt_set_tx_thr_intr_en': common/espressif/esp_rmt.c:654:48: error: passing argument 1 of 'spin_lock_irqsave' makes pointer from integer with

Re: [PR] fs/littlefs: make CONFIG_FS_LITTLEFS_VERSION include the "v" prefix [nuttx]

2024-11-25 Thread via GitHub
acassis merged PR #14935: URL: https://github.com/apache/nuttx/pull/14935 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

(nuttx) branch master updated: fs/littlefs: make CONFIG_FS_LITTLEFS_VERSION include the "v" prefix

2024-11-25 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 92b9a30878 fs/littlefs: make CONFIG_FS_LITTLEFS_

[PR] build(deps): bump codelytv/pr-size-labeler from 1.10.1 to 1.10.2 [nuttx-apps]

2024-11-25 Thread via GitHub
dependabot[bot] opened a new pull request, #2866: URL: https://github.com/apache/nuttx-apps/pull/2866 Bumps [codelytv/pr-size-labeler](https://github.com/codelytv/pr-size-labeler) from 1.10.1 to 1.10.2. Release notes Sourced from https://github.com/codelytv/pr-size-labeler/release

(nuttx-apps) branch dependabot/github_actions/codelytv/pr-size-labeler-1.10.2 created (now abc11b022)

2024-11-25 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/github_actions/codelytv/pr-size-labeler-1.10.2 in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git at abc11b022 build(deps): bump codelytv/pr-size-labeler from

(nuttx) branch master updated: Documentation: fix nuttxgdb related commands

2024-11-25 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 224a8f4b28 Documentation: fix nuttxgdb related c

Re: [PR] Documentation: fix nuttxgdb related commands [nuttx]

2024-11-25 Thread via GitHub
acassis commented on PR #14937: URL: https://github.com/apache/nuttx/pull/14937#issuecomment-2499096390 Nice work @XuNeo ! Kudos!!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Documentation: fix nuttxgdb related commands [nuttx]

2024-11-25 Thread via GitHub
acassis merged PR #14937: URL: https://github.com/apache/nuttx/pull/14937 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

Re: [PR] Documentation: fix nuttxgdb related commands [nuttx]

2024-11-25 Thread via GitHub
nuttxpr commented on PR #14937: URL: https://github.com/apache/nuttx/pull/14937#issuecomment-2498542421 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does *not* fully meet the NuttX requirement

[PR] Documentation: fix nuttxgdb related commands [nuttx]

2024-11-25 Thread via GitHub
XuNeo opened a new pull request, #14937: URL: https://github.com/apache/nuttx/pull/14937 Now we should load tools/gdb/gdbinit.py script *Note: Please adhere to [Contributing Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).* ## Summary Update docu

Re: [PR] note: Remove enter_critical_section from the sched_note module [nuttx]

2024-11-25 Thread via GitHub
xiaoxiang781216 commented on code in PR #14926: URL: https://github.com/apache/nuttx/pull/14926#discussion_r1856876186 ## drivers/note/noterpmsg_driver.c: ## @@ -49,6 +50,7 @@ struct noterpmsg_driver_s uint8_t buffer[CONFIG_DRIVERS_NOTERPMSG_BUFSIZE]; struct

(nuttx) branch master updated: spinlock: use spin_lock_init replace spin_initialize

2024-11-25 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 34e79f9618 spinlock: use spin_lock_init replac

Re: [PR] spinlock: use spin_lock_init replace spin_initialize [nuttx]

2024-11-25 Thread via GitHub
xiaoxiang781216 merged PR #14931: URL: https://github.com/apache/nuttx/pull/14931 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

[I] [BUG] cmake on macOS is broken [nuttx]

2024-11-25 Thread via GitHub
yamt opened a new issue, #14936: URL: https://github.com/apache/nuttx/issues/14936 ### Description / Steps to reproduce the issue cmake sim build on macOS is broken. it's partly because of https://github.com/apache/nuttx/pull/14852. it doesn't seem like the only issue though.

Re: [I] [BUG] cmake on macOS is broken [nuttx]

2024-11-25 Thread via GitHub
yamt commented on issue #14936: URL: https://github.com/apache/nuttx/issues/14936#issuecomment-2498331079 @cuiziwei1 can you take a look? thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[PR] fs/littlefs: make CONFIG_FS_LITTLEFS_VERSION include the "v" prefix [nuttx]

2024-11-25 Thread via GitHub
yamt opened a new pull request, #14935: URL: https://github.com/apache/nuttx/pull/14935 ## Summary fs/littlefs: make CONFIG_FS_LITTLEFS_VERSION include the "v" prefix To allow other tags/branches like "devel" and even sha256 hash. ## Impact littlefs ## Testing

Re: [PR] [ci] platforms: added toolchains [nuttx]

2024-11-25 Thread via GitHub
simbit18 commented on PR #14934: URL: https://github.com/apache/nuttx/pull/14934#issuecomment-2498301408 however I did not put option -S on github for macOS because it does not have xtensa-0 and xtensa-02 https://github.com/apache/nuttx/blob/e69903c939690b4ce1101dc02ae1cbd9fed4ab32/.

Re: [I] [HELP] ESP32-S3 Don't work ADC [nuttx]

2024-11-25 Thread via GitHub
shizacat commented on issue #14816: URL: https://github.com/apache/nuttx/issues/14816#issuecomment-2498292158 @fdcavalcanti Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

(nuttx) 03/03: tools/gdb: Add a singleton class for macros

2024-11-25 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit e69903c939690b4ce1101dc02ae1cbd9fed4ab32 Author: yinshengkai AuthorDate: Wed Nov 13 12:33:28 2024 +0800 tools/gdb

Re: [PR] [ci] platforms: added toolchains [nuttx]

2024-11-25 Thread via GitHub
lupyuen commented on PR #14934: URL: https://github.com/apache/nuttx/pull/14934#issuecomment-2498272691 Yep that should be helpful for normal builds. For macOS Build Farm: We're replicating the same Build Environment as GitHub Actions, so we'll stick to the current settings. Thanks! -- T

(nuttx) 01/03: tools/gdb: fix checkpatch warning

2024-11-25 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 7aa2dc24cd0a8d54d139430c9e7c2916a477913b Author: yinshengkai AuthorDate: Fri Nov 15 12:30:56 2024 +0800 tools/gdb

(nuttx) branch master updated (24add5eeaf -> e69903c939)

2024-11-25 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 24add5eeaf spelling: fix spelling typo premp -> preemp new 7aa2dc24cd tools/gdb: fix checkpatch warning ne

(nuttx) 02/03: tools/gdb: move the macros cache files to a temporary directory

2024-11-25 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 9eaec7ba49f7d4292df86eefa221c71c4b5a27fe Author: yinshengkai AuthorDate: Wed Nov 13 11:59:22 2024 +0800 tools/gdb

Re: [PR] tools/gdb: Add a singleton class for macros [nuttx]

2024-11-25 Thread via GitHub
xiaoxiang781216 merged PR #14933: URL: https://github.com/apache/nuttx/pull/14933 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] [ci] platforms: added toolchains [nuttx]

2024-11-25 Thread via GitHub
simbit18 commented on PR #14934: URL: https://github.com/apache/nuttx/pull/14934#issuecomment-2498236973 now if you use it it saves you minutes of build time -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] [ci] platforms: added toolchains [nuttx]

2024-11-25 Thread via GitHub
lupyuen commented on PR #14934: URL: https://github.com/apache/nuttx/pull/14934#issuecomment-2498218994 Oops sorry should be this: https://github.com/apache/nuttx/blob/master/.github/workflows/build.yml#L250 ```text macOS: ... cd sources/nuttx/tools/ci ./c

Re: [PR] [ci] platforms: added toolchains [nuttx]

2024-11-25 Thread via GitHub
lupyuen commented on PR #14934: URL: https://github.com/apache/nuttx/pull/14934#issuecomment-2498209719 Hmmm I can't recall why, perhaps because I copied from the GitHub CI Logs for macOS? https://github.com/NuttX/nuttx/actions/runs/12007155773/job/33467286390#step:7:5 ```text cd

Re: [PR] [ci] platforms: added toolchains [nuttx]

2024-11-25 Thread via GitHub
simbit18 commented on PR #14934: URL: https://github.com/apache/nuttx/pull/14934#issuecomment-2498194964 @lupyuen Is there a particular reason why you do not use the -S option? `nuttx/tools/testbuild.sh -A -R -j 12 -e '-Wno-cpp -Werror' testlist/xtensa-02.dat` option -S `nu

Re: [PR] [ci] platforms: added toolchains [nuttx]

2024-11-25 Thread via GitHub
nuttxpr commented on PR #14934: URL: https://github.com/apache/nuttx/pull/14934#issuecomment-2498114501 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR appears to mostly meet the NuttX requirements,

  1   2   >