xiaoxiang781216 commented on code in PR #14901:
URL: https://github.com/apache/nuttx/pull/14901#discussion_r1857893655
##########
fs/littlefs/lfs_vfs.c:
##########
@@ -816,16 +834,31 @@ static int littlefs_fchstat(FAR const struct file *filep,
inode = filep->f_inode;
fs = inode->i_private;
+ path = lib_get_pathbuffer();
+ if (path == NULL)
+ {
+ return -ENOMEM;
+ }
+
/* Call LFS to get file size */
+ ret = littlefs_convert_result(lfs_file_path(&fs->lfs, &priv->file, path,
Review Comment:
> i thought someone (xiaomi?) was relying on the specific version. (2.5.1)
Yes, we depend on a specific version of littlefs. But it isn't a reason to
block the community upgrade to a new version.
> do you mean it should be ok to simply "upgrade" the default to 2.9.x?
Yes, the mainline should track the last version of 3rd project. @crafcat7
please provide a patch to switch LITTLEFS_VERSION to the latest one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
