xiaoxiang781216 commented on PR #14865:
URL: https://github.com/apache/nuttx/pull/14865#issuecomment-2499631737
> I don't see any optimization for the current code in this commit, it's
just an API rename, up_set_current_regs / up_current_regs -
current_regs doesn't save/restore anymore but instead saving the current
task to improve the speed.
> up_interrupt_context / arm_set_irq_flag
many arches provide the fast way to check the interrupt context, which
doesn't depend on current_regs, so it's better to decouple them.
> And the new naming is more difficult to understand than before, For any
operating system, API naming and improvement need to be carefully considered,
because individual developers do not accept disruptive API reforms for each
version,
>
how about arm_set_interrupt_context?
> current_regs has existed in nuttx for many years, if there is no
substantial change, please do not make API changes at will
current_regs still exist, but it can be retrieved from running_task. since
it isn't arch specific API anymore, we have to remove up_ prefix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
