nuttxpr commented on PR #14941: URL: https://github.com/apache/nuttx/pull/14941#issuecomment-2499344385
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides a Signed-off-by line and some testing information, it lacks crucial details. Here's a breakdown of what's missing: * **Insufficient Summary:** "replace all lockcount check to nxsched_islocked_tcb()" is repeated and doesn't explain *why* this change is necessary. What problem does it solve? What are the benefits? What part of the scheduler code is affected? * **Missing Impact Assessment:** "N/A" is not acceptable. Even seemingly small changes can have unintended consequences. The author needs to consider and document the impact on users, the build process, hardware, documentation, security, and compatibility. If there truly is no impact in a particular area, they should explicitly state why. * **Inadequate Testing Information:** "ci-check" is too vague. What specific tests were run? What platforms were they run on (host and target)? The logs before and *after* the change are required to demonstrate the effect of the modification. Just saying "ci-check" doesn't provide any evidence of actual verification. The PR needs to be revised to address these shortcomings before it can be properly reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
