nuttxpr commented on PR #14939: URL: https://github.com/apache/nuttx/pull/14939#issuecomment-2499275574
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides a summary and mentions testing with CI, it lacks crucial details. Here's what's missing: * **Summary:** Lacks specifics on *how* the change works. Removing recursive locks is the *what*, but the *how* (code modifications) is absent. While referencing a similar PR is helpful, the summary should stand alone. * **Impact:** The single word "spinlock" is insufficient. It needs to address *all* the impact points with YES/NO and descriptions for any YES answers. Consider the ripple effects of this change. Will any drivers or subsystems need modification? * **Testing:** CI passing is not enough detail. Provide specific build hosts and targets tested. "Testing logs before change" and "Testing logs after change" sections are empty. Show *what* was tested and the results demonstrating the fix. Ideally, show a test case that failed before and passes after the change. Without these details, reviewers cannot effectively assess the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
