[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

azat updated this revision to Diff 458663. azat added a comment. Adjust comments as suggested by @dblaikie Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133092/new/ https://reviews.llvm.org/D133092 Files: clang/lib/Driver/ToolChains/CommonArgs.c

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

azat marked an inline comment as done. azat added a comment. @dblaikie Rebased. Brief of you comment had been added into the code, and the whole comment included into the commit message. Thanks for taking a look! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[clang] fd24750 - Revert "C++/ObjC++: switch to gnu++17 as the default standard"

Author: Nikita Popov Date: 2022-09-08T09:45:50+02:00 New Revision: fd2475049e882e6c70a745cbe0799749ba184910 URL: https://github.com/llvm/llvm-project/commit/fd2475049e882e6c70a745cbe0799749ba184910 DIFF: https://github.com/llvm/llvm-project/commit/fd2475049e882e6c70a745cbe0799749ba184910.diff

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

nikic added a comment. I've reverted this change because it causes major llvm-test-suite breakage. You likely need to pin many tests to use `-std=c++14`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131465/new/ https://reviews.llvm.org/D131465 _

[clang] 8627179 - [clang][Interp] Only initialize initmaps for primitive arrays

Author: Timm Bäder Date: 2022-09-08T10:03:06+02:00 New Revision: 86271798e51a7866dd2af44e0ee183d1331089e6 URL: https://github.com/llvm/llvm-project/commit/86271798e51a7866dd2af44e0ee183d1331089e6 DIFF: https://github.com/llvm/llvm-project/commit/86271798e51a7866dd2af44e0ee183d1331089e6.diff LO

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

MaskRay added a comment. In D131465#3776515 , @nikic wrote: > I've reverted this change because it causes major llvm-test-suite breakage. > You likely need to pin many tests to use `-std=c++14`. https://github.com/llvm/llvm-test-suite/commit/b3a89445dc4

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

DavidSpickett added a comment. If it helps here is a failed build from our bots: https://lab.llvm.org/buildbot/#/builders/179/builds/4420 There are others but just combinations of the same tests. Example error from the hexxagon build: /home/tcwg-buildbot/worker/clang-armv8-lld-2stage/test/te

[clang] 3e99b8d - C++/ObjC++: switch to gnu++17 as the default standard

Author: Fangrui Song Date: 2022-09-08T08:22:04Z New Revision: 3e99b8d947ac024831e59be2b604ac67a24fed94 URL: https://github.com/llvm/llvm-project/commit/3e99b8d947ac024831e59be2b604ac67a24fed94 DIFF: https://github.com/llvm/llvm-project/commit/3e99b8d947ac024831e59be2b604ac67a24fed94.diff LOG:

[clang] a0365ab - [Driver] Support -gz=zstd

Author: Fangrui Song Date: 2022-09-08T01:39:06-07:00 New Revision: a0365abad8113d7e60294c5e581c24ec06ba037e URL: https://github.com/llvm/llvm-project/commit/a0365abad8113d7e60294c5e581c24ec06ba037e DIFF: https://github.com/llvm/llvm-project/commit/a0365abad8113d7e60294c5e581c24ec06ba037e.diff

[PATCH] D132962: [clangd][ObjC] Improve completions for protocols + category names

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1731 SymbolSlab::Builder ResultsBuilder; -if (Opts.Index->fuzzyFind(Req, [&](const Symbol &Sym) { -

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

nikic added a comment. In D131465#3776537 , @MaskRay wrote: > In D131465#3776515 , @nikic wrote: > >> I've reverted this change because it causes major llvm-test-suite breakage. >> You likely need to pin many tes

[PATCH] D133479: [clangd] Set Incompleteness for spec fuzzyfind requests

kadircet created this revision. kadircet added reviewers: sammccall, dgoldman. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Rep

[PATCH] D113779: [Clang] Add mfp16, mfp16fml and mdotprod flags for ARM target features.

rsandifo-arm added a comment. I can see at least three ways of handling this: 1. @paulwalker-arm's suggestion to allow `-march=` without a base architecture (or with a dummy base architecture that means “no change”) 2. a single new option `-mfoo=` that applies on top of `-march` and can be used

[PATCH] D132003: [clang][ARM][NFC] Clean up signed conversion and undefined macros in builtin header

tmatheson accepted this revision. tmatheson added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132003/new/ https://reviews.llvm.org/D132003

[PATCH] D133109: [LLVM][ARM] Remove options for armv2, 2A, 3 and 3M

This revision was automatically updated to reflect the committed changes. Closed by commit rGe428baf0019e: [LLVM][ARM] Remove options for armv2, 2A, 3 and 3M (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133109/new/ http

[clang] e428baf - [LLVM][ARM] Remove options for armv2, 2A, 3 and 3M

Author: David Spickett Date: 2022-09-08T09:49:48Z New Revision: e428baf0019e5292d943a8e37bf08f1192a1870c URL: https://github.com/llvm/llvm-project/commit/e428baf0019e5292d943a8e37bf08f1192a1870c DIFF: https://github.com/llvm/llvm-project/commit/e428baf0019e5292d943a8e37bf08f1192a1870c.diff LOG

[PATCH] D130265: [clangd] resolve forwarded parameters in Hover

kadircet added a comment. This looks like a nice idea, but i think we definitely need annotations to prevent confusion. I'd prefer something like: assume `foo(int x, Args... args);` function foo -> void Parameters: - int x - int a : forwarded to [bar:a](it'd be great if we could have l

[PATCH] D133440: [clangd] Allow programmatically disabling rename of virtual method hierarchies.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:217 return ReasonToReject::NonIndexable; + if (!Opts.RenameVirtual) { +if (const auto *S

[PATCH] D113779: [Clang] Add mfp16, mfp16fml and mdotprod flags for ARM target features.

DavidSpickett added a comment. For (1) and (2) is there a need to be able to reset the architecture setting no matter the previous `march` and `` are? Currently we're talking about *not* wanting having to use `-march=armv8-a+crc` but would you still want a way to reset the architecture no matte

[PATCH] D133405: [Linux] Hack around Linux/sparc

ro added a comment. In D133405#3776096 , @MaskRay wrote: > It's not a compiler's job to define this workaround... Yes and no: GCC successfully does it via its `fixincludes` mechanism. Unfortunately, LLVM doesn't provide something similar and doesn't ev

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

aaron.ballman added a comment. In D127284#3776036 , @rsmith wrote: > In terms of the high-level direction here, I think it would make sense to > approach this by adding a full-fledged language extension to Clang to allow > statements at the top level (w

[PATCH] D124244: [analyzer] add StoreToImmutable and ModelConstQualifiedReturn checkers

zukatsinadze added a comment. @NoQ gentle ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124244/new/ https://reviews.llvm.org/D124244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

nikic added a comment. In D131465#3776599 , @nikic wrote: > It looks like the switch to `-std=c++17` has some major compile-time impact: > http://llvm-compile-time-tracker.com/compare.php?from=047c7aa96dadf8a2c71a29e2df610d628d9e7e3e&to=3e99b8d947ac02483

[PATCH] D133202: [Clang] Avoid __builtin_assume_aligned crash when the 1st arg is array type

yronglin added a comment. Thanks a lot for your comments @rsmith @rjmccall . Firstly, as far as I know, turning on the `-fsanitizer=alignment` options when calling `__builtin_assume_aligned` in C code, Clang will emit `call void @__ubsan_handle_alignment_assumption(...)` in CodeGen, and CodeGe

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

probinson added a comment. I'm happy if @dblaikie is happy. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:515 +// +// And as @dblaikie noted, this solution is far from perfert, better to +// encode it into IR metadata, but this may not worth it, since looks

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

MyDeveloperDay added a comment. an example of the exact reason why we should not reuse the same struct... https://github.com/llvm/llvm-project/issues/57464 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132131/new/ https://reviews.llvm.org/D13213

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

azat updated this revision to Diff 458717. azat added a comment. Update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133092/new/ https://reviews.llvm.org/D133092 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/Driver/debu

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

probinson added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:515 +// +// But note, this solution is far from perfert, better to encode it into IR +// metadata, but this may not worth it, since looks like aranges on the way T

[PATCH] D133488: [clang][PowerPC][NFC] Add base test case for PPC64 VAArg aggregate smaller than a slot

tingwang created this revision. tingwang added reviewers: uweigand, wschmidt, PowerPC. tingwang added a project: clang. Herald added subscribers: shchenz, kbarton, nemanjai. Herald added a project: All. tingwang requested review of this revision. Herald added a subscriber: cfe-commits. Add base te

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

azat updated this revision to Diff 458723. azat marked an inline comment as done. azat added a comment. Update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133092/new/ https://reviews.llvm.org/D133092 Files: clang/lib/Driver/ToolChains/

[PATCH] D132962: [clangd][ObjC] Improve completions for protocols + category names

dgoldman updated this revision to Diff 458724. dgoldman added a comment. Address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132962/new/ https://reviews.llvm.org/D132962 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-ex

[PATCH] D132962: [clangd][ObjC] Improve completions for protocols + category names

dgoldman marked an inline comment as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1731 SymbolSlab::Builder ResultsBuilder; -if (Opts.Index->fuzzyFind(Req, [&](const Symbol &Sym) { - if (includeSymbolFromIndex(Sym))

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

MyDeveloperDay added a comment. another reason for using a struct, is that we might want to say something like "AlignNamespaceTrainingComments:false" https://github.com/llvm/llvm-project/issues/57504 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D133338: [clang][PowerPC] PPC64 VAArg use coerced integer type for direct aggregate fits in register

tingwang updated this revision to Diff 458721. tingwang added a comment. Update according to comments: (1) The argument type is not touched. (2) Add flag in APIs to force right-adjust the parameter for this issue. (3) One change on if check logic: now use CoerceTy->getIntegerBitWidth() directly c

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

aaronpuchert added a comment. I was under the impression that we've already switched to C++17, but the Windows pre-submit build failed with: C:\ws\w9\llvm-project\premerge-checks\clang\lib\Analysis\ThreadSafety.cpp(2107): error C2429: language feature 'init-statements in if/switch' requires

[PATCH] D133202: [Clang] Avoid __builtin_assume_aligned crash when the 1st arg is array type

yronglin added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:7651-7652 + Expr *FirstArg = TheCall->getArg(0); + if (auto *CE = dyn_cast(FirstArg)) +FirstArg = CE->getSubExprAsWritten(); rjmccall wrote: > rsmith wrote: > > This looks very su

[PATCH] D133338: [clang][PowerPC] PPC64 VAArg use coerced integer type for direct aggregate fits in register

uweigand added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:5471 +if (CoerceTy->isIntegerTy() && CoerceTy->getIntegerBitWidth() < GPRBits) + ForceRightAdjust = true; + } Are all these checks really necessary here? This seems t

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133092/new/ https://reviews.llvm.org/D133092

[PATCH] D133202: [Clang] Avoid __builtin_assume_aligned crash when the 1st arg is array type

yronglin added a comment. Reproduce windows broken test: ignore.cpp #include void *__builtin_assume_aligned(const void *, size_t, ...) noexcept; void foo() { int a; (void) __builtin_assume_aligned(&a, 4); } FunctionDecl 0x14a80e480 <./ignore.cpp:3:1, col:7> col:7 __buil

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

ldionne added a comment. In D126907#3746477 , @Mordante wrote: > Unfortunately there are a lot of different options and combination of options > to test libc++. > So it's indeed not possible to test all options with once check-cxx > invocation. This ^.

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. In D126907#3777088 , @ldionne wrote: > In D126907#3746477 , @Mordante > wrote: > >> Unfortunately there are a lot of different options and combination of >> options to test libc++. >>

[PATCH] D133338: [clang][PowerPC] PPC64 VAArg use coerced integer type for direct aggregate fits in register

tingwang updated this revision to Diff 458735. tingwang added a comment. Update according to comments: Remove all those checks, they are redundant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D18/new/ https://reviews.llvm.org/D18 Files:

[PATCH] D133338: [clang][PowerPC] PPC64 VAArg use coerced integer type for direct aggregate fits in register

tingwang added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:5471 +if (CoerceTy->isIntegerTy() && CoerceTy->getIntegerBitWidth() < GPRBits) + ForceRightAdjust = true; + } uweigand wrote: > Are all these checks really necessary h

[PATCH] D127695: WIP: clang: Implement Template Specialization Resugaring

davrec added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:534-540 + QualType TransformSubstTemplateTypeParmType(TypeLocBuilder &TLB, + SubstTemplateTypeParmTypeLoc TL) { +QualType QT = TL.getType(); +const Sub

[PATCH] D133499: [clang]: Add DeclContext::dumpDecl() in order to conveniently dump an AST from a DeclContext.

tahonermann created this revision. tahonermann added reviewers: erichkeane, aaron.ballman, shafik. Herald added a project: All. tahonermann requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change enables a declaration to be conveniently

[PATCH] D133428: [WebAssembly] Prototype `f32x4.relaxed_dot_bf16x8_add_f32`

This revision was automatically updated to reflect the committed changes. Closed by commit rGac3b8df8f2f4: [WebAssembly] Prototype `f32x4.relaxed_dot_bf16x8_add_f32` (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133428/new/ ht

[clang] ac3b8df - [WebAssembly] Prototype `f32x4.relaxed_dot_bf16x8_add_f32`

Author: Thomas Lively Date: 2022-09-08T08:07:49-07:00 New Revision: ac3b8df8f2f433193827b8c0396ba8d41d1af565 URL: https://github.com/llvm/llvm-project/commit/ac3b8df8f2f433193827b8c0396ba8d41d1af565 DIFF: https://github.com/llvm/llvm-project/commit/ac3b8df8f2f433193827b8c0396ba8d41d1af565.diff

[PATCH] D133500: [clang] Correct handling of lambdas in lambda default arguments in dependent contexts.

tahonermann created this revision. tahonermann added reviewers: erichkeane, aaron.ballman, shafik. Herald added a project: All. tahonermann requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, a lambda expression in a dependent conte

[PATCH] D133499: [clang]: Add DeclContext::dumpDecl() in order to conveniently dump an AST from a DeclContext.

erichkeane added inline comments. Comment at: clang/lib/AST/ASTDumper.cpp:205 + if (const Decl *D = dyn_cast(this)) +D->dump(); +} One thing to note is that the 'else' case here is a little uninformative. See https://clang.llvm.org/doxygen/DeclBase_8cpp_so

[PATCH] D127695: WIP: clang: Implement Template Specialization Resugaring

mizvekov marked 2 inline comments as done. mizvekov added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:534-540 + QualType TransformSubstTemplateTypeParmType(TypeLocBuilder &TLB, + SubstTemplateTypeParmTypeLoc TL) { +

[PATCH] D133500: [clang] Correct handling of lambdas in lambda default arguments in dependent contexts.

erichkeane added a comment. Patch seems sound, just a nit that we don't need a bunch of the asserts here, since the 'get' function already asserts it looks. I'd like others to take a look too, but this looks acceptable to me. Comment at: clang/lib/Sema/SemaTemplateInstantiat

[PATCH] D128113: WIP: Clang: fix AST representation of expanded template arguments.

mizvekov added a comment. @davrec @alexfh I finally managed to have a talk to @rsmith about this. He thinks that, even if we can't come up with a better solution in time, the benefits of this patch justify the costs observed, as those substitution nodes are pretty useless without a way to ind

[PATCH] D133500: [clang] Correct handling of lambdas in lambda default arguments in dependent contexts.

tahonermann added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:2460-2475 -FunctionDecl *OwningFunc = cast(OldParm->getDeclContext()); -if (OwningFunc->isInLocalScopeForInstantiation()) { - // Instantiate default arguments for methods of loc

[clang-tools-extra] e09c750 - [clangd][ObjC] Improve completions for protocols + category names

Author: David Goldman Date: 2022-09-08T11:30:26-04:00 New Revision: e09c75049854fee251e99c4c3c55f3f391f52a10 URL: https://github.com/llvm/llvm-project/commit/e09c75049854fee251e99c4c3c55f3f391f52a10 DIFF: https://github.com/llvm/llvm-project/commit/e09c75049854fee251e99c4c3c55f3f391f52a10.diff

[PATCH] D132962: [clangd][ObjC] Improve completions for protocols + category names

This revision was automatically updated to reflect the committed changes. dgoldman marked an inline comment as done. Closed by commit rGe09c75049854: [clangd][ObjC] Improve completions for protocols + category names (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D133202: [Clang] Avoid __builtin_assume_aligned crash when the 1st arg is array type

yronglin added a comment. Seems that a builtin can't be redeclared which has custom type checking https://github.com/llvm/llvm-project/blob/ec8f2905a33ba970543c8edb4141c47f30d325f7/clang/lib/Basic/Builtins.cpp#L210-L214 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[clang] de0e311 - [SystemZ] Improve handling of vector alignments.

Author: Jonas Paulsson Date: 2022-09-08T17:33:05+02:00 New Revision: de0e3117d40af95993b11d0622f9700415552d48 URL: https://github.com/llvm/llvm-project/commit/de0e3117d40af95993b11d0622f9700415552d48 DIFF: https://github.com/llvm/llvm-project/commit/de0e3117d40af95993b11d0622f9700415552d48.diff

[PATCH] D131158: [SystemZ] Improve handling of vector alignments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGde0e3117d40a: [SystemZ] Improve handling of vector alignments. (authored by jonpa). Herald added a project: clang. Herald added a subscriber: cfe-com

[PATCH] D133479: [clangd] Set Incompleteness for spec fuzzyfind requests

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1716 + Incomplete |= SpecRes.first; + return std::move(SpecRes.second); } Can this be safely moved - looks like it wasn't before? Repository: rG LLVM Github M

[PATCH] D133479: [clangd] Set Incompleteness for spec fuzzyfind requests

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1716 + Incomplete |= SpecRes.first; + return std::move(SpecRes.second); } dgoldman wrote: > Can this be safely moved - looks like it wasn't before? Ah nevermind,

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

yusuke-kadowaki marked 7 inline comments as done. yusuke-kadowaki added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:865 + + * ``TCAS_DontAlign`` (in configuration: ``DontAlign``) +Don't align trailing comments. HazardyKnusperkeks wrot

[clang] 906ea59 - [SystemZ] Fix new test case

Author: Jonas Paulsson Date: 2022-09-08T18:05:17+02:00 New Revision: 906ea59d00f0deb9777aa977fdcb589d4736244c URL: https://github.com/llvm/llvm-project/commit/906ea59d00f0deb9777aa977fdcb589d4736244c DIFF: https://github.com/llvm/llvm-project/commit/906ea59d00f0deb9777aa977fdcb589d4736244c.diff

[PATCH] D128113: WIP: Clang: fix AST representation of expanded template arguments.

davrec added a comment. In D128113#3777353 , @mizvekov wrote: > @davrec @alexfh > > I finally managed to have a talk to @rsmith about this. > > He thinks that, even if we can't come up with a better solution in time, the > benefits of this patch justify

[PATCH] D133339: [clangd] Isolate logic for setting LSPServer options

kadircet updated this revision to Diff 458769. kadircet added a comment. I agree this is creating confusing state for constructors of ClangdLSPServer. It would be interesting to create LSPServer after the initialize request one day. - Make client-capability related options private again. Reposi

[clang] abd2b1a - [clang] Fix a crash in constant evaluation

Author: Kadir Cetinkaya Date: 2022-09-08T18:21:44+02:00 New Revision: abd2b1a9d0421f99d3d132dc99af55ae52f3ac3e URL: https://github.com/llvm/llvm-project/commit/abd2b1a9d0421f99d3d132dc99af55ae52f3ac3e DIFF: https://github.com/llvm/llvm-project/commit/abd2b1a9d0421f99d3d132dc99af55ae52f3ac3e.dif

[PATCH] D133479: [clangd] Set Incompleteness for spec fuzzyfind requests

This revision was automatically updated to reflect the committed changes. Closed by commit rG71c4fb1d6482: [clangd] Set Incompleteness for spec fuzzyfind requests (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D133479?vs=458690&id=458774#toc Repository: rG LLVM Git

[clang-tools-extra] 71c4fb1 - [clangd] Set Incompleteness for spec fuzzyfind requests

Author: Kadir Cetinkaya Date: 2022-09-08T18:34:25+02:00 New Revision: 71c4fb1d6482e9b7e825ad28e0366649301470d3 URL: https://github.com/llvm/llvm-project/commit/71c4fb1d6482e9b7e825ad28e0366649301470d3 DIFF: https://github.com/llvm/llvm-project/commit/71c4fb1d6482e9b7e825ad28e0366649301470d3.dif

Re: [clang] b7a7aee - [clang] Qualify auto in range-based for loops (NFC)

Mixed feelings here - Kazu's made a lot of cleanup/stylistic changes across the LLVM project for a while now, most, at least I think, are quite welcome (things like switching to range-based-for, std algorithms over llvm ones, llvm algorithms over manually written loops, etc). But yeah, there's some

Re: [clang] 0e5813b - [clang][NFC] silences warnings

On Fri, Aug 26, 2022 at 2:10 PM Christopher Di Bella via cfe-commits wrote: > > > Author: Abraham Corea Diaz > Date: 2022-08-26T21:09:39Z > New Revision: 0e5813b88e50576940070003e093d696390a6959 > > URL: > https://github.com/llvm/llvm-project/commit/0e5813b88e50576940070003e093d696390a6959 > DIFF

[PATCH] D133425: Silence -Wctad-maybe-unsupported stemming from system headers

aaron.ballman added a comment. In D133425#3775353 , @ldionne wrote: > Wouldn't re-applying > https://github.com/llvm/llvm-project/commit/fcd549a7d8284a8e7c763fee3da2206acd8cdc4f > (which had been reverted IIUC) be a more precise fix for this problem? We

[PATCH] D133425: Silence -Wctad-maybe-unsupported stemming from system headers

aaron.ballman added a comment. In D133425#3777598 , @aaron.ballman wrote: > In D133425#3775353 , @ldionne wrote: > >> Re-applying `fcd549a7d8284a8e7c763fee3da2206acd8cdc4f` would not require any >> Clang changes

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

aaron.ballman added a comment. In D127284#3776805 , @aaron.ballman wrote: > In D127284#3776036 , @rsmith wrote: > >> In terms of the high-level direction here, I think it would make sense to >> approach this by

[clang-tools-extra] d200db3 - [clang] template / auto deduction deduces common sugar

Author: Matheus Izvekov Date: 2022-09-08T19:17:48+02:00 New Revision: d200db38637884fd0b421802c6094b2a03ceb29e URL: https://github.com/llvm/llvm-project/commit/d200db38637884fd0b421802c6094b2a03ceb29e DIFF: https://github.com/llvm/llvm-project/commit/d200db38637884fd0b421802c6094b2a03ceb29e.dif

[clang] d42122c - [clang] use getCommonSugar in an assortment of places

Author: Matheus Izvekov Date: 2022-09-08T19:17:53+02:00 New Revision: d42122cd5db021e6b14a90a98ad1dd09412efb4c URL: https://github.com/llvm/llvm-project/commit/d42122cd5db021e6b14a90a98ad1dd09412efb4c DIFF: https://github.com/llvm/llvm-project/commit/d42122cd5db021e6b14a90a98ad1dd09412efb4c.dif

[clang] 16e5d6d - [clang] extend getCommonSugaredType to merge sugar nodes

Author: Matheus Izvekov Date: 2022-09-08T19:17:53+02:00 New Revision: 16e5d6d7f98f1119aab3d10ec4f9e59b5aacd359 URL: https://github.com/llvm/llvm-project/commit/16e5d6d7f98f1119aab3d10ec4f9e59b5aacd359 DIFF: https://github.com/llvm/llvm-project/commit/16e5d6d7f98f1119aab3d10ec4f9e59b5aacd359.dif

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGd200db386378: [clang] template / auto deduction deduces common sugar (authored by mizvekov). Changed prior to commit: h

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd42122cd5db0: [clang] use getCommonSugar in an assortment of place

[PATCH] D130308: [clang] extend getCommonSugaredType to merge sugar nodes

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG16e5d6d7f98f: [clang] extend getCommonSugaredType to merge sugar nodes (authored by mizvekov). Changed prior to commit:

[PATCH] D132977: [HLSL] Call global constructors inside entry

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:167-170 +assert(cast(CS->getOperand(0))->getValue() == 65535 && + "HLSL doesn't support setting priority for global ctors."); +assert(isa(CS->getOperand(2)) && + "HLSL

[PATCH] D132997: [clang][Interp] Handle DeclRefExpr of reference types

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a request for a comment in the test, thanks! Comment at: clang/test/AST/Interp/references.cpp:91 + +static_assert(RefToMemberExpr() == 11, "");

[PATCH] D132727: [clang][Interp] Implement array initializers and subscript expressions

MaskRay added a comment. Heads-up: after D132832 and D132727 , clang/test/AST/Interp/arrays.cpp.test has a msan failure. It can be pre-existing or can be newly introduced. There seems another issue about an integer overflow in

[PATCH] D133499: [clang]: Add DeclContext::dumpDecl() in order to conveniently dump an AST from a DeclContext.

aaron.ballman added inline comments. Comment at: clang/lib/AST/ASTDumper.cpp:204 +LLVM_DUMP_METHOD void DeclContext::dumpDecl() const { + if (const Decl *D = dyn_cast(this)) +D->dump(); Comment at: clang/lib/AST/ASTDumper.cpp:205 + if (c

[PATCH] D130308: [clang] extend getCommonSugaredType to merge sugar nodes

tra added a comment. It looks like some of these changes are causing compiler to crash in `clang::ASTContext::getFloatTypeSemantics` during CUDA compilation: https://lab.llvm.org/buildbot/#/builders/55/builds/35047 I'm currently working on narrowing down which commit is the culprit. Here's a sn

[PATCH] D133499: [clang]: Add DeclContext::dumpDecl() in order to conveniently dump an AST from a DeclContext.

erichkeane added inline comments. Comment at: clang/lib/AST/ASTDumper.cpp:205 + if (const Decl *D = dyn_cast(this)) +D->dump(); +} aaron.ballman wrote: > erichkeane wrote: > > One thing to note is that the 'else' case here is a little uninformative. > > Se

[PATCH] D133202: [Clang] Avoid __builtin_assume_aligned crash when the 1st arg is array type

rjmccall added a comment. Please look into the history of that test case to see why we're specifically testing for the ability to redeclare this builtin. We could certainly allow this builtin to be redeclared using the `const void*` type — that doesn't really reflect the generic nature of the b

[PATCH] D132977: [HLSL] Call global constructors inside entry

beanz added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:167-170 +assert(cast(CS->getOperand(0))->getValue() == 65535 && + "HLSL doesn't support setting priority for global ctors."); +assert(isa(CS->getOperand(2)) && + "HLSL doesn't

[PATCH] D132977: [HLSL] Call global constructors inside entry

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:167-170 +assert(cast(CS->getOperand(0))->getValue() == 65535 && + "HLSL doesn't support setting priority for global ctors."); +assert(isa(CS->getOperand(2)) && + "HLSL

[PATCH] D133509: Frontend: Adopt llvm::vfs::OutputBackend in CompilerInstance

steven_wu created this revision. steven_wu added reviewers: sammccall, benlangmuir, raghavmedicherla, kzhuravl, dexonsmith. Herald added a subscriber: ributzka. Herald added a project: All. steven_wu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-c

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

aaron.ballman added a comment. (I didn't have the chance to do a complete review, but I did a partial one and spotted some things) Comment at: clang/lib/Parse/ParseHLSL.cpp:79-80 +ParsedAttributes Attrs(AttrFactory); +MaybeParseCXX11Attributes(Attrs); +MaybeParseMi

[PATCH] D133499: [clang]: Add DeclContext::dumpDecl() in order to conveniently dump an AST from a DeclContext.

aaron.ballman added inline comments. Comment at: clang/lib/AST/ASTDumper.cpp:205 + if (const Decl *D = dyn_cast(this)) +D->dump(); +} erichkeane wrote: > aaron.ballman wrote: > > erichkeane wrote: > > > One thing to note is that the 'else' case here is a lit

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

python3kgae updated this revision to Diff 458807. python3kgae marked 4 inline comments as done. python3kgae added a comment. Use cast to simplify code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129883/new/ https://reviews.llvm.org/D129883 File

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

python3kgae added inline comments. Comment at: clang/lib/Parse/ParseHLSL.cpp:79-80 +ParsedAttributes Attrs(AttrFactory); +MaybeParseCXX11Attributes(Attrs); +MaybeParseMicrosoftAttributes(Attrs); + aaron.ballman wrote: > Just double-checking, but this

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

jcranmer-intel added a comment. Some general comments on the documentation here: One of the lesser-known issues of `-ffast-math` is the fact that it (or `-funsafe-math-optimizations`) causes `crtfastmath.o` to be linked, which adds a static constructor that sets the FTZ/DAZ bits in MXCSR, affec

[PATCH] D95497: Frontend: Respect -working-directory when checking if output files can be written

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. LGTM. I will commit this if no objection. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95497/new/ https://reviews.llvm.org/D95497 _

[PATCH] D130308: [clang] extend getCommonSugaredType to merge sugar nodes

tra added a comment. The culprit appears to be D111509 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130308/new/ https://reviews.llvm.org/D130308 ___ cfe-commits maili

[PATCH] D95497: Frontend: Respect -working-directory when checking if output files can be written

steven_wu requested changes to this revision. steven_wu added a comment. This revision now requires changes to proceed. Actually, we need to fix the case when output is '-'. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95497/new/ https://reviews.llvm.org/D95497 ___

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

beanz added inline comments. Comment at: clang/lib/Parse/ParseHLSL.cpp:79-80 +ParsedAttributes Attrs(AttrFactory); +MaybeParseCXX11Attributes(Attrs); +MaybeParseMicrosoftAttributes(Attrs); + python3kgae wrote: > aaron.ballman wrote: > > Just double-ch

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

tra added a comment. It appears that this change may result in clang crashing (e.g. it broke CUDA compilation: https://lab.llvm.org/buildbot/#/builders/55/builds/35047/steps/3/logs/stdio). Reproducer: class { typedef __complex__ a; operator=(double b){c *= b} a c $bin/clang++ -c

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:863 + Tok.addModifier(HighlightingModifier::Declaration); +if (const auto Func = dyn_cast(Decl)) { + if (Func->isThisDeclarationADefinition()) -

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov added a comment. Thanks for the repro! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

  1   2   >