yronglin added inline comments.
================ Comment at: clang/lib/Sema/SemaChecking.cpp:7651-7652 + Expr *FirstArg = TheCall->getArg(0); + if (auto *CE = dyn_cast<CastExpr>(FirstArg)) + FirstArg = CE->getSubExprAsWritten(); ---------------- rjmccall wrote: > rsmith wrote: > > This looks very suspicious to me: this will remove a cast expression that > > was written in the source code from the AST. That loses source fidelity, > > can give the wrong answer if the cast changed the value (such as a C++ > > derived-to-base conversion to a non-primary base class), and in any case > > this is only done once where there could be multiple explicit casts written > > on an argument to the builtin, so if it's necessary, then it's not being > > done fully. > > > > Can this be removed? > Somehow I missed this in my review. Yes, this line should be unnecessary, > and as you say, it is definitely wrong. CodeGen need real `user-written-type` to generate `__ubsan_handle_alignment_assumption ` 's arg, but not `const void *` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133202/new/ https://reviews.llvm.org/D133202 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
