probinson added a comment.

I'm happy if @dblaikie is happy.



================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:515
+    //
+    // And as @dblaikie noted, this solution is far from perfert, better to
+    // encode it into IR metadata, but this may not worth it, since looks like
----------------
We don't usually cite people by name in code comments.  Credit for the thought 
is clear in the review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133092/new/

https://reviews.llvm.org/D133092

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to