erichkeane added inline comments.
================ Comment at: clang/lib/AST/ASTDumper.cpp:205 + if (const Decl *D = dyn_cast<Decl>(this)) + D->dump(); +} ---------------- One thing to note is that the 'else' case here is a little uninformative. See https://clang.llvm.org/doxygen/DeclBase_8cpp_source.html#l00915 for some similar logic here (though not sure we should be emulating that). More, I wonder if there is SOME message here that should be dumped for 'else'. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133499/new/ https://reviews.llvm.org/D133499 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
