tingwang added inline comments.

================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:5471
+        if (CoerceTy->isIntegerTy() && CoerceTy->getIntegerBitWidth() < 
GPRBits)
+          ForceRightAdjust = true;
+  }
----------------
uweigand wrote:
> Are all these checks really necessary here?  This seems to duplicate the 
> checks that are already in `emitVoidPtrVAArg` ...    Can't we simply always 
> pass `true` for `ForceRightAdjust` on PowerPC?
Ah, yes. All these checks are redundant, and this essentially reverts back to 
before the commit that broke this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133338/new/

https://reviews.llvm.org/D133338

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to