kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, lgtm!
================
Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:217
return ReasonToReject::NonIndexable;
+ if (!Opts.RenameVirtual) {
+ if (const auto *S = llvm::dyn_cast<CXXMethodDecl>(&RenameDecl)) {
----------------
nit: maybe do the check near the top, where the rest of the unsupportedsymbols
are checked (+ it gives us a early bail out and skip a bunch of file/location
conversions).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133440/new/
https://reviews.llvm.org/D133440
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
