[PATCH] D108533: [clang] Move the soname declaration in a variable at the top of the file

sylvestre.ledru created this revision. sylvestre.ledru added reviewers: tstellar, MaskRay. Herald added a subscriber: mgorny. sylvestre.ledru requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, it is a bit buried in the file even if

[PATCH] D108470: [OpenCL] Fix as_type3 invalid store creation

jaykang10 added a comment. If possible, can you add more tests for different types as previous patch please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108470/new/ https://reviews.llvm.org/D108470 __

[PATCH] D108045: [clangd] Fix clangd crash when including a header

kadircet added a comment. Thanks, I can see the problem now (sorry for the late reply, i was on leave last week). It is amazing that this hasn't bitten us yet during code complete flow (it probably did, but clangd would recover after restart so probably people didn't notice). I still don't thi

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth added a comment. thanks for your testing! i will look at the `__unaligned` issue, not sure if clang supports it, its an MSVC extension, is it? Did the transformations produce issues and approximately how much code did you check? I would like to get a better feeling for its quality bef

[PATCH] D107347: [Sema] haveSameParameterTypes - fix repeated isNull() test

RKSimon added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107347/new/ https://reviews.llvm.org/D107347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

svenvh added inline comments. Comment at: clang/lib/Sema/OpenCLBuiltins.td:1121 +let Extension = FuncExtFloatAtomicsFp32GlobalAdd in { +def: + Builtin<"atomic_fetch_" #ModOp, Please try to follow the formatting used in the rest of this file: ``` def

[PATCH] D108464: [clang][CodeGen] Refactor CreateTempAlloca function nest. NFC.

wingo added a subscriber: tlively. wingo added a comment. In D108464#2957276 , @wingo wrote: > So... besides the refactor, this is getting closer to where I'm going in > https://lists.llvm.org/pipermail/cfe-dev/2021-July/068559.html, though still >

[PATCH] D108461: [OpenCL] Supports optional generic address space in C++ for OpenCL 2021

Anastasia added inline comments. Comment at: clang/lib/Headers/opencl-c-base.h:33 // Define feature macros for OpenCL C 2.0 #if (defined(__OPENCL_CPP_VERSION__) || __OPENCL_C_VERSION__ == 200) +#if (__OPENCL_CPP_VERSION__ != 202100) I think we should just check

[PATCH] D108449: [clang][NFC] Tighten up code for GetGlobalVarAddressSpace

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108449/new/ https://reviews.llvm.org/D108449 _

[PATCH] D107553: [C++4OpenCL] Initialize temporaries in the private address space

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107553/new/ https://reviews.llvm.org/D107553 ___ cfe-commits mailing list

[PATCH] D108202: [tsan] Add support for disable_sanitizer_instrumentation attribute

glider updated this revision to Diff 368056. glider marked 5 inline comments as done. glider added a comment. Addressed Marco's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108202/new/ https://reviews.llvm.org/D108202 Files: clang/docs

[PATCH] D108470: [OpenCL] Fix as_type3 invalid store creation

svenvh updated this revision to Diff 368058. svenvh added a comment. Added more tests as requested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108470/new/ https://reviews.llvm.org/D108470 Files: clang/lib/CodeGen/CGExprScalar.cpp clang/test/CodeGenOpenCL/preserve_vec3.cl Index

[PATCH] D108538: [clang-format] break after the closing paren of a TypeScript decoration

krasimir created this revision. krasimir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes up a case that regressed from https://reviews.llvm.org/D105964: in specific contexts, clang-format stopped breaking after the `)` in TypeScr

[clang] 8300d52 - [tsan] Add support for disable_sanitizer_instrumentation attribute

Author: Alexander Potapenko Date: 2021-08-23T12:38:33+02:00 New Revision: 8300d52e8cbf757192d6b66efa537e15376bf756 URL: https://github.com/llvm/llvm-project/commit/8300d52e8cbf757192d6b66efa537e15376bf756 DIFF: https://github.com/llvm/llvm-project/commit/8300d52e8cbf757192d6b66efa537e15376bf756

[PATCH] D108202: [tsan] Add support for disable_sanitizer_instrumentation attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8300d52e8cbf: [tsan] Add support for disable_sanitizer_instrumentation attribute (authored by glider). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D104854: Introduce intrinsic llvm.isnan

thopre added a comment. In D104854#2957735 , @kpn wrote: > In D104854#2957490 , @lebedev.ri > wrote: > >> In D104854#2957471 , @sepavloff >> wrote: >> >>> In D104854#295

[PATCH] D104854: Introduce intrinsic llvm.isnan

lebedev.ri added a subscriber: hans. lebedev.ri added a comment. In D104854#2959680 , @thopre wrote: > In D104854#2957735 , @kpn wrote: > >> In D104854#2957490 , @lebedev.

[PATCH] D108453: [Clang/Test]: Enable enable_noundef_analysis as default(2)

aqjune updated this revision to Diff 368034. aqjune added a comment. Rebase, rename `disable-noundef-args` to `disable-noundef-analysis`, remove redundant diffs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108453/new/ https://reviews.llvm.org/D10

[PATCH] D108453: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default (2)

aqjune added a comment. Hello all, I'm a messenger of @hyeongyukim's two patches that allow clang to turn on noundef analysis by default. The motivation and background of these patches are described at https://reviews.llvm.org/D105169#2959464. Here is a list of tests that has `RUN: %clang_cc1`

[PATCH] D104854: Introduce intrinsic llvm.isnan

sepavloff added a comment. I posted the RFC: https://lists.llvm.org/pipermail/llvm-dev/2021-August/152257.html Depending on the feedback I'll revert the check or modify the implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104854/new/

[PATCH] D108470: [OpenCL] Fix as_type3 invalid store creation

jaykang10 added a comment. Can you also add "double2_to_float3" and "float4_to_float3" tests please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108470/new/ https://reviews.llvm.org/D108470 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D108470: [OpenCL] Fix as_type3 invalid store creation

svenvh added a comment. In D108470#2959708 , @jaykang10 wrote: > Can you also add "double2_to_float3" Instead of `double2_to_float3`, I decided to add `char8_to_short3`. Same idea (vectorN to vector3), but reinterpreting 8 chars as 3 shorts feels like

[PATCH] D108481: Avoid nullptr dereferencing of 'Constraint'

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. Thanks for the cleanup! Btw, it's helpful if you add more context to the patch when generating the diff. I typically use `git diff -U` when generating a diff as that gives plenty of context for the patch review wit

[PATCH] D108540: [clang][deps] Collect precompiled deps from submodules too

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In this patch, the dependency scanner starts collecting precompiled dependencie

[PATCH] D108540: [clang][deps] Collect precompiled deps from submodules too

jansvoboda11 added inline comments. Comment at: clang/test/ClangScanDeps/modules-pch-common-via-submodule.c:85 +// CHECK-TU: "-emit-module" +// CHECK-TU: "-fmodule-file=[[PREFIX]]/build/[[HASH_MOD_COMMON:.*]]/ModCommon-{{.*}}.pcm" +// CHECK-TU:

[PATCH] D108538: [clang-format] break after the closing paren of a TypeScript decoration

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM, Thanks for picking these up Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108538/new/ https://reviews.llvm.org/D108538 __

[PATCH] D108366: [clang][deps] Deduce resource directory from the compiler path

jansvoboda11 added a comment. In D108366#2955322 , @dexonsmith wrote: > The patch seems mostly straightforward, but can you clarify whether there was > a functionality change for clang-scan-deps? My reading of the code suggests > not, because it was us

[PATCH] D108470: [OpenCL] Fix as_type3 invalid store creation

jaykang10 added a comment. In D108470#2959715 , @svenvh wrote: > In D108470#2959708 , @jaykang10 > wrote: > >> Can you also add "double2_to_float3" > > Instead of `double2_to_float3`, I decided to add `char8_to_s

[PATCH] D108544: [clang][deps] Avoid generating arguments for missing module map files

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Only modules that were built from preprocessed sources have `PresumedModuleMapF

[PATCH] D108360: [clang][NFC] Remove dead code

wingo added a subscriber: tlively. wingo added a comment. Thanks for feedback! Following up on general question in D108464 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108360/new/ https://reviews.llvm.org/D108

[PATCH] D108525: Fix documentation and snippets for the handle attributes.

aaron.ballman added a comment. Thank you for fixing up the docs! As long as we're here, I suggested some extra documentation wording to make it clear what the argument is and why it's used. Comment at: clang/include/clang/Basic/AttrDocs.td:5884 the function is assumed to fill

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4724 + zx_status_t zx_socket_create(uint32_t options, + zx_handle_t __attribute__((acquire_handle)) * out0, + zx_handle_t* out1 [[c

[PATCH] D107095: Implement #pragma clang header_unsafe

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107095/new/ https://reviews.llvm.org/D107095

[PATCH] D103807: [clang][deps] Ensure deterministic order of TU '-fmodule-file=' arguments

jansvoboda11 requested review of this revision. jansvoboda11 added a comment. I'm aware of the drawbacks of `std::map`, but I think having the container sorted at all times promotes correctness/determinism which we really care about in this context. Forgetting to call `sort` at all the right pla

[clang] d3d4d98 - [clang][NFC] GetOrCreateLLVMGlobal takes LangAS

Author: Andy Wingo Date: 2021-08-23T14:55:58+02:00 New Revision: d3d4d98576f4f9b21579fa65630f5355dd9d1234 URL: https://github.com/llvm/llvm-project/commit/d3d4d98576f4f9b21579fa65630f5355dd9d1234 DIFF: https://github.com/llvm/llvm-project/commit/d3d4d98576f4f9b21579fa65630f5355dd9d1234.diff LO

[PATCH] D108445: [clang][NFC] GetOrCreateLLVMGlobal takes LangAS

This revision was automatically updated to reflect the committed changes. Closed by commit rGd3d4d98576f4: [clang][NFC] GetOrCreateLLVMGlobal takes LangAS (authored by wingo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108445/new/ https://reviews

[clang] 8da70fe - [clang][NFC] Tighten up code for GetGlobalVarAddressSpace

Author: Andy Wingo Date: 2021-08-23T14:55:58+02:00 New Revision: 8da70fed704c15d9656cbf2df190122acb975921 URL: https://github.com/llvm/llvm-project/commit/8da70fed704c15d9656cbf2df190122acb975921 DIFF: https://github.com/llvm/llvm-project/commit/8da70fed704c15d9656cbf2df190122acb975921.diff LO

[PATCH] D108449: [clang][NFC] Tighten up code for GetGlobalVarAddressSpace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8da70fed704c: [clang][NFC] Tighten up code for GetGlobalVarAddressSpace (authored by wingo). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

erichkeane added a comment. In D108422#2958761 , @lebedev.ri wrote: > This should be autogenerated from the main `X86.td`, otherwise this is, > unfortunately only partially, duplicates that. > E.g. there isn't a single AMD CPU in there. The intent of t

[clang] 4fb0c08 - [clang][CodeGen] GetDefaultAlignTempAlloca uses preferred alignment

Author: Andy Wingo Date: 2021-08-23T14:55:58+02:00 New Revision: 4fb0c083429ad3119096b3fadf01954952b68a25 URL: https://github.com/llvm/llvm-project/commit/4fb0c083429ad3119096b3fadf01954952b68a25 DIFF: https://github.com/llvm/llvm-project/commit/4fb0c083429ad3119096b3fadf01954952b68a25.diff LO

[PATCH] D108450: [clang][CodeGen] GetDefaultAlignTempAlloca uses preferred alignment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4fb0c083429a: [clang][CodeGen] GetDefaultAlignTempAlloca uses preferred alignment (authored by wingo). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D108552: [OpenMP][AMDGCN] Enable complex functions

pdhaliwal created this revision. pdhaliwal added reviewers: JonChesterfield, ronlieb, ye-luo, jdoerfert, yaxunl, scchan, b-sumner. Herald added subscribers: guansong, jvesely. pdhaliwal requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clan

[PATCH] D108370: [clang-tidy] Fix wrong FixIt about union in cppcoreguidelines-pro-type-member-init

Sockke added a comment. Any thoughts? : ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108370/new/ https://reviews.llvm.org/D108370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D108552: [OpenMP][AMDGCN] Enable complex functions

JonChesterfield added a comment. Macros fine by me, haven't found time to look at what is going on with variant Comment at: clang/lib/Headers/openmp_wrappers/complex:20 +#ifdef __NVPTX__ #define __OPENMP_NVPTX__ I don't think this should be necessary - the d

[PATCH] D108470: [OpenCL] Fix as_type3 invalid store creation

svenvh added a comment. >> Instead of `double2_to_float3`, I decided to add `char8_to_short3`. Same >> idea (vectorN to vector3), but reinterpreting 8 chars as 3 shorts feels like >> a more realistic case than reinterpreting 2 doubles as 3 floats. But I'm >> happy to add `double2_to_float3` i

[clang] f3671a6 - [clang-format] break after the closing paren of a TypeScript decoration

Author: Krasimir Georgiev Date: 2021-08-23T15:52:14+02:00 New Revision: f3671a688db2625ef3736ff3603ef7a9fb78610f URL: https://github.com/llvm/llvm-project/commit/f3671a688db2625ef3736ff3603ef7a9fb78610f DIFF: https://github.com/llvm/llvm-project/commit/f3671a688db2625ef3736ff3603ef7a9fb78610f.d

[PATCH] D108538: [clang-format] break after the closing paren of a TypeScript decoration

This revision was automatically updated to reflect the committed changes. Closed by commit rGf3671a688db2: [clang-format] break after the closing paren of a TypeScript decoration (authored by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D108555: [tsan] Make sanitize-thread-disable.c an X86-only test

glider created this revision. glider added a reviewer: melver. Herald added subscribers: pengfei, jfb, kristof.beyls. glider requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Looks like non-x86 bots are unhappy with inclusion of e.g.: clang

[PATCH] D108555: [tsan] Make sanitize-thread-disable.c an X86-only test

glider added a comment. Not really sure what's the best solution here, but I think restricting the test to x86 should help. So far only ARM and PPC bots reported failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108555/new/ https://reviews.l

[PATCH] D108555: [tsan] Make sanitize-thread-disable.c an X86-only test

melver added inline comments. Comment at: clang/test/CodeGen/X86/sanitize-thread-disable.c:22 int instrumented1(int *a, _Atomic int *b) { return *a + atomic_load(b); } I think you do not need to use atomic_load. You can just deref b, and because it's _Atomi

[PATCH] D108555: [tsan] Make sanitize-thread-disable.c an X86-only test

melver added inline comments. Comment at: clang/test/CodeGen/X86/sanitize-thread-disable.c:22 int instrumented1(int *a, _Atomic int *b) { return *a + atomic_load(b); } melver wrote: > I think you do not need to use atomic_load. > > You can just deref b, and

[PATCH] D108380: [openmp][nfc] Refactor GridValues

JonChesterfield added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:551 + llvm::Log2_32(CGF.getTarget().getGridValue().GV_Warp_Size); + unsigned LaneIDMask = ~0 >> (32u - LaneIDBits); auto &RT = static_cast(CGF.CGM.getOpenMPRuntime()); ---

[PATCH] D108555: [tsan] Make sanitize-thread-disable.c an X86-only test

glider updated this revision to Diff 368096. glider added a comment. Removed the header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108555/new/ https://reviews.llvm.org/D108555 Files: clang/test/CodeGen/sanitize-thread-disable.c Index: clang

[PATCH] D108461: [OpenCL] Supports optional generic address space in C++ for OpenCL 2021

Topotuna planned changes to this revision. Topotuna added a comment. `__opencl_c_generic_address_space` should not have been chosen as the first feature to be addressed out of all OpenCL 3.0 optional core features. This is because `__opencl_c_device_enqueue` has a dependency on this feature. I w

[PATCH] D108555: [tsan] Make sanitize-thread-disable.c an X86-only test

glider added inline comments. Comment at: clang/test/CodeGen/X86/sanitize-thread-disable.c:22 int instrumented1(int *a, _Atomic int *b) { return *a + atomic_load(b); } melver wrote: > melver wrote: > > I think you do not need to use atomic_load. > > > > You

[PATCH] D108555: [tsan] Make sanitize-thread-disable.c an X86-only test

melver accepted this revision. melver added a comment. This revision is now accepted and ready to land. LGTM, thanks! Patch title ("...an X86-only test..") also needs adjustment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108555/new/ https://re

[PATCH] D108555: [tsan] Make sanitize-thread-disable.c an X86-only test

glider added a comment. In D108555#2960034 , @melver wrote: > LGTM, thanks! > > Patch title ("...an X86-only test..") also needs adjustment. It's strange that Phab doesn't automatically update the title when I update the commit message. Repository:

[PATCH] D108555: [tsan] Do not include from sanitize-thread-disable.c

melver added a comment. In D108555#2960037 , @glider wrote: > In D108555#2960034 , @melver wrote: > >> LGTM, thanks! >> >> Patch title ("...an X86-only test..") also needs adjustment. > > It's strange that Phab do

[PATCH] D108464: [clang][CodeGen] Refactor CreateTempAlloca function nest. NFC.

wingo updated this revision to Diff 368098. wingo added a comment. Rebase to no longer require Address default constructor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108464/new/ https://reviews.llvm.org/D108464 Files: clang/lib/CodeGen/CGBui

[clang] cdb3916 - [tsan] Do not include from sanitize-thread-disable.c

Author: Alexander Potapenko Date: 2021-08-23T16:21:43+02:00 New Revision: cdb391698bb29fcbb9156604793121fdd73d3a89 URL: https://github.com/llvm/llvm-project/commit/cdb391698bb29fcbb9156604793121fdd73d3a89 DIFF: https://github.com/llvm/llvm-project/commit/cdb391698bb29fcbb9156604793121fdd73d3a89

[PATCH] D108555: [tsan] Do not include from sanitize-thread-disable.c

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcdb391698bb2: [tsan] Do not include from sanitize-thread-disable.c (authored by glider). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D104854: Introduce intrinsic llvm.isnan

kpn added a comment. In D104854#2959680 , @thopre wrote: > In D104854#2957735 , @kpn wrote: > >> In D104854#2957490 , @lebedev.ri >> wrote: >> >>> In D104854#2957471

[PATCH] D108458: [clang][CodeGen] Add default constructor for Address. NFC.

wingo abandoned this revision. wingo added a comment. In D108458#2957789 , @rjmccall wrote: > You can still use a type without a default constructor in a `DenseMap`; you > just have to use `insert` instead of `dict[key] = ...`. Aaaah, thanks for this no

[PATCH] D108380: [openmp][nfc] Refactor GridValues

JonChesterfield updated this revision to Diff 368100. JonChesterfield added a comment. - require unsigned shift Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108380/new/ https://reviews.llvm.org/D108380 Files: clang/include/clang/Basic/TargetInf

[PATCH] D108459: [clang][CodeGen] Rely on implicitly invalid Address. NFC.

wingo abandoned this revision. wingo added a comment. Closing PR as it turns out that I don't need the Address() change for my work; no need to churn here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108459/new/ https://reviews.llvm.org/D108459

[PATCH] D108556: [clangd] Don't highlight ObjC `id` and `instancetype`

dgoldman created this revision. dgoldman added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Even though they're implemented

[PATCH] D104854: Introduce intrinsic llvm.isnan

thopre added a comment. Ah fair enough. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104854/new/ https://reviews.llvm.org/D104854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins

saghir updated this revision to Diff 368109. saghir added a comment. Added some more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107647/new/ https://reviews.llvm.org/D107647 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/C

[clang] c2574e6 - [openmp][nfc] Refactor GridValues

Author: Jon Chesterfield Date: 2021-08-23T16:19:11+01:00 New Revision: c2574e63ff71c1d3caea48cb6200c2422bd8f33d URL: https://github.com/llvm/llvm-project/commit/c2574e63ff71c1d3caea48cb6200c2422bd8f33d DIFF: https://github.com/llvm/llvm-project/commit/c2574e63ff71c1d3caea48cb6200c2422bd8f33d.di

[PATCH] D108380: [openmp][nfc] Refactor GridValues

This revision was automatically updated to reflect the committed changes. Closed by commit rGc2574e63ff71: [openmp][nfc] Refactor GridValues (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108380/new/ https://reviews.llv

[PATCH] D108552: [OpenMP][AMDGCN] Enable complex functions

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Comment at: clang/lib/Headers/openmp_wrappers/complex:20 +#ifdef __NVPTX__ #define __OPENMP_NVPTX__ JonChesterfield wrote: > I don't think this s

[PATCH] D108560: [clang-tidy] Add support for NOLINTBEGIN ... NOLINTEND comments to suppress clang-tidy warnings over multiple lines

salman-javed-nz created this revision. salman-javed-nz added reviewers: alexfh, aaron.ballman, njames93. salman-javed-nz added a project: clang-tools-extra. Herald added subscribers: arphaman, xazax.hun. salman-javed-nz requested review of this revision. Add support for `NOLINTBEGIN` ... `NOLINTEN

[PATCH] D102449: [WIP][Clang][OpenMP] Add the support for compare clause in atomic directive

jdoerfert added a comment. Is this still WIP or should it be reviewed? Needs a proper commit message. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:5797-5800 + // Cannot emit atomic operation. + // TODO: Do we really want to emit a non-atomic operation here? + if (!Res.firs

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

haonanya updated this revision to Diff 368119. haonanya added a comment. Unify formatting and fix some errors on OpenCLBuiltins.td CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106343/new/ https://reviews.llvm.org/D106343 Files: clang/lib/Headers/opencl-c-base.h clang/lib/Headers/o

[PATCH] D103807: [clang][deps] Ensure deterministic order of TU '-fmodule-file=' arguments

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. Another option to be aware of is `MapVector` (https://llvm.org/docs/ProgrammersManual.html#llvm-adt-mapvector-h). Does not sort, but guarantees iteration order. But LGTM anyway. I don

[PATCH] D108544: [clang][deps] Avoid generating arguments for missing module map files

dexonsmith added a comment. Is there a way to test this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108544/new/ https://reviews.llvm.org/D108544 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D108268: [Modules] Change result of reading AST block to llvm::Error instead

dexonsmith added a comment. LGTM once @vsapsai is happy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108268/new/ https://reviews.llvm.org/D108268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D108540: [clang][deps] Collect precompiled deps from submodules too

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/test/ClangScanDeps/modules-pch-common-via-submodule.c:85 +// CHECK-TU: "-emit-module" +// CHECK-TU: "-fmodule-file=

[PATCH] D108533: [clang] Move the soname declaration in a variable at the top of the file

MaskRay added inline comments. Comment at: clang/tools/libclang/CMakeLists.txt:176 # The SOVERSION should be updated only if a change is made to the libclang # ABI, and when it is updated, it should be updated to the current The comment should be lift

[PATCH] D108533: [clang] Move the soname declaration in a variable at the top of the file

sylvestre.ledru updated this revision to Diff 368126. sylvestre.ledru added a comment. Move the comment too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108533/new/ https://reviews.llvm.org/D108533 Files: clang/tools/libclang/CMakeLists.txt I

[PATCH] D108525: Fix documentation and snippets for the handle attributes.

paulherman updated this revision to Diff 368127. paulherman added a comment. Explaining the tag argument. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108525/new/ https://reviews.llvm.org/D108525 Files: clang/include/clang/Basic/AttrDocs.td I

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

a.elovikov marked an inline comment as done. a.elovikov added a comment. Hi guys, do you want me to fix anything else? I think I've addressed what I could. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108151/new/ https://reviews.llvm.org/D108151

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. 2 nits, give Craig a day or two to =1 as well please, particularly since he's the code-owner here. Comment at: clang/lib/Basic/Targets/X86.cpp:1063 +#ifndef NDEBUG +

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

craig.topper accepted this revision. craig.topper added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108151/new/ https://reviews.llvm.org/D108151 ___ cfe-commits mailing list cfe-commits

[clang] 43de869 - Implement #pragma clang restrict_expansion

Author: Chris Bieneman Date: 2021-08-23T09:46:38-07:00 New Revision: 43de869d77f77eedf9f8760f94940a249d2b5a41 URL: https://github.com/llvm/llvm-project/commit/43de869d77f77eedf9f8760f94940a249d2b5a41 DIFF: https://github.com/llvm/llvm-project/commit/43de869d77f77eedf9f8760f94940a249d2b5a41.diff

[PATCH] D107095: Implement #pragma clang restrict_expansion

This revision was automatically updated to reflect the committed changes. Closed by commit rG43de869d77f7: Implement #pragma clang restrict_expansion (authored by beanz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107095/new/ https://reviews.llvm

[PATCH] D108366: [clang][deps] Deduce resource directory from the compiler path

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. In D108366#2959736 , @jansvoboda11 wrote: > For `clang-scan-deps`, this is //almost// NFC. This code kicks in iff > `ResourceDirect

[PATCH] D108544: [clang][deps] Avoid generating arguments for missing module map files

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. In D108544#2960279 , @dexonsmith wrote: > Is there a way to test this? Marking "request changes" for clarity. Since this drops `-f

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

svenvh added a comment. Thanks for the update! I have a comment about indentation, other than that this is looking good to me. Comment at: clang/lib/Sema/OpenCLBuiltins.td:1129 +let Extension = FuncExtFloatAtomicsFp64GlobalAdd in { +def : Builtin<"atomic_fetch_" # Mod

[PATCH] D107769: [OpenCL] Make generic addrspace optional for -fdeclare-opencl-builtins

svenvh updated this revision to Diff 368136. svenvh edited the summary of this revision. svenvh added a comment. I have done an alternative spin of this patch: instead of introducing `RequireDisabledExtension`, simply always make the `private`, `global`, and `local` overloads available. This ma

[PATCH] D108456: [CUDA] Fix static device variables with -fgpu-rdc

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. Please wait for @yaxunl . I believe he mentioned in D85223 that he'll check whether it works on AMD's end. Comment at: clang/lib/CodeGen/

Re: [llvm-dev] Phabricator Creator Pulling the Plug

On Wed, 18 Aug 2021 at 18:17, MyDeveloper Day via llvm-dev < llvm-...@lists.llvm.org> wrote: > But unless I missed this, was there any discussion regarding the recent > "Winding Down" announcement of Phabricator? and what it might mean for us > in LLVM > I think we have our own self-hosted versio

Re: [llvm-dev] Phabricator Creator Pulling the Plug

If phabricator/phorge do turn out to be non-viable in the future, I think we may want to reopen the option of moving to Gerrit for the primary code-review platform. I'll note that the Golang folks are using Gerrit as their review platform, and they have a GitHub bot setup to translate GH pull-requ

[PATCH] D108567: Implement #pragma clang final extension

beanz created this revision. beanz added reviewers: aaron.ballman, rsmith, lgerbarg, pete, lebedev.ri, dexonsmith. beanz requested review of this revision. Herald added a project: clang. This patch adds a new preprocessor extension ``#pragma clang final`` which enables warning on undefinition and

[PATCH] D101960: [openmp] Drop requirement on library path environment variables

jdoerfert added a comment. To summarize the conversation, can we do LD_LIBRARY_PATH overwrites after this patch or not? If so, I feel everyone is in favor, if not, we need a different solution. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101960/

[PATCH] D108464: [clang][CodeGen] Refactor CreateTempAlloca function nest. NFC.

rjmccall added a reviewer: jfb. rjmccall added a comment. + JF, who knows something about Web Assembly, or can at least drag in the right people In D108464#2959591 , @wingo wrote: > In D108464#2957276 , @wingo w

[PATCH] D101960: [openmp] Drop requirement on library path environment variables

lebedev.ri added a comment. In D101960#2960622 , @jdoerfert wrote: > To summarize the conversation, can we do LD_LIBRARY_PATH overwrites after > this patch or not? If so, I feel everyone is in favor, if not, we need a > different solution. +1 Reposit

[PATCH] D101960: [openmp] Drop requirement on library path environment variables

JonChesterfield added a comment. Pasting `env LD_LIBRARY_PATH=` and `env LIBRARY_PATH` into the printed commandline, as opposed to through magic, would solve most of my day to day frustration here. libomp.so and libomptarget.so are in two different directories, LD_LIBRARY_PATH turns out to be c

[PATCH] D101935: [clang] Search runtimes build tree for openmp runtime

JonChesterfield added a comment. At present libomptarget_amdgcn_bc_path and nvptx need to be a path to a file. If we relax that to accept a path to a directory in which the corresponding file is found, then we can use that argument in place of LIBRARY_PATH from the test scripts. That will let t

[PATCH] D108525: Fix documentation and snippets for the handle attributes.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108525/new/ https://reviews.llvm.org/D108525 _

  1   2   >