dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
LGTM.
================
Comment at: clang/test/ClangScanDeps/modules-pch-common-via-submodule.c:85
+// CHECK-TU: "-emit-module"
+// CHECK-TU:
"-fmodule-file=[[PREFIX]]/build/[[HASH_MOD_COMMON:.*]]/ModCommon-{{.*}}.pcm"
+// CHECK-TU: "-fmodules"
----------------
jansvoboda11 wrote:
> Previously, we'd miss this module included from `mod_tu_sub.h`, resulting in
> a compilation error for `ModTU`.
Can you add a comment to the top of the testcase explaining what's interesting
about it? (Something similar to what you have here.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108540/new/
https://reviews.llvm.org/D108540
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
