svenvh added a comment. >> Instead of `double2_to_float3`, I decided to add `char8_to_short3`. Same >> idea (vectorN to vector3), but reinterpreting 8 chars as 3 shorts feels like >> a more realistic case than reinterpreting 2 doubles as 3 floats. But I'm >> happy to add `double2_to_float3` if you think there is a good reason to do >> so. > > I am sorry for asking more tests because I did not add enough tests > previously. > I do not know well how many type conversions with vec3 the recent OpenCL spec > cover but it could be good to add more the tests of the type conversions > which the spec mentions. If you feel the tests you have added are enough for > it, I am ok with it.
You were absolutely right about asking for more tests! I believe we now have much better coverage, let's see if @Anastasia (or any other reviewer) is also fine with the current set. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108470/new/ https://reviews.llvm.org/D108470 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
