jansvoboda11 requested review of this revision. jansvoboda11 added a comment.
I'm aware of the drawbacks of `std::map`, but I think having the container sorted at all times promotes correctness/determinism which we really care about in this context. Forgetting to call `sort` at all the right places is very easy as this patch demonstrates. But if you are strongly opposed to using `std::map` here, I'm okay with using `std::unordered_map` or `llvm::StringMap` and sorting where necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103807/new/ https://reviews.llvm.org/D103807 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
