aaron.ballman added inline comments.
================ Comment at: clang/include/clang/Basic/AttrDocs.td:4724 + zx_status_t zx_socket_create(uint32_t options, + zx_handle_t __attribute__((acquire_handle)) * out0, + zx_handle_t* out1 [[clang::acquire_handle]]); ---------------- paulherman wrote: > Sorry for the drive-by comment, but I believe that the code snippets are out > of date since the addition of the string param. Would you mind clarifying > what the param should do -- is it a project name such as "fuchsia" or is it a > name of the handle such as "my_awesome_pipe"? I'd be happy to take the fix, > but not sure which way to go. I understand it to be the name of the handle, not a project-specific name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70469/new/ https://reviews.llvm.org/D70469 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
