svenvh added a comment. Thanks for the update! I have a comment about indentation, other than that this is looking good to me.
================ Comment at: clang/lib/Sema/OpenCLBuiltins.td:1129 + let Extension = FuncExtFloatAtomicsFp64GlobalAdd in { + def : Builtin<"atomic_fetch_" # ModOp, + [Double, PointerType<VolatileType<AtomicDouble>, GlobalAS>, Double]>; ---------------- Please indent the content inside all `let` blocks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106343/new/ https://reviews.llvm.org/D106343 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits