dexonsmith requested changes to this revision.
dexonsmith added a comment.
This revision now requires changes to proceed.

In D108544#2960279 <https://reviews.llvm.org/D108544#2960279>, @dexonsmith 
wrote:

> Is there a way to test this?

Marking "request changes" for clarity.

Since this drops `-fmodule-map-file=` arguments, I imagine you can add a test 
that demonstrates it. But if that's currently awkward to observe because you 
need another piece to land in a follow-up, I'm fine to delay testing until then.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108544/new/

https://reviews.llvm.org/D108544

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D108544: [... Jan Svoboda via Phabricator via cfe-commits
    • [PATCH] D1085... Duncan P. N. Exon Smith via Phabricator via cfe-commits
    • [PATCH] D1085... Duncan P. N. Exon Smith via Phabricator via cfe-commits
    • [PATCH] D1085... Jan Svoboda via Phabricator via cfe-commits
    • [PATCH] D1085... Duncan P. N. Exon Smith via Phabricator via cfe-commits

Reply via email to