ebevhan added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:89
SymMgr(context, BasicVals, alloc), MemMgr(context, alloc),
-StateMgr(stateMgr), ArrayIndexTy(context.LongLongTy),
+StateMgr(stateMgr), ArrayIndexTy
Author: gbuella
Date: Thu May 24 00:09:08 2018
New Revision: 333160
URL: http://llvm.org/viewvc/llvm-project?rev=333160&view=rev
Log:
[X86] NFC Include immintrin.h in CodeGen tests
Following r333110:
"Move all Intel defined intrinsic includes into immintrin.h"
Modified:
cfe/trunk/test/CodeGe
Quuxplusone added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:12760
// to deduce an implicit return type.
- if (FD->getReturnType()->isRecordType() &&
- (!getLangOpts().CPlusPlus || !FD->isDependentContext()))
+ if (!FD->getReturnType()->isScalarT
jolesiak added a comment.
LGTM, would be nice though if somebody else took a look (@klimek ?).
Repository:
rC Clang
https://reviews.llvm.org/D47095
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
jolesiak added a comment.
Does it look fine now @krasimir ?
Repository:
rC Clang
https://reviews.llvm.org/D47195
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sammccall added inline comments.
Comment at: lib/Index/USRGeneration.cpp:691
+case BuiltinType::ULongAccum:
+ llvm_unreachable("No USR name mangling for fixed point types.");
case BuiltinType::Float16:
leonardchan wrote:
> rsmith wrote:
dcederman updated this revision to Diff 148351.
dcederman added a comment.
Removed the non-existing registers f33, f35, and so on. I also removed the dX
and qX aliases. After trying them they felt more confusing than helpful.
https://reviews.llvm.org/D47137
Files:
lib/Basic/Targets/Sparc.cpp
martong updated this revision to Diff 148352.
martong added a comment.
Moved `using std::get` up, before `testStructuralMatch`.
Repository:
rC Clang
https://reviews.llvm.org/D46867
Files:
unittests/AST/ASTImporterTest.cpp
unittests/AST/CMakeLists.txt
unittests/AST/Language.cpp
unitte
This revision was automatically updated to reflect the committed changes.
Closed by commit rC333166: [ASTImporter] Add unit tests for structural
equivalence (authored by martong, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46867?vs=148352&id=148353#toc
Repository:
rC C
Author: martong
Date: Thu May 24 01:41:07 2018
New Revision: 333166
URL: http://llvm.org/viewvc/llvm-project?rev=333166&view=rev
Log:
[ASTImporter] Add unit tests for structural equivalence
Summary:
This patch add new tests for structural equivalence. For that a new
common header is created which
ilya-biryukov updated this revision to Diff 148355.
ilya-biryukov added a comment.
- Reimplemented LRU cache with shared_ptr and weak_ptr.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47063
Files:
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
clangd/TUScheduler.cpp
clangd
ilya-biryukov added inline comments.
Comment at: clangd/ClangdUnit.h:132
-/// Manages resources, required by clangd. Allows to rebuild file with new
-/// contents, and provides AST and Preamble for it.
-class CppFile {
+/// A helper class that handles building preambles and AST
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47256
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
balazske created this revision.
Herald added subscribers: cfe-commits, martong.
Herald added a reviewer: a.sidorin.
When a CXXRecordDecl under ClassTemplateDecl is imported, check
the templated record decl for similarity instead of the template.
Repository:
rC Clang
https://reviews.llvm.org/D
SjoerdMeijer added a comment.
Just out of curiousity:
- How do you plan to implement this? Are you going to generate from the pragma
some sort of "script" that dictates the transformation order which is going to
be fed to the pass manager?
- About the stacking of pragmas, in your example you ap
ilya-biryukov added a comment.
After an offline chat: we decided to boost sema results that have **any** decls
in the main file. Even though it introduces some unwanted inconsistencies in
some cases (e.g. see the comment), most of us agree that's a very simple
implementation that does boost use
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg
Repository:
rC Clang
https://reviews.llvm.org/D47262
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
Author: hans
Date: Thu May 24 03:49:38 2018
New Revision: 333170
URL: http://llvm.org/viewvc/llvm-project?rev=333170&view=rev
Log:
Fix ASTImporterTest on Windows after r333082
With MS compatibility, Sema adds an implicit definition of type_info,
which was causing the matchers to return 3 instead
martong added a comment.
Looks good to me, but let's wait for Aleksei's approval and comments.
Repository:
rC Clang
https://reviews.llvm.org/D47313
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
This revision was automatically updated to reflect the committed changes.
Closed by commit rC333171: [clang-format] Fix putting ObjC message arguments in
one line for multiline… (authored by jolesiak, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47195?vs=148169&id=148370#t
On Wed, May 23, 2018 at 3:53 PM, Gabor Marton via cfe-commits
wrote:
> Author: martong
> Date: Wed May 23 06:53:36 2018
> New Revision: 333082
>
> URL: http://llvm.org/viewvc/llvm-project?rev=333082&view=rev
> Log:
> Fix duplicate class template definitions problem
>
> Summary:
> We fail to import
Author: jolesiak
Date: Thu May 24 03:50:36 2018
New Revision: 333171
URL: http://llvm.org/viewvc/llvm-project?rev=333171&view=rev
Log:
[clang-format] Fix putting ObjC message arguments in one line for multiline
receiver
Summary:
Reapply reverted changes from D46879.
Currently BreakBeforeParamet
martong added a comment.
> Could you add a test for TSK_Undeclared as well?
TLDR: No, I cannot.
`TSK_Undeclared` is used to indicate that a template specialization was formed
from a template-id but has not yet been declared, defined, or instantiated.
Consequently,
`ClassTemplateSpecializationDe
This revision was automatically updated to reflect the committed changes.
Closed by commit rL333172: [VFS] Implement getRealPath in InMemoryFileSystem.
(authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D47262
Files:
cf
Author: ioeric
Date: Thu May 24 04:17:00 2018
New Revision: 333172
URL: http://llvm.org/viewvc/llvm-project?rev=333172&view=rev
Log:
[VFS] Implement getRealPath in InMemoryFileSystem.
Reviewers: bkramer
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D47262
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rC333172: [VFS] Implement getRealPath in InMemoryFileSystem.
(authored by ioeric, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47262?vs=148220&id=148376#toc
Repository:
rC Clang
This revision was automatically updated to reflect the committed changes.
Closed by commit rL333174: [clangd] Fix code completion in MACROs with
stringification. (authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D47256
F
Author: ioeric
Date: Thu May 24 04:20:19 2018
New Revision: 333174
URL: http://llvm.org/viewvc/llvm-project?rev=333174&view=rev
Log:
[clangd] Fix code completion in MACROs with stringification.
Summary:
Currently, we only handle the first callback from sema code completion
and ignore results from
Thanks a lot!
Gabor
On Thu, May 24, 2018 at 12:54 PM Hans Wennborg wrote:
> On Wed, May 23, 2018 at 3:53 PM, Gabor Marton via cfe-commits
> wrote:
> > Author: martong
> > Date: Wed May 23 06:53:36 2018
> > New Revision: 333082
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=333082&view=re
ilya-biryukov updated this revision to Diff 148381.
ilya-biryukov added a comment.
- Simplify the change by boosting any Decls that have a redecl in the current
file
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46943
Files:
clangd/Quality.cpp
clangd/Quality.h
unittests
Author: dcederman
Date: Wed May 23 23:16:02 2018
New Revision: 333157
URL: http://llvm.org/viewvc/llvm-project?rev=333157&view=rev
Log:
[Sparc] Use the leon arch for Leon3's when using an external assembler
Summary: This allows the use of the casa instruction available in most Leon3's.
Reviewer
This revision was automatically updated to reflect the committed changes.
Closed by commit rC333179: [analyzer] Move RangeSet related declarations into
the RangedConstraintManager… (authored by mramalho, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D45920
Files:
lib/StaticA
ilya-biryukov added a comment.
> But I feel it's a bit odd that completion and workspace symbols would be
> inconsistent.
It does not seem that odd to me. Completion is something that should follow the
language rules more closely, i.e. we don't want to deviate from sema
completions too much. W
dmgreen created this revision.
Herald added a subscriber: zzheng.
Split out from https://reviews.llvm.org/D47267 when we need it.
https://reviews.llvm.org/D47320
Files:
include/clang/Basic/DiagnosticParseKinds.td
lib/Parse/ParsePragma.cpp
lib/Sema/SemaStmtAttr.cpp
test/CodeGenCXX/pragma
avt77 updated this revision to Diff 148395.
avt77 added a comment.
The sources were re-based to fit in LLVM_DEBUG rename.
One more counter was added.
Debug logging was improved again.
https://reviews.llvm.org/D47196
Files:
include/clang/Frontend/Utils.h
lib/CodeGen/BackendUtil.cpp
lib/Cod
dmgreen updated this revision to Diff 148393.
dmgreen added a comment.
This splits out the pragma clang loop unroll_and_jam handling into
https://reviews.llvm.org/D47320, for if/when we need it. Which I believe is
what you wanted, correct me if I'm wrong.
https://reviews.llvm.org/D47267
Files
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/CodeCompletionStrings.h:46
const CodeCompleteConsumer::OverloadCandidate &Result,
- unsigned ArgInd
ioeric added a comment.
Would it be possible to add some integration tests for file index plus preamble?
Comment at: clangd/index/FileIndex.cpp:37
+ std::vector TopLevelDecls(
+ AST.getTranslationUnitDecl()->decls().begin(),
+ AST.getTranslationUnitDecl()->decls().en
ilya-biryukov added a comment.
I have only a few nits left, otherwise looks good. Thanks for making this
change! Really excited for it to get in finally!
Comment at: include/clang/Driver/CC1Options.td:449
+def code_completion_with_fixits : Flag<["-"], "code-completion-with-fix
Author: ioeric
Date: Thu May 24 06:52:48 2018
New Revision: 333186
URL: http://llvm.org/viewvc/llvm-project?rev=333186&view=rev
Log:
Disable an in-memory vfs file path test on windows.
The test uses unix paths and doesn't make sense to run on windows.
Fix bot failure caused by r333172:
http://l
ilya-biryukov added a comment.
In https://reviews.llvm.org/D47272#1110958, @ioeric wrote:
> Would it be possible to add some integration tests for file index plus
> preamble?
Sure, will do
Comment at: clangd/index/FileIndex.cpp:37
+ std::vector TopLevelDecls(
+ AST.ge
Hi Marshall,
ARM and AArch64 libcxx buildbots are broken since that commits, logs
are available at:
http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-armv7-linux/builds/107/steps/test.libcxx/logs/FAIL%3A%20libc%2B%2B%3A%3Adeduct.pass.cpp
Thanks
Yvan
On 18 May 2018 at 23:05, Marshall
ioeric added inline comments.
Comment at: clangd/index/FileIndex.cpp:37
+ std::vector TopLevelDecls(
+ AST.getTranslationUnitDecl()->decls().begin(),
+ AST.getTranslationUnitDecl()->decls().end());
ilya-biryukov wrote:
> ioeric wrote:
> > Would this gi
Author: ioeric
Date: Thu May 24 07:40:24 2018
New Revision: 333188
URL: http://llvm.org/viewvc/llvm-project?rev=333188&view=rev
Log:
[clangd] Skip .inc headers when canonicalizing header #include.
Summary:
This assumes that .inc files are supposed to be included via headers
that include them.
Re
This revision was automatically updated to reflect the committed changes.
Closed by commit rL333188: [clangd] Skip .inc headers when canonicalizing
header #include. (authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D47187
ilya-biryukov updated this revision to Diff 148413.
ilya-biryukov marked an inline comment as done.
ilya-biryukov added a comment.
- Invert flag, remove the default.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47274
Files:
clangd/CodeComplete.cpp
clangd/CodeCompletionStr
ilya-biryukov added inline comments.
Comment at: clangd/CodeCompletionStrings.h:46
const CodeCompleteConsumer::OverloadCandidate &Result,
- unsigned ArgIndex);
+ unsigned ArgIndex, bool NoCommentsFromHeaders = tr
gramanas updated this revision to Diff 148414.
gramanas added a comment.
Adress review comments.
Limit changes to the storeInst
Repository:
rC Clang
https://reviews.llvm.org/D47097
Files:
lib/CodeGen/CGDecl.cpp
test/CodeGen/debug-info-preserve-scope.c
Index: test/CodeGen/debug-info-pre
Author: ibiryukov
Date: Thu May 24 07:49:23 2018
New Revision: 333189
URL: http://llvm.org/viewvc/llvm-project?rev=333189&view=rev
Log:
[clangd] Serve comments for headers decls from dynamic index only
Summary:
To fix a crash in code completion that occurrs when reading doc
comments from files th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL333189: [clangd] Serve comments for headers decls from
dynamic index only (authored by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D
sammccall added a comment.
Thanks, this looks a lot better!
There do seem to be a lot of little classes that exist exactly one-per-TU
(ASTWorker, ASTBuilder, CachedAST, to a lesser extent ParsedAST) and I'm not
sure the balance of responsibilities is quite right. Some comments below.
Author: mramalho
Date: Thu May 24 05:16:35 2018
New Revision: 333179
URL: http://llvm.org/viewvc/llvm-project?rev=333179&view=rev
Log:
[analyzer] Move RangeSet related declarations into the RangedConstraintManager
header.
Summary: I could also move `RangedConstraintManager.h` under `include/` if
tzik updated this revision to Diff 148417.
tzik added a comment.
Add AST test. computeNRVO unconditionally.
Repository:
rC Clang
https://reviews.llvm.org/D47067
Files:
include/clang/AST/Decl.h
include/clang/Sema/Scope.h
lib/Sema/Scope.cpp
lib/Sema/SemaDecl.cpp
lib/Sema/SemaExpr.cpp
tzik added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:12760
// to deduce an implicit return type.
- if (FD->getReturnType()->isRecordType() &&
- (!getLangOpts().CPlusPlus || !FD->isDependentContext()))
+ if (!FD->getReturnType()->isScalarType())
ilya-biryukov added a comment.
Added the test.
Comment at: clangd/index/FileIndex.cpp:37
+ std::vector TopLevelDecls(
+ AST.getTranslationUnitDecl()->decls().begin(),
+ AST.getTranslationUnitDecl()->decls().end());
ioeric wrote:
> ilya-biryukov wrote
ilya-biryukov updated this revision to Diff 148421.
ilya-biryukov added a comment.
- Added a test for preamble rebuilds.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47272
Files:
clangd/ClangdServer.cpp
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
clangd/TUScheduler.cpp
probinson added a comment.
Can we step back a second and better explain what the problem is? With current
Clang the debug info for this function looks okay to me.
The store that is "missing" a debug location is homing the formal parameter to
its local stack location; this is part of prolog setu
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lg. Thanks for adding the test!
Comment at: clangd/index/FileIndex.cpp:37
+ std::vector TopLevelDecls(
+ AST.getTranslationUnitDecl()->decls().begin(),
+ AST.getTr
Author: ibiryukov
Date: Thu May 24 08:50:15 2018
New Revision: 333196
URL: http://llvm.org/viewvc/llvm-project?rev=333196&view=rev
Log:
[clangd] Build index on preamble changes instead of the AST changes
Summary:
This is more efficient and avoids data races when reading files that
come from the p
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE333196: [clangd] Build index on preamble changes instead
of the AST changes (authored by ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47272?vs=148421&id=148424#toc
Re
malaperle added subscribers: ioeric, sammccall, malaperle.
malaperle added a comment.
I think this might have broken the "shared lib" build? Could you double check
that you don't need to add "clangDriver" ?
../tools/clang/tools/extra/clangd/index/CanonicalIncludes.cpp:61: error:
undefined refer
Author: ioeric
Date: Thu May 24 08:54:32 2018
New Revision: 333197
URL: http://llvm.org/viewvc/llvm-project?rev=333197&view=rev
Log:
[clangd] Add clangDriver dependency after r333188
Modified:
clang-tools-extra/trunk/clangd/CMakeLists.txt
Modified: clang-tools-extra/trunk/clangd/CMakeLists.t
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Nice, simple and will admit refinements later.
Just test nits and a trivial organizational thing.
Comment at: clangd/Quality.cpp:22
+namespace {
+bool hasDeclInMainF
ilya-biryukov created this revision.
ilya-biryukov added reviewers: ioeric, sammccall.
Herald added subscribers: jkorous, MaskRay, mehdi_amini, klimek.
They cause lots of deserialization and are not actually used.
The ParsedAST accessor that previously returned those was renamed from
getTopLevelDe
Author: benlangmuir
Date: Thu May 24 09:25:40 2018
New Revision: 333202
URL: http://llvm.org/viewvc/llvm-project?rev=333202&view=rev
Log:
[bash-completion] Fix tab separation on macOS
We have a regex that needs to match a tab character in the command
output, but on macOS sed doesn't support '\t',
benlangmuir closed this revision.
benlangmuir added a comment.
r333202
https://reviews.llvm.org/D47273
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
gramanas added a comment.
In https://reviews.llvm.org/D47097#149, @probinson wrote:
> Can we step back a second and better explain what the problem is? With
> current Clang the debug info for this function looks okay to me.
> The store that is "missing" a debug location is homing the formal
ahatanak added inline comments.
Comment at: test/SemaObjC/format-size-spec-nsinteger.m:18
+ NSUInteger j = 0;
+ NSLog(@"max NSInteger = %zi", i); // CHECK: values of type 'NSInteger'
should not be used as format arguments; add an explicit cast to 'long' instead
+ NSLog(@"max
Meinersbur added a comment.
Yes, this is what I had in mind. Thank you.
I am preparing an RFC on what I am trying to do. This should clarify our goals
and to what extend `#pragma clang loop` conflicts with it.
https://reviews.llvm.org/D47267
___
c
aprantl added a comment.
In https://reviews.llvm.org/D47097#223, @gramanas wrote:
> In https://reviews.llvm.org/D47097#149, @probinson wrote:
>
> > Can we step back a second and better explain what the problem is? With
> > current Clang the debug info for this function looks okay to me.
Author: ctopper
Date: Thu May 24 10:32:49 2018
New Revision: 333211
URL: http://llvm.org/viewvc/llvm-project?rev=333211&view=rev
Log:
[X86] Fix a bad cast in _mm512_mask_abs_epi32 and _mm512_maskz_abs_epi32.
Modified:
cfe/trunk/lib/Headers/avx512fintrin.h
Modified: cfe/trunk/lib/Headers/avx5
a.sidorin accepted this revision.
a.sidorin added a comment.
This revision is now accepted and ready to land.
Ok, I got it, thank you!
Repository:
rC Clang
https://reviews.llvm.org/D47058
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
probinson added a comment.
I see that the per-file info does track the presence of `# [line] N` but it's
not immediately obvious how to query "has any file seen one" which is really
what I'd want to know. The file information has various levels of
indirection...
Repository:
rC Clang
https
leonardchan updated this revision to Diff 148445.
leonardchan added a comment.
- Reverted changes involving name mangling since we will only support c++ for
now. Will concurrently raise an issue on
https://github.com/itanium-cxx-abi/cxx-abi/ to get characters for name mangling.
- Added a flag th
leonardchan marked 6 inline comments as done.
leonardchan added inline comments.
Comment at: lib/CodeGen/ItaniumCXXABI.cpp:2684
// Types added here must also be added to EmitFundamentalRTTIDescriptors.
switch (Ty->getKind()) {
rsmith wrote:
> Note this co
a.sidorin added a comment.
Hm. Should we test `-fms-compatibility` in addition to
`-fdelayed-template-parsing`?
Repository:
rC Clang
https://reviews.llvm.org/D46950
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
leonardchan updated this revision to Diff 148452.
Repository:
rC Clang
https://reviews.llvm.org/D46084
Files:
include/clang-c/Index.h
include/clang/AST/ASTContext.h
include/clang/AST/BuiltinTypes.def
include/clang/Basic/DiagnosticCommonKinds.td
include/clang/Basic/LangOptions.def
i
jfb added a comment.
Can you also add a test for `_Bool _Accum`.
Also, `-enable-fixed-point -x c++` failing.
Comment at: lib/AST/ExprConstant.cpp:7361
+case BuiltinType::ULongAccum:
+ // GCC does not cover FIXED_POINT_TYPE in it's switch stmt and defaults
to
+ /
vsk added a comment.
In https://reviews.llvm.org/D47097#248, @aprantl wrote:
> In https://reviews.llvm.org/D47097#223, @gramanas wrote:
>
> > In https://reviews.llvm.org/D47097#149, @probinson wrote:
> >
> > > Can we step back a second and better explain what the problem is? With
> >
xbolva00 created this revision.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ioeric, ilya-biryukov.
ClangDiagnosticsEmitter.cpp:1047:57: warning: this statement may fall through
[-Wimplicit-fallthrough=]
Builder.PrintFatalError("Unknown modifier type: " + Modifier);
vsapsai created this revision.
vsapsai added reviewers: arphaman, majnemer.
NumTypos guard value ~0U doesn't prevent from creating new delayed
typos. When you create new delayed typos during typo correction, value
~0U wraps around to 0. This state is inconsistent and depending on total
number of t
xbolva00 added inline comments.
Comment at: lib/CodeGen/CGObjCGNU.cpp:512
/// used to return an untyped selector (with the types field set to NULL).
- llvm::Value *GetSelector(CodeGenFunction &CGF, Selector Sel,
+ virtual llvm::Value *GetSelector(CodeGenFunction &CGF, Select
Quuxplusone added a comment.
> Sounds good to me. I don't have commit privs so could you land it for me?
@EricWF ping!
Repository:
rCXX libc++
https://reviews.llvm.org/D47109
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
jfb added a comment.
Addressed nit.
Repository:
rC Clang
https://reviews.llvm.org/D47229
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jfb updated this revision to Diff 148458.
jfb marked an inline comment as done.
jfb added a comment.
- Address nit.
Repository:
rC Clang
https://reviews.llvm.org/D47229
Files:
lib/Sema/SemaChecking.cpp
test/Sema/atomic-ops.c
Index: test/Sema/atomic-ops.c
rsmith added a comment.
Some minor nits. I would also like to see a test for the unoptimized (-O0) IR
generated by Clang for the case where there are two NRVO variables in the same
function. Otherwise, this looks good to go!
Comment at: lib/Sema/Scope.cpp:122-123
+void Scope:
rkirsling added a comment.
@klimek In our IRC discussion yesterday, I know you expressed disapproval of
WebKit's choice, but given its reality, am I correct in concluding that this
can be landed?
Repository:
rC Clang
https://reviews.llvm.org/D46024
___
vsapsai added inline comments.
Comment at: include/clang/Basic/DiagnosticGroups.td:34-35
def AutoImport : DiagGroup<"auto-import">;
def FrameworkHdrQuotedInclude :
DiagGroup<"quoted-include-in-framework-header">;
+def FrameworkIncludePrivateFromPublic :
DiagGroup<"framework-i
craig.topper added a comment.
LGTM, if you fix the ordering in cpuid.h.
https://reviews.llvm.org/D47142
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rsmith
Date: Thu May 24 13:03:51 2018
New Revision: 333220
URL: http://llvm.org/viewvc/llvm-project?rev=333220&view=rev
Log:
Improve diagnostics for config mismatches with -fmodule-file.
Unless the user uses -Wno-module-file-config-mismatch (or -Wno-error=...),
allow the AST reader to pro
jfb updated this revision to Diff 148467.
jfb marked an inline comment as done.
jfb added a comment.
- Merge format-size-spec-nsinteger
Repository:
rC Clang
https://reviews.llvm.org/D47290
Files:
include/clang/Analysis/Analyses/FormatString.h
include/clang/Basic/DiagnosticSemaKinds.td
jfb marked an inline comment as done.
jfb added inline comments.
Comment at: test/SemaObjC/format-size-spec-nsinteger.m:18
+ NSUInteger j = 0;
+ NSLog(@"max NSInteger = %zi", i); // CHECK: values of type 'NSInteger'
should not be used as format arguments; add an explicit cast
Quuxplusone created this revision.
Quuxplusone added a reviewer: EricWF.
Herald added subscribers: cfe-commits, JDevlieghere.
https://github.com/cplusplus/draft/commit/6216651aada9bc2f9cefe90edbde4ea9e32251ab
`new_delete_resource().allocate(n, a)` has basically three permissible results:
- Retur
leonardchan updated this revision to Diff 148481.
leonardchan marked 2 inline comments as done.
leonardchan added a comment.
- Added test case for `_Bool _Accum`
- Getters for the `_Accum` bit widths return values for their corresponding
integral types (ie. `sizeof(short _Accum) == sizeof(short)`
leonardchan added a comment.
In https://reviews.llvm.org/D46084#374, @jfb wrote:
> Can you also add a test for `_Bool _Accum`.
>
> Also, `-enable-fixed-point -x c++` failing.
.
Done. Also the failing c++ case is under `test/Frontend/fixed_point_errors.cpp`
Repository:
rC Clang
https://
Author: rsmith
Date: Thu May 24 14:51:52 2018
New Revision: 333233
URL: http://llvm.org/viewvc/llvm-project?rev=333233&view=rev
Log:
Switch a couple of users of LangOpts::GNUMode to the more appropriate
LangOpts::GNUKeywords.
Modified:
cfe/trunk/lib/Sema/SemaCodeComplete.cpp
cfe/trunk/li
ebevhan added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:382
+// enough bits to fit the minumum.
+if (getIntWidth() < MinSignedAccumDataBits)
+ return getLongWidth();
I'm not sure I agree with this interpretation. It's simply not c
Author: rsmith
Date: Thu May 24 15:02:52 2018
New Revision: 333234
URL: http://llvm.org/viewvc/llvm-project?rev=333234&view=rev
Log:
Improve diagonstic for braced-init-list as operand to ?: expression.
Modified:
cfe/trunk/lib/Parse/ParseExpr.cpp
cfe/trunk/test/Parser/cxx11-brace-initializ
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Either the previous version of this patch or a version with a `bool` factored
out seem OK to me.
Comment at: lib/Sema/SemaChecking.cpp:3497
+else if (Form == Copy ||
vsapsai added inline comments.
Comment at: lib/Frontend/DependencyFile.cpp:182-185
for (const auto &ExtraDep : Opts.ExtraDeps) {
AddFilename(ExtraDep);
+ ++InputFileIndex;
}
This is incorrect if there are duplicates in `Opts.ExtraDeps`. Also
1 - 100 of 135 matches
Mail list logo
