malaperle added subscribers: ioeric, sammccall, malaperle. malaperle added a comment.
I think this might have broken the "shared lib" build? Could you double check that you don't need to add "clangDriver" ? ../tools/clang/tools/extra/clangd/index/CanonicalIncludes.cpp:61: error: undefined reference to 'clang::driver::types::lookupTypeForExtension(llvm::StringRef)' ../tools/clang/tools/extra/clangd/index/CanonicalIncludes.cpp:63: error: undefined reference to 'clang::driver::types::onlyPrecompileType(clang::driver::types::ID)' Thanks! ________________________________ From: cfe-commits <cfe-commits-boun...@lists.llvm.org> on behalf of Eric Liu via Phabricator via cfe-commits <cfe-commits@lists.llvm.org> Sent: Thursday, May 24, 2018 10:44:26 AM To: ioe...@google.com; sammcc...@google.com Cc: mask...@google.com; llvm-comm...@lists.llvm.org; cfe-commits@lists.llvm.org Subject: [PATCH] https://reviews.llvm.org/D47187: [clangd] Skip .inc headers when canonicalizing header #include. This revision was automatically updated to reflect the committed changes. Closed by commit https://reviews.llvm.org/rL333188: [clangd] Skip .inc headers when canonicalizing header #include. (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D47187 Files: clang-tools-extra/trunk/clangd/index/CanonicalIncludes.cpp clang-tools-extra/trunk/clangd/index/CanonicalIncludes.h clang-tools-extra/trunk/clangd/index/SymbolCollector.cpp clang-tools-extra/trunk/unittests/clangd/SymbolCollectorTests.cpp Repository: rL LLVM https://reviews.llvm.org/D47187 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
