ilya-biryukov added inline comments.
================
Comment at: clangd/CodeCompletionStrings.h:46
const CodeCompleteConsumer::OverloadCandidate &Result,
- unsigned ArgIndex);
+ unsigned ArgIndex, bool NoCommentsFromHeaders = true);
----------------
sammccall wrote:
> this invites double negation.
> Also it doesn't seem like a great default, violates principle of least
> surprise.
>
> prefer bool CommentsFromHeaders = true, or with no default.
> (or even consider an enum)
Thanks for spotting this!
I opted for a positive bool flag with no defaults.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47274
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
