Author: rsmith
Date: Tue Oct 27 02:25:29 2015
New Revision: 251391
URL: http://llvm.org/viewvc/llvm-project?rev=251391&view=rev
Log:
Work around incomplete list initialization support in older MSVC.
Modified:
cfe/trunk/include/clang/AST/ExprCXX.h
cfe/trunk/include/clang/AST/StmtCXX.h
Mod
Author: mkuper
Date: Tue Oct 27 02:46:22 2015
New Revision: 251396
URL: http://llvm.org/viewvc/llvm-project?rev=251396&view=rev
Log:
Access the right triple field for IAMCU.
Modified:
cfe/trunk/lib/CodeGen/TargetInfo.cpp
Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp
URL:
http://llvm.org/vi
Author: rsmith
Date: Tue Oct 27 02:47:45 2015
New Revision: 251397
URL: http://llvm.org/viewvc/llvm-project?rev=251397&view=rev
Log:
Properly clear current coroutine promise on FunctionScopeInfo reuse. Should
hopefully make bots happy again.
Modified:
cfe/trunk/lib/Sema/ScopeInfo.cpp
Modifie
xazax.hun added a subscriber: xazax.hun.
xazax.hun added a comment.
There is already a similar check in the Google package. What are the
differences between those two checks? What is the reason we can not just
register that check into the core guidelines module?
http://reviews.llvm.org/D14096
mprobst added a comment.
Nice, great to see this.
Comment at: lib/Format/ContinuationIndenter.cpp:330
@@ -329,3 +329,3 @@
- if (Style.AlignAfterOpenBracket && Previous.opensScope() &&
- Previous.isNot(TT_ObjCMethodExpr) &&
+ if (Style.AlignAfterOpenBracket == FormatStyl
djasper updated this revision to Diff 38518.
djasper marked 5 inline comments as done.
djasper added a comment.
Addressed review comments.
http://reviews.llvm.org/D14104
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/ContinuationIndenter.cpp
lib/Format/
djasper added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:882
@@ -876,1 +881,3 @@
State.Stack.back().NestedBlockIndent);
+ bool NoLineBreak = State.Stack.back().NoLineBreak ||
+ (Current.is(TT_Templ
klimek added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:334
@@ +333,3 @@
+ if (Style.AlignAfterOpenBracket == FormatStyle::BAS_AlwaysBreak &&
+ Previous.is(tok::l_paren) && State.Column > getNewLineColumn(State) &&
+ (!Previous.Previous ||
djasper added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:334
@@ +333,3 @@
+ if (Style.AlignAfterOpenBracket == FormatStyle::BAS_AlwaysBreak &&
+ Previous.is(tok::l_paren) && State.Column > getNewLineColumn(State) &&
+ (!Previous.Previous ||
---
Building latest HEAD using:
cmake -G Ninja -DCMAKE_BUILD_TYPE=RelWithDebInfo
-DLLVM_USE_CRT_RELWITHDEBINFO=MT -DLLVM_BUILD_TOOLS=OFF
-DLLVM_INCLUDE_EXAMPLES=OFF -DLLVM_ENABLE_ASSERTIONS=OFF
LLVM_BUILD_32_BITS=ON ..\llvm
VC++ version: Microsoft (R) C/C++ Optimizing Compiler Version 19.00.23026
fo
klimek added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:334
@@ +333,3 @@
+ if (Style.AlignAfterOpenBracket == FormatStyle::BAS_AlwaysBreak &&
+ Previous.is(tok::l_paren) && State.Column > getNewLineColumn(State) &&
+ (!Previous.Previous ||
seaneveson updated this revision to Diff 38519.
seaneveson added a comment.
Removed checking for already exited loops
Addressed Comments
http://reviews.llvm.org/D12358
Files:
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
include/clang/StaticAnalyzer/Core/PathSensitive/LoopWidening.h
seaneveson marked 5 inline comments as done.
Comment at: test/Analysis/loop-widening.c:160
@@ +159,3 @@
+void variable_bound_exiting_loops_widened(int x) {
+ int i = 0;
+ int t = 1;
The inner loop will now be widened in the first example test, which
'coincident
djasper marked an inline comment as done.
djasper added a comment.
http://reviews.llvm.org/D14104
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
djasper updated this revision to Diff 38524.
djasper added a comment.
Extended comment.
http://reviews.llvm.org/D14104
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/ContinuationIndenter.cpp
lib/Format/Format.cpp
lib/Format/FormatToken.cpp
lib/Forma
mprobst accepted this revision.
mprobst added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D14104
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
Author: xazax
Date: Tue Oct 27 07:36:26 2015
New Revision: 251404
URL: http://llvm.org/viewvc/llvm-project?rev=251404&view=rev
Log:
[analyzer] Fix another crash when analyzing lambda functions.
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/MemRegion.cpp
cfe/trunk/test/Analysis/lambdas.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL251405: clang-format: Add an additional value to
AlignAfterOpenBracket: AlwaysBreak. (authored by djasper).
Changed prior to commit:
http://reviews.llvm.org/D14104?vs=38524&id=38529#toc
Repository:
r
Author: djasper
Date: Tue Oct 27 07:38:37 2015
New Revision: 251405
URL: http://llvm.org/viewvc/llvm-project?rev=251405&view=rev
Log:
clang-format: Add an additional value to AlignAfterOpenBracket: AlwaysBreak.
Summary:
If this option is set, clang-format will always insert a line wrap, e.g.
befo
sdardis updated this revision to Diff 38533.
sdardis added a comment.
Updated tests along the lines of what vkalintiris did for llvm.
http://reviews.llvm.org/D10802
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib/CodeGen/TargetInfo.cpp
lib/Sema/SemaDeclAttr.cpp
Author: djasper
Date: Tue Oct 27 08:42:08 2015
New Revision: 251406
URL: http://llvm.org/viewvc/llvm-project?rev=251406&view=rev
Log:
clang-format: Undo unwanted format change done in r251405.
Specifically, don't wrap between the {} of an empty constructor if the
"}" falls on column 81 and Constr
Author: xazax
Date: Tue Oct 27 08:46:39 2015
New Revision: 251407
URL: http://llvm.org/viewvc/llvm-project?rev=251407&view=rev
Log:
[analyzer] Fix lambdas that are capturing constants.
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/ExprEngine.cpp
cfe/trunk/test/Analysis/lambdas.cpp
Modified
olista01 created this revision.
olista01 added reviewers: mclow.lists, compnerd.
olista01 added a subscriber: cfe-commits.
olista01 set the repository for this revision to rL LLVM.
The fallback malloc in libcxxabi (used to allocate space for exception
objects in out-of-memory situations) defines i
tstellarAMD added a subscriber: tstellarAMD.
tstellarAMD added auditors: rsmith.
tstellarAMD added a comment.
This is OK to merge to the 3.7 branch as long as Richard approves. Though it
would be nice to have a *BSD code owner for these types of things. Any
volunteers?
Users:
joerg (Author
I've ended up using the simplified fix described on the MS connect bug
report for this issue:
https://connect.microsoft.com/VisualStudio/feedback/details/1741530
I’ve been able to work around this by changing ASTContext.cpp:368 from
if (RC) {
Raw.setRaw(RC);
Raw.setKind(RawCommentAndCach
tstellarAMD added a subscriber: tstellarAMD.
tstellarAMD added auditors: rsmith.
tstellarAMD added a comment.
Hi Richard,
Is this OK to merge to the 3.7 branch?
Users:
joerg (Author, Auditor)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
rsmith (Auditor)
http://re
tstellarAMD added a subscriber: tstellarAMD.
tstellarAMD added auditors: rsmith.
tstellarAMD added a comment.
Hi Richard,
Is this OK to merge to the 3.7 branch?
Users:
joerg (Author, Auditor)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
rsmith (Auditor)
http://re
tstellarAMD added a subscriber: tstellarAMD.
tstellarAMD added auditors: rsmith.
tstellarAMD added a comment.
Hi Richard,
Is this OK to merge to the 3.7 branch?
Users:
dim (Author)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
joerg (Auditor)
rsmith (Auditor)
ht
labrinea created this revision.
labrinea added reviewers: rengolin, cfe-commits, bsmith.
Herald added subscribers: rengolin, aemerson.
When running clang with an arm triple such as '--target=thumbv7m-arm-none-eabi'
that has a thumb only CPU by default (cortex-m3), and when using the assembler,
t
Author: compnerd
Date: Tue Oct 27 10:50:22 2015
New Revision: 251410
URL: http://llvm.org/viewvc/llvm-project?rev=251410&view=rev
Log:
Index: expose is_mutable_field
Expose isMutable via libClang and python bindings.
Patch by Jonathan B Coe!
Modified:
cfe/trunk/bindings/python/clang/cindex.
Looks fine Will, please commit but keep a comment and a link to the connect
bug. We don't want somebody to accidentally "clean-up" the code and break
things again.
On Tue, Oct 27, 2015 at 7:49 AM, Will Wilson via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> I've ended up using the simplifi
t.p.northover added a subscriber: t.p.northover.
t.p.northover accepted this revision.
t.p.northover added a reviewer: t.p.northover.
t.p.northover added a comment.
This revision is now accepted and ready to land.
This looks mostly fine, just one quick question that shouldn't block anything:
===
rengolin added inline comments.
Comment at: test/Driver/arm-ias-Wa.s:67
@@ +66,3 @@
+// == Triple
+// RUN: %clang -target armv7a-arm-none-eabi -c %s -### 2>&1 \
+// RUN: | FileCheck -check-prefix=CHECK-A-PROFILE %s
t.p.northover added a subscriber: t.p.northover.
t.p.northover added a comment.
Using alignas(heap_node) might be a little clearer and more semantically
correct here. Should be OK support-wise, libc++ is already using that for some
of its bits. Otherwise, good find!
Tim.
Repository:
rL LLVM
tstellarAMD added a subscriber: tstellarAMD.
tstellarAMD added auditors: rsmith, 3.7-release, cfe-commits, tstellarAMD.
tstellarAMD added a comment.
Hi Richard,
Is this OK to merge to the 3.7 branch?
Users:
ismailp (Author)
rsmith (Auditor)
3.7-release (Auditor)
cfe-commits (Auditor)
EricWF added a subscriber: EricWF.
EricWF added a comment.
This patch is incomplete and incorrect. The heap actually needs to be aligned
to a 16 byte boundary, and all pointers returned from it must also be 16 byte
aligned. I have a complete fix for this issue as http://reviews.llvm.org/D12669.
t.p.northover added a comment.
Oh, and I **think** it can probably be justified under C++, though I've not
quite joined up all the dots. The "object lifetime" rules seem to bless
declaring a char array dead and reusing its storage for another purpose. Since
heap_node has trivial initialization,
labrinea updated this revision to Diff 38552.
http://reviews.llvm.org/D14121
Files:
lib/Driver/ToolChain.cpp
test/Driver/arm-ias-Wa.s
Index: test/Driver/arm-ias-Wa.s
===
--- test/Driver/arm-ias-Wa.s
+++ test/Driver/arm-ias-Wa.s
On Mon, Oct 26, 2015 at 11:02 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Modified: cfe/trunk/include/clang/Sema/ScopeInfo.h
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Sema/ScopeInfo.h?rev=251387&r1=251386&r2=251387&view=diff
>
> =
rengolin accepted this revision.
rengolin added a comment.
I wish there was a way to get the info if a target is thumb-only, but this is
ok as an intermediate solution. :)
LGTM too, thanks!
http://reviews.llvm.org/D14121
___
cfe-commits mailing li
EricWF added a comment.
@t.p.northover @olista01 A char array can legally alias any other type memory
AFAIK. Its perfectly legal to use a char array to provide raw memory. There
shouldn't be any undefined behavior here.
Repository:
rL LLVM
http://reviews.llvm.org/D14119
_
Author: rnk
Date: Tue Oct 27 11:24:03 2015
New Revision: 251412
URL: http://llvm.org/viewvc/llvm-project?rev=251412&view=rev
Log:
Widen this enum bitfield by one bit to prevent sign extension in MSVC
Modified:
cfe/trunk/include/clang/Sema/ScopeInfo.h
Modified: cfe/trunk/include/clang/Sema/Sc
olista01 abandoned this revision.
olista01 added a comment.
Ok, I'll abandon this patch and wait for Eric's.
I think the char* aliasing rule only works one way, i.e. any object can be
accessed through an lvalue of type char, but not the other way round (c++11,
3.10/10). I didn't know about the
labrinea added inline comments.
Comment at: lib/Driver/ToolChain.cpp:485
@@ +484,3 @@
+if ((ARM::parseArchProfile(Suffix) == ARM::PK_M) ||
+(InputType != types::TY_PP_Asm &&
+ Args.hasFlag(options::OPT_mthumb, options::OPT_mno_thumb,
ThumbDefault)))
--
jroelofs added inline comments.
Comment at: src/fallback_malloc.ipp:69
@@ -59,1 +68,3 @@
+// Size: 4
+// Alignment: 2
struct heap_node {
EricWF wrote:
> compnerd wrote:
> > Make this a set of static_asserts?
> I was going to but I wasn't 100% sure this would be t
On Tue, Oct 27, 2015 at 9:24 AM, Reid Kleckner via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Mon, Oct 26, 2015 at 11:02 PM, Richard Smith via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Modified: cfe/trunk/include/clang/Sema/ScopeInfo.h
>> URL:
>> http://llvm.org/viewvc/llv
rengolin added inline comments.
Comment at: lib/Driver/ToolChain.cpp:485
@@ +484,3 @@
+if ((ARM::parseArchProfile(Suffix) == ARM::PK_M) ||
+(InputType != types::TY_PP_Asm &&
+ Args.hasFlag(options::OPT_mthumb, options::OPT_mno_thumb,
ThumbDefault)))
--
Author: lantictac
Date: Tue Oct 27 12:01:10 2015
New Revision: 251415
URL: http://llvm.org/viewvc/llvm-project?rev=251415&view=rev
Log:
[MSVC] Workaround for ICE in cl.exe when compiling ASTContext.cpp in Release
Win32
Microsoft connect bug:
https://connect.microsoft.com/VisualStudio/feedback/d
Thanks David,
Committed as r251415.
On 27 October 2015 at 17:01, David Majnemer
wrote:
> Looks fine Will, please commit but keep a comment and a link to the
> connect bug. We don't want somebody to accidentally "clean-up" the code
> and break things again.
>
> On Tue, Oct 27, 2015 at 7:49 AM,
t.p.northover added inline comments.
Comment at: lib/Driver/ToolChain.cpp:485
@@ +484,3 @@
+if ((ARM::parseArchProfile(Suffix) == ARM::PK_M) ||
+(InputType != types::TY_PP_Asm &&
+ Args.hasFlag(options::OPT_mthumb, options::OPT_mno_thumb,
ThumbDefault)))
-
grimar abandoned this revision.
grimar added a comment.
r251415 fixes this in another way.
http://reviews.llvm.org/D13203
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rengolin added inline comments.
Comment at: lib/Driver/ToolChain.cpp:485
@@ +484,3 @@
+if ((ARM::parseArchProfile(Suffix) == ARM::PK_M) ||
+(InputType != types::TY_PP_Asm &&
+ Args.hasFlag(options::OPT_mthumb, options::OPT_mno_thumb,
ThumbDefault)))
--
labrinea updated this revision to Diff 38558.
http://reviews.llvm.org/D14121
Files:
lib/Driver/ToolChain.cpp
lib/Driver/Tools.cpp
test/Driver/arm-ias-Wa.s
Index: test/Driver/arm-ias-Wa.s
===
--- test/Driver/arm-ias-Wa.s
+++ te
Author: rnk
Date: Tue Oct 27 12:34:29 2015
New Revision: 251419
URL: http://llvm.org/viewvc/llvm-project?rev=251419&view=rev
Log:
[ms-inline-asm] Test case for alignment directive change in LLVM r251418
Added:
cfe/trunk/test/CodeGen/ms-inline-asm-align.c
Added: cfe/trunk/test/CodeGen/ms-inli
labrinea added a comment.
It seems I missed your comments before updating the patch.
@t.p.northover: What is the exact command? "clang -arch armv7 -c tmp.s" didn't
work for me.
http://reviews.llvm.org/D14121
___
cfe-commits mailing list
cfe-commits
rengolin added inline comments.
Comment at: lib/Driver/ToolChain.cpp:472
@@ -471,2 +471,3 @@
+bool ThumbDefault = (ARM::parseArchProfile(Suffix) == ARM::PK_M) ||
(Suffix.startswith("v7") && getTriple().isOSBinFormatMachO());
// FIXME: this is invalid for WindowsCE
labrinea added a comment.
Is this revision valid after all? I am confused by Tim's comment. I did not see
any regressions locally.
Comment at: lib/Driver/ToolChain.cpp:472
@@ -471,2 +471,3 @@
+bool ThumbDefault = (ARM::parseArchProfile(Suffix) == ARM::PK_M) ||
(Suffi
t.p.northover added a comment.
If you're on Linux or something you need "clang -target x86_64-apple-darwin
-arch armv7 -c tmp.s". Another mess I keep meaning to fix.
I suspect the reason for this hack is that we've already changed the triple to
"thumbv7-apple-iosN" by this point (because -arch
t.p.northover added a comment.
Ping?
Repository:
rL LLVM
http://reviews.llvm.org/D13874
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: tra
Date: Tue Oct 27 12:56:59 2015
New Revision: 251427
URL: http://llvm.org/viewvc/llvm-project?rev=251427&view=rev
Log:
Allow linking multiple bitcode files.
Linking options for particular file depend on the option that specifies the
file.
Currently there are two:
* -mlink-bitcode-fil
This revision was automatically updated to reflect the committed changes.
Closed by commit rL251427: Allow linking multiple bitcode files. (authored by
tra).
Changed prior to commit:
http://reviews.llvm.org/D13913?vs=38046&id=38562#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13913
Fil
Author: dsanders
Date: Tue Oct 27 13:04:42 2015
New Revision: 251430
URL: http://llvm.org/viewvc/llvm-project?rev=251430&view=rev
Log:
[mips] Separated mips specific -Wa options, so that they are not checked on
other platforms.
Summary: This is a follow on to post review comments on revision r24
rengolin added a comment.
In http://reviews.llvm.org/D14121#276389, @t.p.northover wrote:
> If you're on Linux or something you need "clang -target x86_64-apple-darwin
> -arch armv7 -c tmp.s".
x86_64 + ARMv7? This doesn't make sense... What is this trying to achieve?
> I suspect the reason fo
labrinea added a comment.
In http://reviews.llvm.org/D14121#276389, @t.p.northover wrote:
> If you're on Linux or something you need "clang -target x86_64-apple-darwin
> -arch armv7 -c tmp.s". Another mess I keep meaning to fix.
>
> I suspect the reason for this hack is that we've already change
sbenza added a comment.
In http://reviews.llvm.org/D14096#275902, @xazax.hun wrote:
> There is already a similar check in the Google package. What are the
> differences between those two checks? What is the reason we can not just
> register that check into the core guidelines module?
That oth
hfinkel added inline comments.
Comment at: include/clang/Basic/DiagnosticParseKinds.td:995
@@ -994,1 +994,3 @@
+def err_omp_expected_reduction_identifier : Error<
+ "expected identifier or one of the following operators: '+', '-', '*', '&',
'|', '^', '&&' and '||'">;
-
On Oct 27, 2015 11:06, "Renato Golin" wrote:
>
> rengolin added a comment.
>
> In http://reviews.llvm.org/D14121#276389, @t.p.northover wrote:
>
> > If you're on Linux or something you need "clang -target
x86_64-apple-darwin -arch armv7 -c tmp.s".
>
>
> x86_64 + ARMv7? This doesn't make sense... W
On 27 October 2015 at 18:15, Tim Northover via cfe-commits
wrote:
> It sets the underlying platform to a Darwin one so that -arch armv7 flag
> works as expected.
Still looks weird. I don't think this should work at all, as in, the
driver should emit an error like "no such arch". But that's not
re
tra updated this revision to Diff 38574.
tra added a comment.
Added test cases for force-including of cuda_runtime.h
Tweaked inclusion of one header due to use of default arguments.
http://reviews.llvm.org/D13171
Files:
lib/Driver/ToolChains.cpp
lib/Headers/CMakeLists.txt
lib/Headers/cuda
tra updated this revision to Diff 38576.
tra added a comment.
Updated to reflect latest changes in http://reviews.llvm.org/D13913.
http://reviews.llvm.org/D13170
Files:
include/clang/Driver/Options.td
include/clang/Driver/ToolChain.h
lib/Driver/ToolChain.cpp
lib/Driver/ToolChains.cpp
Author: d0k
Date: Tue Oct 27 13:34:47 2015
New Revision: 251432
URL: http://llvm.org/viewvc/llvm-project?rev=251432&view=rev
Log:
Remove unused diagnostic. NFC.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
URL:
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
This should be fine. Sorry for the breakage.
http://reviews.llvm.org/D13920
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
Two minor comments, otherwise looks good:
1. beware of the GCC 4.7 issues and trivial class initializer issues we hit
with this kind of changes earlier.
2. I prefer to leave utils/unittest/g
OK, so I fixed this last night in r251388. I decided to go with "," means
"and" and "|" means "or" and go from there. If we need a more complicated
syntax we'll go back to the drawing board :)
-eric
On Sun, Oct 18, 2015 at 9:57 AM Craig Topper wrote:
> Interestingly, gcc doesn't get this right
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm, I don't feel strongly about whether -fms-compatibility matters, but I'd
prefer that it didn't.
Comment at: lib/Sema/SemaStmt.cpp:224
@@ +223,3 @@
+ // but its implementation
Author: nico
Date: Tue Oct 27 14:47:40 2015
New Revision: 251441
URL: http://llvm.org/viewvc/llvm-project?rev=251441&view=rev
Log:
Tweak how -Wunused-value interacts with macros
1. Make the warning more strict in C mode. r172696 added code to suppress
warnings from macro expansions in system h
thakis closed this revision.
thakis marked an inline comment as done.
thakis added a comment.
Done and landed in r251441, thanks!
http://reviews.llvm.org/D13969
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
jroelofs created this revision.
jroelofs added a reviewer: EricWF.
jroelofs added a subscriber: cfe-commits.
Now that we store this information in the __config file, these aren't needed.
http://reviews.llvm.org/D14130
Files:
zorg/buildbot/builders/LibcxxAndAbiBuilder.py
Index: zorg/buildbot/b
Author: zaks
Date: Tue Oct 27 15:19:45 2015
New Revision: 251449
URL: http://llvm.org/viewvc/llvm-project?rev=251449&view=rev
Log:
[analyzer] Assume escape is possible through system functions taking void*
The analyzer assumes that system functions will not free memory or modify the
arguments in o
Author: zaks
Date: Tue Oct 27 15:19:38 2015
New Revision: 251448
URL: http://llvm.org/viewvc/llvm-project?rev=251448&view=rev
Log:
[analyzer] Enhance FAQ with instructions on handing unused variables.
Modified:
cfe/trunk/www/analyzer/faq.html
Modified: cfe/trunk/www/analyzer/faq.html
URL:
h
majnemer added a comment.
No diagnostic is issued for the following C test case:
int x __attribute__((internal_linkage));
int x __attribute__((common));
int *f() { return &x; }
Comment at: include/clang/Basic/Attr.td:2112
@@ +2111,3 @@
+
+def InternalLinkage : Inheritable
LegalizeAdulthood added a comment.
In http://reviews.llvm.org/D7639#275504, @sbenza wrote:
> Just fyi, I am looking at this diff. It is very large with a lot of rounds of
> comments and I didn't have the context.
> I don't know if I should giving comments at this point of the change, but
> her
LegalizeAdulthood added a comment.
I mean, look at this review. I created it on Feb 13th 2015. It's been getting
ground through the review process for 8 months. Why can't we move forward?
http://reviews.llvm.org/D7639
___
cfe-commits mailing lis
hfinkel added a comment.
In http://reviews.llvm.org/D13304#269049, @junbuml wrote:
> I just want to ping one more time to see if there is any objection about the
> basic idea of this change. If the basic idea itself is acceptable, then I
> want to find the best way to get idea in.
>
> Please le
junbuml added a comment.
Did you mean to add the Cold in the exception handling region itself instead of
callsite in throw statements ?
http://reviews.llvm.org/D13304
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
sbenza accepted this revision.
sbenza added a comment.
This revision is now accepted and ready to land.
Just wanted to know it was considered, and it was.
It looks good to me then.
http://reviews.llvm.org/D7639
___
cfe-commits mailing list
cfe-commi
hfinkel added a comment.
In http://reviews.llvm.org/D13304#276660, @junbuml wrote:
> Did you mean to add the Cold in the exception handling region itself instead
> of callsite in throw statements ?
We already have BranchProbabilityInfo::calcColdCallHeuristics, and so adding it
to the callsite
Hello everyone,
LLVM buildmaster will be restarted after 7 PM Pacific time today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kkwli0 created this revision.
kkwli0 added reviewers: ABataev, rsmith, hfinkel, sfantao, fraggamuffin.
kkwli0 added a subscriber: cfe-commits.
This patch is to add parsing and sema support for map clause. This includes
the new map types and the map type modifier added in OpenMP 4.5.
http://rev
Author: sfantao
Date: Tue Oct 27 17:20:26 2015
New Revision: 251459
URL: http://llvm.org/viewvc/llvm-project?rev=251459&view=rev
Log:
Minor fix in ToolChainTest.cpp to allow user defined GCC toolchain.
If the user configured clang with a custom GCC toolchain that will take
precedence on what the
sfantao closed this revision.
sfantao added a comment.
Committed in r251459.
Thanks!
Samuel
http://reviews.llvm.org/D13920
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hfinkel added a comment.
In http://reviews.llvm.org/D13802#275471, @chandlerc wrote:
> In http://reviews.llvm.org/D13802#274847, @ABataev wrote:
>
> > Hi Chandler, thanks for the review.
> >
> > In http://reviews.llvm.org/D13802#272053, @chandlerc wrote:
> >
> > > I've also had one test fail, and
Author: djasper
Date: Tue Oct 27 17:55:55 2015
New Revision: 251463
URL: http://llvm.org/viewvc/llvm-project?rev=251463&view=rev
Log:
clang-format: Increase cut-off limit for number of analyzed states.
With more complex structures in C++ Lambdas and JavaScript function
literals, the old value was
junbuml added a comment.
I see what you mean. Now, I doubt if
BranchProbabilityInfo::calcColdCallHeuristics() set the Cold before inliner.
As far as I check, BranchProbabilityInfo is executed after inliner.
Another issue is that even if we can add the Cold in callsites in exception
handling
hfinkel added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:688
@@ -687,1 +687,3 @@
+ virtual bool isSoftFloatABI() const {
+return false;
Instead of adding this function, please use the same mechanism as
X86_32TargetCodeGenInfo and X86_32A
Author: rjmccall
Date: Tue Oct 27 19:17:34 2015
New Revision: 251469
URL: http://llvm.org/viewvc/llvm-project?rev=251469&view=rev
Log:
Add the ability to define "fake" arguments on attributes.
Fake arguments are automatically handled for serialization, cloning,
and other representational tasks, b
alexfh accepted this revision.
alexfh added a comment.
In http://reviews.llvm.org/D7639#276641, @LegalizeAdulthood wrote:
> I mean, look at this review. I created it on Feb 13th 2015. It's been
> getting ground through the review process for 8 months. Why can't we move
> forward?
Yes, I kn
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D14105
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
Author: djasper
Date: Tue Oct 27 20:08:22 2015
New Revision: 251474
URL: http://llvm.org/viewvc/llvm-project?rev=251474&view=rev
Log:
clang-format: When a line is formatted, also format subsequence lines if their
indent is off.
Summary: This is especially important so that if a change is solely
This revision was automatically updated to reflect the committed changes.
Closed by commit rL251474: clang-format: When a line is formatted, also format
subsequence lines if… (authored by djasper).
Changed prior to commit:
http://reviews.llvm.org/D14105?vs=38497&id=38616#toc
Repository:
rL L
1 - 100 of 114 matches
Mail list logo
