t.p.northover added a subscriber: t.p.northover. t.p.northover accepted this revision. t.p.northover added a reviewer: t.p.northover. t.p.northover added a comment. This revision is now accepted and ready to land.
This looks mostly fine, just one quick question that shouldn't block anything: ================ Comment at: test/Driver/arm-ias-Wa.s:67 @@ +66,3 @@ +// ========================================================== Triple +// RUN: %clang -target armv7a-arm-none-eabi -c %s -### 2>&1 \ +// RUN: | FileCheck -check-prefix=CHECK-A-PROFILE %s ---------------- Is the -arm- vendor intentional (because DS-5 uses that or something)? Fine if so (it could probably do with being tested actually), a bit weird otherwise. http://reviews.llvm.org/D14121 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
