hfinkel added inline comments. ================ Comment at: include/clang/Basic/DiagnosticParseKinds.td:995 @@ -994,1 +994,3 @@ +def err_omp_expected_reduction_identifier : Error< + "expected identifier or one of the following operators: '+', '-', '*', '&', '|', '^', '&&' and '||'">; ---------------- We're not incredibly consistent here, but I think this reads better if we say:
'&&', or '||' instead of: '&&' and '||' (adding the Oxford comma and 'and' -> 'or'). ================ Comment at: lib/AST/Decl.cpp:1463 @@ -1461,1 +1462,3 @@ + // Declare reduction are always replaceable. + if (OMPDeclareReductionDecl::classofKind(NewK)) ---------------- are -> is http://reviews.llvm.org/D11182 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
