bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land.
Two minor comments, otherwise looks good: 1. beware of the GCC 4.7 issues and trivial class initializer issues we hit with this kind of changes earlier. 2. I prefer to leave utils/unittest/googletest alone as it's imported from google code. Changing it makes merging upstream changes harder. 3. Please leave the comments inside empty constructors or destructors. http://reviews.llvm.org/D13891 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
