[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza added a comment. > I don't think it'll actually error out at link time: protocol objects get > emitted eagerly on use, cross-module linking is just a code-size > optimization. This actually has caused longstanding problems. But if it's just a forward declaration there's nothing to emit. T

[PATCH] D85762: [OPENMP]Do not allow threadprivates as base for array-like reduction.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85762/new/ https://reviews.llvm.org/D85762 ___

[PATCH] D84887: [OPENMP]Fix codegen for is_device_ptr component, captured by reference.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84887/new/ https://reviews.llvm.org/D84887 ___

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

OikawaKirie added a comment. We have tried to trigger the crash with the original project where the crash was encountered. But the problem is we cannot trigger the crash with the project, and we have lost all the previous records about this crash. Besides, both I and the bug reporter himself ar

[PATCH] D86877: [Clang][Driver] Use full path to builtins in bare-metal toolchain

phosek added a comment. It's not clear why couldn't we support per-target runtime directory? It uses the standard multiarch layout, so in you'd end up using a directory like `[path/to/resource-dir]/lib/armv6m-unknown-eabi/libclang_rt.builtins.a`. I'd find this more preferable for consistency wi

[PATCH] D87331: Sema: add support for `__attribute__((__swift_error__))`

rjmccall accepted this revision. rjmccall added a comment. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87331/new/ https://reviews.llvm.org/D87331 ___ cfe-commits mailing list cfe-commits@

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

rjmccall added a comment. I don't think it'll actually error out at link time: protocol objects get emitted eagerly on use, cross-module linking is just a code-size optimization. This actually has caused longstanding problems. Anyway, I think it's fine to require forward declarations to have t

[PATCH] D87201: [clang-format] Add a option for the position of Java static import

bc-lee added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:1970 + but this behavior is changed by another option, + ``JavaStaticImportAfterImport``. MyDeveloperDay wrote: > Can you add a test that shows if the sorting is still in the gro

[PATCH] D87201: [clang-format] Add a option for the position of Java static import

bc-lee updated this revision to Diff 290619. bc-lee added a comment. Add more tests and rename options. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87201/new/ https://reviews.llvm.org/D87201 Files: clang/docs/ClangFormatStyleOptions.rst clan

[PATCH] D87338: [Driver][PGO] Driver support for de-Optimizing cold functions (PATCH 2/2)

myhsu created this revision. myhsu added reviewers: rsmith, bogner, xur. Herald added subscribers: cfe-commits, wenlei, dang, dexonsmith, steven_wu, hiraditya. Herald added a project: clang. myhsu requested review of this revision. Following up https://reviews.llvm.org/D87337 . This patch add the

[PATCH] D83154: clang: Add -fcoverage-prefix-map

keith updated this revision to Diff 290610. keith retitled this revision from "clang: Add -fprofile-prefix-map" to "clang: Add -fcoverage-prefix-map". keith edited the summary of this revision. keith added a comment. Rename from fcoverage-prefix-map to fprofile-prefix-map Repository: rG LLVM

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza added a comment. A concern that has come up while rewriting this for the listed concerns is forward declared protocols that are defined as `non_runtime`. @protocol NonRuntimeProto; @interface Implementer : Root @end @implementation Implementer ... @end This compiles jus

[PATCH] D87331: Sema: add support for `__attribute__((__swift_error__))`

compnerd updated this revision to Diff 290601. compnerd added a comment. - correct typos - apply clang-format changes - `const` correct a few declarations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87331/new/ https://reviews.llvm.org/D87331 Fi

[libunwind] 88bf133 - [libunwind] Replace chain-of-ifdefs for dl_iterate_phdr

Author: Ryan Prichard Date: 2020-09-08T15:49:35-07:00 New Revision: 88bf133c99c3124842c182a019306f83f2c1b856 URL: https://github.com/llvm/llvm-project/commit/88bf133c99c3124842c182a019306f83f2c1b856 DIFF: https://github.com/llvm/llvm-project/commit/88bf133c99c3124842c182a019306f83f2c1b856.diff

[PATCH] D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87243/new/ https://reviews.llvm.org/D87243 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option

kastiglione updated this revision to Diff 290597. kastiglione edited the summary of this revision. kastiglione added a comment. Add LLVM_ENABLE_WARNINGS to LLVMConfig.cmake.in Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87243/new/ https://reviews

[PATCH] D87331: Sema: add support for `__attribute__((__swift_error__))`

rjmccall added a comment. Oh, there are a ton of typos in this documentation. Comment at: clang/include/clang/Basic/AttrDocs.td:3396 +the imported API, and dynamically will always pass a valid address initialized +to a null pointer. + Please split this sentence

[PATCH] D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option

JDevlieghere added a comment. In D87243#2261687 , @kastiglione wrote: > If an LLVM install disabled `LLVM_ENABLE_WARNINGS`, should other builds > inherit that? I would think no, but is there a precedent for that that to be > the case? Yes, most of the `

[PATCH] D87332: [profile] Add %t LLVM_PROFILE_FILE option to substitute $TMPDIR

vsk updated this revision to Diff 290590. vsk added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Document the new option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87332/new/ https://reviews.llvm.org/D8733

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

rahmanl added a comment. @efriedma Would you please chime in specially with respect to @MaskRay 's comment about the clang test involving assembly? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85408/new/ https://reviews.llvm.org/D85408 _

[PATCH] D87331: Sema: add support for `__attribute__((__swift_error__))`

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87331/new/ https://reviews.llvm.org/D87331 _

[PATCH] D87331: Sema: add support for `__attribute__((__swift_error__))`

compnerd created this revision. compnerd added a reviewer: aaron.ballman. Herald added a reviewer: jdoerfert. Herald added a project: clang. compnerd requested review of this revision. Introduce a new attribute that is used to indicate the error handling convention used by a function. This is use

[PATCH] D84316: [analyzer][NFC] Split CStringChecker to modeling and reporting

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker/CStringChecker.cpp:32-34 +auto CStringChecker::createOutOfBoundErrorMsg(StringRef FunctionDescription, + AccessKind Access) +-> ErrorMessage {

[PATCH] D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option

kastiglione added a comment. If another project defines `LLVM_ENABLE_WARNINGS` before loading `HandleLLVMOptions`, it seems correct to me that the first one is used. This change ensures the default value of ON is setup at the last possible opportunity, before `LLVM_ENABLE_WARNINGS` is read and

[PATCH] D87324: [HIP] Add gfx1030 and gfx1031

This revision was automatically updated to reflect the committed changes. Closed by commit rG041da0d828e3: [HIP] Add gfx1031 and gfx1030 (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87324/new/ ht

[clang] 041da0d - [HIP] Add gfx1031 and gfx1030

Author: Yaxun (Sam) Liu Date: 2020-09-08T16:38:34-04:00 New Revision: 041da0d828e39d849c99adf1391aaa9291f4310f URL: https://github.com/llvm/llvm-project/commit/041da0d828e39d849c99adf1391aaa9291f4310f DIFF: https://github.com/llvm/llvm-project/commit/041da0d828e39d849c99adf1391aaa9291f4310f.dif

[clang] f4ac79a - Sema: extract a check for `isCFError` (NFC)

Author: Saleem Abdulrasool Date: 2020-09-08T20:07:47Z New Revision: f4ac79a364f2de7270a3238b176e17b40b036305 URL: https://github.com/llvm/llvm-project/commit/f4ac79a364f2de7270a3238b176e17b40b036305 DIFF: https://github.com/llvm/llvm-project/commit/f4ac79a364f2de7270a3238b176e17b40b036305.diff

[PATCH] D87324: [HIP] Add gfx1030 and gfx1031

ashi1 accepted this revision. ashi1 added a comment. LGTM, looks like its already in clang/include/clang/Basic/Cuda.h and clang/lib/Basic/Targets/AMDGPU.cpp. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87324/new/ https://reviews.llvm.org/D87324 __

[PATCH] D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option

compnerd added a comment. The change itself is fine, but what about downstream projects which define the option? Will that trigger a warning? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87243/new/ https://reviews.llvm.org/D87243 __

[PATCH] D87324: [HIP] Add gfx1030 and gfx1031

yaxunl created this revision. yaxunl added reviewers: tra, ashi1. yaxunl requested review of this revision. https://reviews.llvm.org/D87324 Files: clang/lib/Basic/Cuda.cpp clang/test/Driver/hip-offload-arch.hip Index: clang/test/Driver/hip-offload-arch.hip ==

[PATCH] D86445: [analyzer][RFC] Simplify MetadataSymbol representation and resolve a CStringChecker FIXME

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp:2429 if (SymbolRef Sym = Len.getAsSymbol()) { if (SR.isDead(Sym)) +Entries = F.remove(Entries, MR); NoQ wrote: > martong wrote: > > steakhal wrote: > >

[PATCH] D86445: [analyzer][RFC] Simplify MetadataSymbol representation and resolve a CStringChecker FIXME

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp:2429 if (SymbolRef Sym = Len.getAsSymbol()) { if (SR.isDead(Sym)) +Entries = F.remove(Entries, MR); martong wrote: > steakhal wrote: > > NoQ wrote: > >

[PATCH] D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs.

rsmith added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:4583 if (!InitE) return getDefaultInitValue(VD->getType(), Val); The initializer might also be null because the variable is type-dependent (eg, `X x;`), in which case assuming def

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn added a comment. Note that we now also have to compute the PostDominatorTree, which adds an extra bit of compile-time overhead. By adjusting the pipeline a bit more, we can re-use ADCE's PDTs in most cases, which gives a `-0.18%` geomean improvement for -O3 D87322

[PATCH] D85351: [Analyzer] Fix for `ExprEngine::computeObjectUnderConstruction()` for base and delegating consturctor initializers

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:138-139 SVal ThisVal = State->getSVal(ThisPtr); + if (Init->isBaseInitializer() || Init->isDelegatingInitializer()) +return ThisVal; For base initializer

[PATCH] D87253: [libTooling] Change CDB heuristic to look further for files in a given language.

nridge added a comment. In D87253#2261837 , @amosnier wrote: > How can I make sure I will receive updates on this issue (or any prolongation > of it)? By commenting on this review, you're automatically subscribed to it, so should get an email notificati

[PATCH] D87253: [libTooling] Change CDB heuristic to look further for files in a given language.

amosnier added a comment. In D87253#2261205 , @kadircet wrote: > As discussed offline, this is trading off some accuracy between getting `-I` > correct vs `-std` and it is unclear whether that's beneficial or harmful. It > is easy to come up with example

[PATCH] D87321: Fix -gz=zlib options for linker

MaskRay added inline comments. Comment at: clang/test/Driver/hip-gz-options.hip:6 +// RUN: %clang -### --offload-arch=gfx906 %s -nogpulib -nogpuinc \ +// RUN: -ggdb -gz=zlib 2>&1 | FileCheck %s + -ggdb is unrelated CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D87321: Fix -gz=zlib options for linker

MaskRay added inline comments. Comment at: clang/test/Driver/hip-gz-options.hip:6 +// RUN: %clang -### --offload-arch=gfx906 %s -nogpulib -nogpuinc \ +// RUN: -ggdb -gz=zlib 2>&1 | FileCheck %s + MaskRay wrote: > -ggdb is unrelated Sorry it is related. CHANGE

[PATCH] D87321: Fix -gz=zlib options for linker

MaskRay added inline comments. Comment at: clang/test/Driver/gz.c:1 +// RUN: %clang -### -target x86_64-unknown-linux-gnu -g -gz=none %s 2>&1 | \ +// RUN:FileCheck -check-prefix=NONE %s This can be merged into `compress.c` You may delete some `-c` from compre

[PATCH] D87321: Fix -gz=zlib options for linker

yaxunl created this revision. yaxunl added reviewers: tra, MaskRay. Herald added subscribers: kerbowa, nhaehnle, jvesely. yaxunl requested review of this revision. gcc translates -gz=zlib to --compress-debug-options=zlib for both assembler and linker but clang only does this for assembler. The l

[PATCH] D66564: [clang-tidy] new altera struct pack align check

ffrankies added a comment. In D66564#2260836 , @aaron.ballman wrote: > I've committed on your behalf in 156b127945a8c923d141e608b7380427da024376 > . Thank > you for the new check! No

[PATCH] D84962: [PowerPC] Correct cpsgn's behaviour on PowerPC to match that of the ABI

bsaleil added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:14298 llvm::Function *F = CGM.getIntrinsic(ID, ResultType); -return Builder.CreateCall(F, {X, Y}); +return Builder.CreateCall(F, {Y, X}); } Could you add a test case in `cl

[PATCH] D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option

kastiglione added a comment. If an LLVM install disabled `LLVM_ENABLE_WARNINGS`, should other builds inherit that? I would think no, but is there's a precedent for that that to be the case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87243/new/

[clang] d95ef00 - Update clang/test/Driver/darwin-infer-simulator-sdkroot.c

Author: Azharuddin Mohammed Date: 2020-09-08T11:27:18-07:00 New Revision: d95ef009bd502a1c2c82952d4fa6fd1db836cef9 URL: https://github.com/llvm/llvm-project/commit/d95ef009bd502a1c2c82952d4fa6fd1db836cef9 DIFF: https://github.com/llvm/llvm-project/commit/d95ef009bd502a1c2c82952d4fa6fd1db836cef9

[PATCH] D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option

JDevlieghere added a comment. You need to add `LLVM_ENABLE_WARNINGS` to `LLVMConfig.cmake.in` so that the standalone builds know what value was set in the LLVM build. I think with the current patch the other projects won't inherit the value and just default to `ON`? Repository: rG LLVM Gith

[clang] e6bb4c8 - [X86] SSE4_A should only imply SSE3 not SSSE3 in the frontend.

Author: Craig Topper Date: 2020-09-08T10:50:59-07:00 New Revision: e6bb4c8e7b3e27f214c9665763a2dd09aa96a5ac URL: https://github.com/llvm/llvm-project/commit/e6bb4c8e7b3e27f214c9665763a2dd09aa96a5ac DIFF: https://github.com/llvm/llvm-project/commit/e6bb4c8e7b3e27f214c9665763a2dd09aa96a5ac.diff

[PATCH] D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs.

hokein added a comment. friendly ping @rsmith. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84637/new/ https://reviews.llvm.org/D84637 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

jkorous added subscribers: dexonsmith, akyrtzi. jkorous added a comment. Hi @usaxena95 and @sammccall, I am wondering about couple high-level things. Do you guys intend to open-source also the training part of the model pipeline or publish a model trained on generic-enough training set so it co

[PATCH] D78938: Fixing all comparisons for C++20 compilation.

jfb added a comment. On C++20 mode rotting: it won't if someone sets up a bot. If it rots, then it's easier to un-rot with Barry's patch. Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:805-817 + return IsASCII ? "^" : (const char *)u8"\u2548"; case LineChar::Ra

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. I like the simplification:) However, I still feel puzzled by the large chunk of assembly test in `clang/test/CodeGen/basic-block-sections.c`. I hope another reviewer or the code owner can sa

[PATCH] D87278: [Ignore Expressions] Fix performance regression by inlining `Ignore*SingleStep`

riccibruno accepted this revision. riccibruno added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87278/new/ https://reviews.llvm.org/D87278 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D87291: [clang-format][regression][PR47461] ifdef causes catch to be seen as a function

MyDeveloperDay added a comment. Note to self, other things could cause the same issue try // comment { try /* comment */ { Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87291/new/ https://reviews.llvm.org/D87291 ___

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

rahmanl added a comment. Thanks for the review @MaskRay. Is this ready to land now? Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1047 + getObjFileLowering().getBBAddrMapSection(*MF.getSection()); + if (!BBAddrMapSection) +return; MaskRay wro

[PATCH] D87253: [libTooling] Change CDB heuristic to look further for files in a given language.

kadircet added a comment. As discussed offline, this is trading off some accuracy between getting `-I` correct vs `-std` and it is unclear whether that's beneficial or harmful. It is easy to come up with examples for both and we were split 50/50 between each. In the end all of this is a heuristi

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

rahmanl updated this revision to Diff 290511. rahmanl marked an inline comment as done. rahmanl added a comment. - Merge remote-tracking branch 'origin/master' into arcpatch-D85408 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85408/new/ https://re

[clang-tools-extra] 71133e8 - [clang-tidy] Fix linking for FrontendOpenMP

Author: Heejin Ahn Date: 2020-09-08T09:22:22-07:00 New Revision: 71133e8b5bceaf68a2cee59af371df570a1aed79 URL: https://github.com/llvm/llvm-project/commit/71133e8b5bceaf68a2cee59af371df570a1aed79 DIFF: https://github.com/llvm/llvm-project/commit/71133e8b5bceaf68a2cee59af371df570a1aed79.diff LO

[PATCH] D85473: [Clang] Add option to allow marking pass-by-value args as noalias.

fhahn added inline comments. Comment at: clang/include/clang/Driver/Options.td:4287-4290 +def fpass_by_value_noalias: Flag<["-"], "fpass-by-value-noalias">, + HelpText<"Allows assuming no references to passed by value escape before " + "transferring execution to the ca

[PATCH] D85473: [Clang] Add option to allow marking pass-by-value args as noalias.

fhahn updated this revision to Diff 290504. fhahn marked an inline comment as done. fhahn added a comment. Change to codegen option, adjust description for option, limit to trivially copyable types in C++, add corresponding test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D86632: [Fixed Point] Add codegen for conversion between fixed-point and floating point.

ebevhan updated this revision to Diff 290502. ebevhan added a comment. Updated method name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86632/new/ https://reviews.llvm.org/D86632 Files: clang/lib/CodeGen/CGExprScalar.cpp clang/test/Frontend/

[PATCH] D87291: [clang-format][regression][PR47461] ifdef causes catch to be seen as a function

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: JakeMerdichAMD, krasimir, arichardson, curdeius. MyDeveloperDay added projects: clang-format, clang. MyDeveloperDay requested review of this revision. https://bugs.llvm.org/show_bug.cgi?id=47461 The following change D80940: [cl

[PATCH] D84362: [NFC] Add missing functions to PartialDiagnostic

yaxunl added a comment. ping. this is needed by https://reviews.llvm.org/D84364 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84362/new/ https://reviews.llvm.org/D84362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D86581: [clang-format] Handle shifts within conditions

MyDeveloperDay added a comment. @Saldivarcher this should be landed now, please validate Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86581/new/ https://reviews.llvm.org/D86581 ___ cfe-commits mailing l

[clang] c81dd3d - [clang-format] Handle shifts within conditions

Author: mydeveloperday Date: 2020-09-08T16:40:04+01:00 New Revision: c81dd3d159ab03d46e4280c458d3c29e56648218 URL: https://github.com/llvm/llvm-project/commit/c81dd3d159ab03d46e4280c458d3c29e56648218 DIFF: https://github.com/llvm/llvm-project/commit/c81dd3d159ab03d46e4280c458d3c29e56648218.diff

[PATCH] D86581: [clang-format] Handle shifts within conditions

This revision was automatically updated to reflect the committed changes. Closed by commit rGc81dd3d159ab: [clang-format] Handle shifts within conditions (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86581/new/ https://

[PATCH] D79293: [clang-format] [PR45218] Fix an issue where < and > and >> in a for loop gets incorrectly interpreted at a TemplateOpener/Closer

MyDeveloperDay abandoned this revision. MyDeveloperDay added a comment. Better solution here D86581: [clang-format] Handle shifts within conditions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79293/new/ https://reviews.llvm.org/D79293 __

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

ostannard accepted this revision. ostannard added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72932/new/ https://reviews.llvm.org/D72932 ___

[PATCH] D85960: [AST][FPEnv] Keep FP options in trailing storage of CastExpr

sepavloff marked 3 inline comments as done. sepavloff added a comment. In D85960#2259703 , @riccibruno wrote: >> This change allow a CallExpr to have optional FPOptionsOverride object, > > Should this be `CastExpr` instead? Yes, thank you for the catch.

[PATCH] D87201: [clang-format] Add a option for the position of Java static import

JakeMerdichAMD added inline comments. Comment at: clang/include/clang/Format/Format.h:1708 + /// \endcode + bool JavaStaticImportAfterImport; + MyDeveloperDay wrote: > Can we consider changing the name or the option to make it clearer what its > for? > > `Sor

[PATCH] D85960: [AST][FPEnv] Keep FP options in trailing storage of CastExpr

sepavloff updated this revision to Diff 290487. sepavloff added a comment. Updated patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85960/new/ https://reviews.llvm.org/D85960 Files: clang/include/clang/AST/Expr.h clang/include/clang/AST/Exp

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

stuij marked 6 inline comments as done. stuij added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:396 +/// according to the field declaring type width. +CODEGENOPT(ForceNoAAPCSBitfieldWidth, 1, 0) + ostannard wrote: > dnsampaio wrote:

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

stuij commandeered this revision. stuij added a reviewer: dnsampaio. stuij added a comment. Commandeering as I've made some changes to the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72932/new/ https://reviews.llvm.org/D72932

[PATCH] D87201: [clang-format] Add a option for the position of Java static import

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:1970 + but this behavior is changed by another option, + ``JavaStaticImportAfterImport``. Can you add a test that shows if the sorting is still in the groups, i.e. I can

[PATCH] D86445: [analyzer][RFC] Simplify MetadataSymbol representation and resolve a CStringChecker FIXME

steakhal added a comment. In D86445#2260744 , @martong wrote: >> But if the string is invalidated (or the new length is completely unknown), >> **do not remove** the length from the state; instead, set it to >> SymbolConjured. > > Where exactly do you im

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob updated this revision to Diff 290483. dougpuob added a comment. This is a test with `arc diff master --update D86671` command. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86671/new/ https://reviews.llvm.org/D86671 Files: clang-tools-e

[clang-tools-extra] 32ae37b - [clang-tidy] Fix dynamic build failures after 156b127945a8c923d141e608b7380427da024376

Author: Haojian Wu Date: 2020-09-08T16:26:48+02:00 New Revision: 32ae37b038b16a1ff9c81428ae4f003377439a22 URL: https://github.com/llvm/llvm-project/commit/32ae37b038b16a1ff9c81428ae4f003377439a22 DIFF: https://github.com/llvm/llvm-project/commit/32ae37b038b16a1ff9c81428ae4f003377439a22.diff LO

[clang] 2d9d270 - Revert 3e782bf809 "[Sema][MSVC] warn at dynamic_cast when /GR- is given"

Author: Hans Wennborg Date: 2020-09-08T16:10:18+02:00 New Revision: 2d9d270e77918dfc19ad9b3150ee7d40eeb8ca79 URL: https://github.com/llvm/llvm-project/commit/2d9d270e77918dfc19ad9b3150ee7d40eeb8ca79 DIFF: https://github.com/llvm/llvm-project/commit/2d9d270e77918dfc19ad9b3150ee7d40eeb8ca79.diff

[PATCH] D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable

Xiangling_L added a comment. In D86790#2255371 , @jyknight wrote: > Do you have open questions on whether some callsites passing "false" here, > should be switched to true? Given what's here, I would say that it definitely > does not makes sense to add t

[clang-tools-extra] 9933188 - StructPackAlignCheck: Fix a -Winconsistent-missing-override warning

Author: Nico Weber Date: 2020-09-08T10:02:00-04:00 New Revision: 9933188c90615c9c264ebb69117f09726e909a25 URL: https://github.com/llvm/llvm-project/commit/9933188c90615c9c264ebb69117f09726e909a25 DIFF: https://github.com/llvm/llvm-project/commit/9933188c90615c9c264ebb69117f09726e909a25.diff LO

[PATCH] D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option

DavidTruby accepted this revision. DavidTruby added a comment. LGTM and seems to work from the flang side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87243/new/ https://reviews.llvm.org/D87243 ___ cfe

[PATCH] D86936: [clang] Limit the maximum level of fold-expr expansion.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9c9974c3ccb6: [clang] Limit the maximum level of fold-expr expansion. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[clang] 9c9974c - [clang] Limit the maximum level of fold-expr expansion.

Author: Haojian Wu Date: 2020-09-08T15:40:09+02:00 New Revision: 9c9974c3ccb6468cc83f759240293538cf123fcd URL: https://github.com/llvm/llvm-project/commit/9c9974c3ccb6468cc83f759240293538cf123fcd DIFF: https://github.com/llvm/llvm-project/commit/9c9974c3ccb6468cc83f759240293538cf123fcd.diff LO

[clang-tools-extra] 156b127 - Add a new altera check for structure packing and alignment.

Author: Frank Derry Wanye Date: 2020-09-08T09:35:14-04:00 New Revision: 156b127945a8c923d141e608b7380427da024376 URL: https://github.com/llvm/llvm-project/commit/156b127945a8c923d141e608b7380427da024376 DIFF: https://github.com/llvm/llvm-project/commit/156b127945a8c923d141e608b7380427da024376.d

[PATCH] D66564: [clang-tidy] new altera struct pack align check

aaron.ballman closed this revision. aaron.ballman added a comment. I've committed on your behalf in 156b127945a8c923d141e608b7380427da024376 . Thank you for the new check! CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D76604: [Analyzer] Model `size()` member function of containers

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. This basically looks good to me. Comment at: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp:482-483 +// of the container (the difference between its `begin()`

[PATCH] D86135: [analyzer][MacroExpansion] Fix a crash where multiple parameters resolved to __VA_ARGS__

martong accepted this revision. martong added a comment. LGTM! Thanks for the clarification and the example you gave. (I agree with @steakhal and I wish if we could get rid of the many lines not-descriptive plist stuff, but that is rather unrelated) CHANGES SINCE LAST ACTION https://reviews.l

[clang] e674051 - [analyzer] [NFC] Introduce refactoring of PthreadLockChecker

Author: Denys Petrov Date: 2020-09-08T16:04:19+03:00 New Revision: e67405141836fcd88183863758eeb42f32e847a6 URL: https://github.com/llvm/llvm-project/commit/e67405141836fcd88183863758eeb42f32e847a6 DIFF: https://github.com/llvm/llvm-project/commit/e67405141836fcd88183863758eeb42f32e847a6.diff

[PATCH] D87138: [analyzer][NFC] Introduce refactoring of PthreadLockChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rGe67405141836: [analyzer] [NFC] Introduce refactoring of PthreadLockChecker (authored by ASDenysPetrov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87138/n

[PATCH] D87282: [SYCL] Assume SYCL device functions are convergent

bader created this revision. Herald added subscribers: cfe-commits, Anastasia, ebevhan, yaxunl. Herald added a project: clang. bader requested review of this revision. SYCL device compiler (similar to other SPMD compilers) assumes that functions are convergent by default to avoid invalid transform

[PATCH] D85984: [analyzer] Add a new checker alpha.cplusplus.CPlusPlus11Lock

ASDenysPetrov added a comment. @steakhal > the readability of the reports should be improved. Absolutely agree. Let's do this in the next patches :) @NoQ You've recommended to extend PthreadLockChecker with STL mutexes. I think I've done. Could you make a quick look, please? ==

[PATCH] D86445: [analyzer][RFC] Simplify MetadataSymbol representation and resolve a CStringChecker FIXME

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp:2384-2385 if (SuperRegions.count(MR)) { Entries = F.remove(Entries, MR); + Entries = F.add(Entries, MR, UnknownVal()); continue; martong wrote:

[PATCH] D86445: [analyzer][RFC] Simplify MetadataSymbol representation and resolve a CStringChecker FIXME

martong added a comment. > But if the string is invalidated (or the new length is completely unknown), > **do not remove** the length from the state; instead, set it to > SymbolConjured. Where exactly do you implement the above? > When strlen(R) is used for the first time on a region R, prod

[PATCH] D86137: Add ignore-unknown-options flag to clang-format.

fodinabor updated this revision to Diff 290461. fodinabor added a comment. Remove test entry form .clang-format :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86137/new/ https://reviews.llvm.org/D86137 Files: clang/include/clang/Format/Format.

[PATCH] D86137: Add ignore-unknown-options flag to clang-format.

fodinabor updated this revision to Diff 290460. fodinabor marked 9 inline comments as done. fodinabor added a comment. Incorporating review comments: - renaming option to -Wno-error=unknown and adding warning in description - emit warnings instead of fully ignoring the issues Documentation and u

[PATCH] D87189: [CMake] Remove dead FindPythonInterp code

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG86bd8f82cc74: [CMake] Remove dead FindPythonInterp code (authored by tambre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[clang] ae85da8 - [Codegen][X86] Begin moving X86 specific codegen tests into X86 subfolder.

Author: Simon Pilgrim Date: 2020-09-08T13:01:24+01:00 New Revision: ae85da86ad8fbd022129650d0b2a6b615709a790 URL: https://github.com/llvm/llvm-project/commit/ae85da86ad8fbd022129650d0b2a6b615709a790 DIFF: https://github.com/llvm/llvm-project/commit/ae85da86ad8fbd022129650d0b2a6b615709a790.diff

[PATCH] D85426: [clangd] Implement FileFilter for the indexer

kbobyrev planned changes to this revision. kbobyrev added a comment. WIP. Need to get around background indexing tricks to make it work. Failed Tests (3): Clangd Unit Tests :: ./ClangdTests/BackgroundIndexTest.Config Clangd Unit Tests :: ./ClangdTests/BackgroundIndexTest.IndexTwoFiles

[PATCH] D85426: [clangd] Implement FileFilter for the indexer

kbobyrev updated this revision to Diff 290453. kbobyrev added a comment. Also check if deinition comes from unwwanted file (e.g. omit forward declarations). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85426/new/ https://reviews.llvm.org/D85426

[PATCH] D87189: [CMake] Remove dead FindPythonInterp code

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. Herald added a subscriber: dexonsmith. I love this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87189/new/ https://reviews.llvm.org/D87189

[PATCH] D87278: [Ignore Expressions] Fix performance regression by inlining `Ignore*SingleStep`

eduucaldas created this revision. eduucaldas added a reviewer: gribozavr2. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. eduucaldas requested review of this revision. We also add a `const` versions of `IgnoreExprNodes` Repository: rG LLVM Github Monorepo https:

  1   2   >