amosnier added a comment. In D87253#2261205 <https://reviews.llvm.org/D87253#2261205>, @kadircet wrote:
> As discussed offline, this is trading off some accuracy between getting `-I` > correct vs `-std` and it is unclear whether that's beneficial or harmful. It > is easy to come up with examples for both and we were split 50/50 between > each. > In the end all of this is a heuristic work and it is quite likely that we > might break this for more people, while trying to fix this one specific case. > So I don't think it's worth it. > > As for suggestions(again from offline discussion) : > > - We can implement a more sophisticated transfer logic in clangd layer, by > making use of compile commands from a TU including a particular header > - When there's a mismatch in language, we can try to merge two commands. One > with filename/path match and filetype match. I do not have the full picture, but I trust your judgment. I think I understand the first suggestion, which sounds very good. I would offer to help, but I know I won't have enough time. I can test. :-) How can I make sure I will receive updates on this issue (or any prolongation of it)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87253/new/ https://reviews.llvm.org/D87253 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
