NoQ added inline comments.
================ Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker/CStringChecker.cpp:32-34 +auto CStringChecker::createOutOfBoundErrorMsg(StringRef FunctionDescription, + AccessKind Access) + -> ErrorMessage { ---------------- Why suddenly use arrow syntax here? ================ Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker/CStringChecker.h:227 +#endif \ No newline at end of file ---------------- No NeWlInE aT eNd Of FiLe ================ Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker/CStringLengthModeling.cpp:309 + +// TODO: Is it useful? +void CStringChecker::printState(raw_ostream &Out, ProgramStateRef State, ---------------- Yes it is. It gets invoked during exploded graph dumps and it's an invaluable debugging facility. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84316/new/ https://reviews.llvm.org/D84316 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits