martong added inline comments.
================
Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp:2384-2385
if (SuperRegions.count(MR)) {
Entries = F.remove(Entries, MR);
+ Entries = F.add(Entries, MR, UnknownVal());
continue;
----------------
martong wrote:
> Umm, these two lines are quite disturbing after each other. Seems like first
> we remove `MR` then we add `MR` again, so, this must not be a noop, right?
> But then what is happening here exactly? Some comments around here in the
> code would help.
Ugh, giving it more thought, we just reset the Value associated to `MR`. Still,
would be nice to comment this there.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86445/new/
https://reviews.llvm.org/D86445
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
