kadircet added a comment.

As discussed offline, this is trading off some accuracy between getting `-I` 
correct vs `-std` and it is unclear whether that's beneficial or harmful. It is 
easy to come up with examples for both and we were split 50/50 between each.
In the end all of this is a heuristic work and it is quite likely that we might 
break this for more people, while trying to fix this one specific case. So I 
don't think it's worth it.

As for suggestions(again from offline discussion) :

- We can implement a more sophisticated transfer logic in clangd layer, by 
making use of compile commands from a TU including a particular header
- When there's a mismatch in language, we can try to merge two commands. One 
with filename/path match and filetype match.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87253/new/

https://reviews.llvm.org/D87253

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to