JDevlieghere added a comment.

In D87243#2261687 <https://reviews.llvm.org/D87243#2261687>, @kastiglione wrote:

> If an LLVM install disabled `LLVM_ENABLE_WARNINGS`, should other builds 
> inherit that? I would think no, but is there a precedent for that that to be 
> the case?

Yes, most of the `LLVM_ENABLE_*` options work that way. I guess you could argue 
that some of those are different because LLVM is the one "detecting" whether 
they should be on, such as `LLVM_ENABLE_ZLIB`. But 
`LLVM_ENABLE_EXPENSIVE_CHECKS` and `LLVM_ENABLE_ASSERTIONS` seem conceptually 
very similar to `LLVM_ENABLE_WARNINGS` so (in my opinion) it should behave the 
same.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87243/new/

https://reviews.llvm.org/D87243

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to