rahmanl added a comment. Thanks for the review @MaskRay. Is this ready to land now?
================ Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1047 + getObjFileLowering().getBBAddrMapSection(*MF.getSection()); + if (!BBAddrMapSection) + return; ---------------- MaskRay wrote: > rahmanl wrote: > > MaskRay wrote: > > > BBAddrMapSection is always non-null. Delete the if. > > I believe we return null for non-ELF environment (Please refer to > > MCObjectFileInfo::getBBAddrMapSection). > In that case emitBBAddrMapSection will not be called? Fair enough. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85408/new/ https://reviews.llvm.org/D85408 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
