On Wed, 20 Nov 2024 16:20:59 GMT, Magnus Ihse Bursie wrote:
> First of all, building stuff with `--with-extra-cflags` is always at your own
> peril. It might, or might not, work, partially due to problems such as the
> one you describe, where the user-added flag somehow conflicts with the
> ex
On Fri, 15 Mar 2024 13:58:05 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review this patch?
>> Thanks
>>
>> This is a continuation of work based on [1] by @XiaohongGong, most work was
>> done in that pr. In this new pr, just rebased the code in [1], then added
>> some minor changes (renami
On Wed, 20 Nov 2024 07:53:45 GMT, Patrick Zhang wrote:
> > > > Ah, it'll only be the redirect library that's compiled with
> > > > -march=armv8-a+sve Forget that.
> > >
> > >
> > > But that raises an interesting question. What happens if you try to load
> > > a library compiled with `-march=a
On Fri, 22 Mar 2024 15:30:35 GMT, Hamlin Li wrote:
> > > Ah, it'll only be the redirect library that's compiled with
> > > -march=armv8-a+sve Forget that.
> >
> >
> > But that raises an interesting question. What happens if you try to load a
> > library compiled with `-march=armv8-a+sve` on a
On Tue, 22 Oct 2024 09:28:36 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch? Previously it's
>> https://github.com/openjdk/jdk/pull/18605.
>> This pr is based on https://github.com/openjdk/jdk/pull/20781.
>>
>> Thanks!
>>
>> ## Test
>> ### tests:
>> * test/jdk/jdk/incubator/v
On Fri, 1 Nov 2024 11:01:24 GMT, Andrew Haley wrote:
> Here are my results, Apple M1. Pretty similar to what we've seen, but no SVE.
>
> Looks good.
Thank you so much for testing!
-
PR Comment: https://git.openjdk.org/jdk/pull/21502#issuecomment-2454181484
On Tue, 22 Oct 2024 09:28:36 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch? Previously it's
>> https://github.com/openjdk/jdk/pull/18605.
>> This pr is based on https://github.com/openjdk/jdk/pull/20781.
>>
>> Thanks!
>>
>> ## Test
>> ### tests:
>> * test/jdk/jdk/incubator/v
On Tue, 22 Oct 2024 09:28:36 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch? Previously it's
>> https://github.com/openjdk/jdk/pull/18605.
>> This pr is based on https://github.com/openjdk/jdk/pull/20781.
>>
>> Thanks!
>>
>> ## Test
>> ### tests:
>> * test/jdk/jdk/incubator/v
On Tue, 22 Oct 2024 09:28:36 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch? Previously it's
>> https://github.com/openjdk/jdk/pull/18605.
>> This pr is based on https://github.com/openjdk/jdk/pull/20781.
>>
>> Thanks!
>>
>> ## Test
>> ### tests:
>> * test/jdk/jdk/incubator/v
On Tue, 22 Oct 2024 09:28:36 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch? Previously it's
>> https://github.com/openjdk/jdk/pull/18605.
>> This pr is based on https://github.com/openjdk/jdk/pull/20781.
>>
>> Thanks!
>>
>> ## Test
>> ### tests:
>> * test/jdk/jdk/incubator/v
On Tue, 22 Oct 2024 09:28:36 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch? Previously it's
>> https://github.com/openjdk/jdk/pull/18605.
>> This pr is based on https://github.com/openjdk/jdk/pull/20781.
>>
>> Thanks!
>>
>> ## Test
>> ### tests:
>> * test/jdk/jdk/incubator/v
> Hi,
> Can you help to review the patch? Previously it's
> https://github.com/openjdk/jdk/pull/18605.
> This pr is based on https://github.com/openjdk/jdk/pull/20781.
>
> Thanks!
>
> ## Test
> ### tests:
> * test/jdk/jdk/incubator/vector/
> * test/hotspot/jtreg/compiler/vectorapi/
>
> ### opti
On Mon, 21 Oct 2024 09:53:16 GMT, Fei Gao wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add missing files
>
> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 8207:
>
>> 8205: for (int op = 0; op < Vect
On Wed, 16 Oct 2024 14:00:37 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch? Previously it's
>> https://github.com/openjdk/jdk/pull/18605.
>> This pr is based on https://github.com/openjdk/jdk/pull/20781.
>>
>> Thanks!
>>
>> ## Test
>> ### tests:
>> * test/jdk/jdk/incubator/v
> Hi,
> Can you help to review the patch? Previously it's
> https://github.com/openjdk/jdk/pull/18605.
> This pr is based on https://github.com/openjdk/jdk/pull/20781.
>
> Thanks!
>
> ## Test
> ### tests:
> * test/jdk/jdk/incubator/vector/
> * test/hotspot/jtreg/compiler/vectorapi/
>
> ### opti
On Wed, 16 Oct 2024 12:15:51 GMT, Ludovic Henry wrote:
>> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 8218:
>>
>>> 8216:
>>> 8217: snprintf(ebuf, sizeof(ebuf), "%sdx_%ssve",
>>> VectorSupport::mathname[op], ulf);
>>> 8218:
>>> StubRoutines::_vector_d_math[VectorSupp
On Wed, 16 Oct 2024 10:29:58 GMT, Fei Gao wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update make/autoconf/flags-cflags.m4
>>
>> Co-authored-by: Magnus Ihse Bursie
>
> src/hotspot/cpu/aarch64/stubGenerator_a
On Tue, 15 Oct 2024 12:16:28 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch? Previously it's
>> https://github.com/openjdk/jdk/pull/18605.
>> This pr is based on https://github.com/openjdk/jdk/pull/20781.
>>
>> Thanks!
>>
>> ## Test
>> ### tests:
>> * test/jdk/jdk/incubator/v
On Tue, 15 Oct 2024 12:16:28 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch? Previously it's
>> https://github.com/openjdk/jdk/pull/18605.
>> This pr is based on https://github.com/openjdk/jdk/pull/20781.
>>
>> Thanks!
>>
>> ## Test
>> ### tests:
>> * test/jdk/jdk/incubator/v
On Tue, 15 Oct 2024 11:04:40 GMT, Magnus Ihse Bursie wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update make/autoconf/flags-cflags.m4
>>
>> Co-authored-by: Magnus Ihse Bursie
>
> make/autoconf/flags-cflags.m
> Hi,
> Can you help to review the patch? Previously it's
> https://github.com/openjdk/jdk/pull/18605.
> This pr is based on https://github.com/openjdk/jdk/pull/20781.
>
> Thanks!
>
> ## Test
> ### tests:
> * test/jdk/jdk/incubator/vector/
> * test/hotspot/jtreg/compiler/vectorapi/
>
> ### opti
On Mon, 14 Oct 2024 14:57:46 GMT, Hamlin Li wrote:
> Hi,
> Can you help to review the patch? Previously it's
> https://github.com/openjdk/jdk/pull/18605.
> This pr is based on https://github.com/openjdk/jdk/pull/20781.
>
> Thanks!
>
> ## Test
> ### tests:
> * test/jdk/jdk/incubator/vector/
> *
On Tue, 23 Jul 2024 13:55:06 GMT, fitzsim wrote:
> To check this, I
> [added](https://github.com/fitzsim/jdk/commits/regenerate-sleef-headers-2/)
> the `riscv64` `CMake` steps to `SleefCommon.gmk`.
>
> I had intended to factor out `SetupSleefHeader` anyway for `aarch64`, to
> eliminate copy-n
On Fri, 19 Jul 2024 09:18:13 GMT, Andrew Haley wrote:
> Compared to current implementation in #19185, my bit concern about [This
> branch](https://github.com/fitzsim/jdk/commits/regenerate-sleef-headers-1/)
> is the future maintainence effort when we need to update the sleef source
> along wit
On Tue, 9 Jul 2024 12:08:50 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch?
>> This pr is based on previous work and discussion in [pr
>> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
>> 18294](https://github.com/openjdk/jdk/pull/18294).
>> * NOTE: This pr depends on
On Thu, 18 Jul 2024 20:50:14 GMT, fitzsim wrote:
> It is possible to regenerate `sleefinline_advsimd.h` and `sleefinline_sve.h`
> with some new OpenJDK build logic and only the following fifteen SLEEF source
> files:
>
> ```
> 32K ./src/jdk.incubator.vector/linux/native/sleef/src/arch/helper
On Tue, 9 Jul 2024 12:08:50 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch?
>> This pr is based on previous work and discussion in [pr
>> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
>> 18294](https://github.com/openjdk/jdk/pull/18294).
>> * NOTE: This pr depends on
On Tue, 16 Jul 2024 10:42:24 GMT, Andrew Haley wrote:
> We're only a couple of weeks away from the summit. What would be a long time?
OK, then let's wait for it.
-
PR Comment: https://git.openjdk.org/jdk/pull/18605#issuecomment-2230591233
On Tue, 16 Jul 2024 09:48:55 GMT, Andrew Haley wrote:
> @theRealAph Thanks for clarification.
>
> I think there are several different parts involved in the above discussion,
> please kindly correct me if I misunderstood.
>
> 1. package builders. This is about the release of jdk (both src a
On Mon, 15 Jul 2024 17:35:59 GMT, Ludovic Henry wrote:
>>> > I can't tell what problem we're trying to solve by not simply checking in
>>> > the source code, in its preferred form, to the OpenJDK tree. Thhis has
>>> > practical advantages to do with traceability and security, and
>>> > in-prin
On Tue, 16 Jul 2024 09:48:55 GMT, Andrew Haley wrote:
>>> Currently,
>>>
>>> * in [8329816: Add SLEEF version 3.6.1
>>> #19185](https://github.com/openjdk/jdk/pull/19185) it generates the sleef
>>> inline headers from sleef 3.6.1, which is tagged in sleef repo.
>>>
>>> * And with the
On Tue, 16 Jul 2024 08:21:04 GMT, Andrew Haley wrote:
> This is starting to sound like we need a policy decision, because we don't
> want to re-hash this discussion every time the question comes up, as it
> surely will.
+1 to this if we don't already have one
While I haven't read through eve
On Tue, 9 Jul 2024 12:08:50 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch?
>> This pr is based on previous work and discussion in [pr
>> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
>> 18294](https://github.com/openjdk/jdk/pull/18294).
>> * NOTE: This pr depends on
On Tue, 16 Jul 2024 08:35:25 GMT, Andrew Haley wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> skip TANH
>
>> Currently,
>>
>> * in [8329816: Add SLEEF version 3.6.1
>> #19185](https://github.com/openjdk/jdk/pul
On Tue, 16 Jul 2024 08:35:25 GMT, Andrew Haley wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> skip TANH
>
>> Currently,
>>
>> * in [8329816: Add SLEEF version 3.6.1
>> #19185](https://github.com/openjdk/jdk/pul
On Tue, 9 Jul 2024 12:08:50 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch?
>> This pr is based on previous work and discussion in [pr
>> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
>> 18294](https://github.com/openjdk/jdk/pull/18294).
>> * NOTE: This pr depends on
On Mon, 15 Jul 2024 21:17:03 GMT, Mikael Vidstedt wrote:
> I think the key question is whether we're comfortable relying on/pointing at
> an external repository which may or may not be there tomorrow and/or where
> tags may change outside of our control.
Right. We should adopt best practice, b
On Mon, 15 Jul 2024 17:35:59 GMT, Ludovic Henry wrote:
> Given the Sleef build system currently uses cmake, we would have two choices
> to build the header files as part of the OpenJDK build system
I don't think that anyone is proposing to do that, so we can discount it
altogether.
> However,
On Tue, 9 Jul 2024 12:08:50 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch?
>> This pr is based on previous work and discussion in [pr
>> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
>> 18294](https://github.com/openjdk/jdk/pull/18294).
>> * NOTE: This pr depends on
On Mon, 15 Jul 2024 17:35:59 GMT, Ludovic Henry wrote:
> I think so, along with scripting that generates the preprocessed file we use.
> It might be the case that there are some sleef files not used at all they
> could be omitted, but I'm not sure it would be useful, and from a
> traceability
On Tue, 9 Jul 2024 12:08:50 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch?
>> This pr is based on previous work and discussion in [pr
>> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
>> 18294](https://github.com/openjdk/jdk/pull/18294).
>> * NOTE: This pr depends on
On Mon, 15 Jul 2024 17:00:13 GMT, Andrew Haley wrote:
> > > I can't tell what problem we're trying to solve by not simply checking in
> > > the source code, in its preferred form, to the OpenJDK tree. Thhis has
> > > practical advantages to do with traceability and security, and
> > > in-princ
On Mon, 15 Jul 2024 14:42:45 GMT, Hamlin Li wrote:
> > I can't tell what problem we're trying to solve by not simply checking in
> > the source code, in its preferred form, to the OpenJDK tree. Thhis has
> > practical advantages to do with traceability and security, and in-principle
> > reason
On Wed, 10 Jul 2024 10:48:19 GMT, Andrew Haley wrote:
> I can't tell what problem we're trying to solve by not simply checking in the
> source code, in its preferred form, to the OpenJDK tree. Thhis has practical
> advantages to do with traceability and security, and in-principle reasons to
>
On Mon, 8 Jul 2024 16:20:40 GMT, Andrew Haley wrote:
> I finally did some measurements.
Thanks for testing it!
> It would be nice if the JMH test were part of this patch.
OK, I can do that later.
>
> It mostly looks good, but I can see an odd regression of DoubleMaxVector.TANH
> (by 39%) o
On Mon, 8 Jul 2024 16:40:50 GMT, Andrew Haley wrote:
>> Hamlin Li has updated the pull request with a new target base due to a merge
>> or a rebase. The pull request now contains 33 commits:
>>
>> - Merge branch 'master' into sleef-aarch64-integrate-source
>> - merge master
>> - sleef 3.6.1
On Mon, 8 Jul 2024 16:40:50 GMT, Andrew Haley wrote:
>> Hamlin Li has updated the pull request with a new target base due to a merge
>> or a rebase. The pull request now contains 33 commits:
>>
>> - Merge branch 'master' into sleef-aarch64-integrate-source
>> - merge master
>> - sleef 3.6.1
> Hi,
> Can you help to review the patch?
> This pr is based on previous work and discussion in [pr
> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
> 18294](https://github.com/openjdk/jdk/pull/18294).
> * NOTE: This pr depends on https://github.com/openjdk/jdk/pull/19185, which
> includ
> Hi,
> Can you help to review the patch?
> This pr is based on previous work and discussion in [pr
> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
> 18294](https://github.com/openjdk/jdk/pull/18294).
> * NOTE: This pr depends on https://github.com/openjdk/jdk/pull/19185, which
> includ
On Mon, 1 Jul 2024 16:54:55 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch?
>> This pr is based on previous work and discussion in [pr
>> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
>> 18294](https://github.com/openjdk/jdk/pull/18294).
>> * NOTE: This pr depends on
On Mon, 1 Jul 2024 16:54:55 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch?
>> This pr is based on previous work and discussion in [pr
>> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
>> 18294](https://github.com/openjdk/jdk/pull/18294).
>> * NOTE: This pr depends on
On Mon, 8 Jul 2024 13:36:36 GMT, Andrew Haley wrote:
> There is something that makes me nervous. The big slab of preprocessed code
> in libvectormath/sleefinline_rvvm1.h is problematic. Firstly, in all open
> source software the code should be the preferred form:
>
> "The source code must be t
On Mon, 1 Jul 2024 16:54:55 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch?
>> This pr is based on previous work and discussion in [pr
>> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
>> 18294](https://github.com/openjdk/jdk/pull/18294).
>>
>> Compared with previous
On Mon, 8 Jul 2024 08:43:34 GMT, Andrew Haley wrote:
> That doesn't work.
>
> ```
> Running tests using MICRO control variable
> 'FORK=1;ITER=10;WARMUP_ITER=10;JAVA_OPTIONS=-XX:+UnlockExperimentalVMOptions
> -XX:+EnableVectorSupport -XX:+UseVectorStubs'
> Unknown test selection:
> 'org.openjd
On Mon, 1 Jul 2024 16:54:55 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch?
>> This pr is based on previous work and discussion in [pr
>> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
>> 18294](https://github.com/openjdk/jdk/pull/18294).
>>
>> Compared with previous
On Fri, 5 Jul 2024 17:44:14 GMT, Andrew Haley wrote:
> I also had problems with javac running out of heap space, which was very odd.
> I fixed it with this:
>
> ```
> diff --git a/make/autoconf/boot-jdk.m4 b/make/autoconf/boot-jdk.m4
> index 8d272c28ad5..617ccfd8fff 100644
> --- a/make/autoconf
On Mon, 1 Jul 2024 16:54:55 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch?
>> This pr is based on previous work and discussion in [pr
>> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
>> 18294](https://github.com/openjdk/jdk/pull/18294).
>>
>> Compared with previous
> Hi,
> Can you help to review the patch?
> This pr is based on previous work and discussion in [pr
> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
> 18294](https://github.com/openjdk/jdk/pull/18294).
>
> Compared with previous prs, the major change in this pr is to integrate the
> sou
On Thu, 27 Jun 2024 11:53:38 GMT, Fei Gao wrote:
>> in progress...
>
> Hi @Hamlin-Li , thanks for your work.
>
> I tried to run benchmarks,
> [FloatMaxVector](https://github.com/openjdk/panama-vector/blob/vectorIntrinsics/test/micro/org/openjdk/bench/jdk/incubator/vector/operation/FloatMaxVecto
On Thu, 6 Jun 2024 07:52:02 GMT, Hamlin Li wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update header files for arm
>
> in progress...
Hi @Hamlin-Li , thanks for your work.
I tried to run benchmarks,
[FloatMaxVe
On Mon, 24 Jun 2024 15:37:43 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch?
>> This pr is based on previous work and discussion in [pr
>> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
>> 18294](https://github.com/openjdk/jdk/pull/18294).
>>
>> Compared with previous
> Hi,
> Can you help to review the patch?
> This pr is based on previous work and discussion in [pr
> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
> 18294](https://github.com/openjdk/jdk/pull/18294).
>
> Compared with previous prs, the major change in this pr is to integrate the
> sou
> Hi,
> Can you help to review the patch?
> This pr is based on previous work and discussion in [pr
> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
> 18294](https://github.com/openjdk/jdk/pull/18294).
>
> Compared with previous prs, the major change in this pr is to integrate the
> sou
On Wed, 8 May 2024 17:41:23 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch?
>> This pr is based on previous work and discussion in [pr
>> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
>> 18294](https://github.com/openjdk/jdk/pull/18294).
>>
>> Compared with previous
> Hi,
> Can you help to review the patch?
> This pr is based on previous work and discussion in [pr
> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
> 18294](https://github.com/openjdk/jdk/pull/18294).
>
> Compared with previous prs, the major change in this pr is to integrate the
> sou
On Tue, 9 Apr 2024 20:10:36 GMT, Mikael Vidstedt wrote:
>> Hamlin Li has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - disable unused-function warnings; add log msg
>> - minor
>
> Thank you for the update and for working on this in gene
> Hi,
> Can you help to review the patch?
> This pr is based on previous work and discussion in [pr
> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
> 18294](https://github.com/openjdk/jdk/pull/18294).
>
> Compared with previous prs, the major change in this pr is to integrate the
> sou
On Thu, 11 Apr 2024 10:36:03 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch?
>> This pr is based on previous work and discussion in [pr
>> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
>> 18294](https://github.com/openjdk/jdk/pull/18294).
>>
>> Compared with previous
> Hi,
> Can you help to review the patch?
> This pr is based on previous work and discussion in [pr
> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
> 18294](https://github.com/openjdk/jdk/pull/18294).
>
> Compared with previous prs, the major change in this pr is to integrate the
> sou
On Thu, 11 Apr 2024 10:36:03 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch?
>> This pr is based on previous work and discussion in [pr
>> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
>> 18294](https://github.com/openjdk/jdk/pull/18294).
>>
>> Compared with previous
On Thu, 11 Apr 2024 10:36:03 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch?
>> This pr is based on previous work and discussion in [pr
>> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
>> 18294](https://github.com/openjdk/jdk/pull/18294).
>>
>> Compared with previous
On Tue, 9 Apr 2024 20:10:36 GMT, Mikael Vidstedt wrote:
>> Hamlin Li has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - disable unused-function warnings; add log msg
>> - minor
>
> Thank you for the update and for working on this in gene
> Hi,
> Can you help to review the patch?
> This pr is based on previous work and discussion in [pr
> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
> 18294](https://github.com/openjdk/jdk/pull/18294).
>
> Compared with previous prs, the major change in this pr is to integrate the
> sou
On Fri, 5 Apr 2024 12:17:17 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch?
>> This pr is based on previous work and discussion in [pr
>> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
>> 18294](https://github.com/openjdk/jdk/pull/18294).
>>
>> Compared with previous
On Fri, 5 Apr 2024 12:17:17 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch?
>> This pr is based on previous work and discussion in [pr
>> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
>> 18294](https://github.com/openjdk/jdk/pull/18294).
>>
>> Compared with previous
On Wed, 10 Apr 2024 09:24:09 GMT, Hamlin Li wrote:
> > Thank you for the update and for working on this in general.
> > I've started working on JDK-8329816, preparing the change for the SLEEF
> > specific part of the change. Specifically, I'm currently planning on
> > including the three SLEEF
On Wed, 10 Apr 2024 09:24:09 GMT, Hamlin Li wrote:
> With that in mind, it looks like we could potentially use SLEEF for other
> architectures on linux in the future? And potentially additional operating
> systems as well?
Hi Mikael(@vidmik ) ! :)
Thanks for looking into the legal stuff!
We a
On Tue, 9 Apr 2024 20:10:36 GMT, Mikael Vidstedt wrote:
> Thank you for the update and for working on this in general.
>
> I've started working on JDK-8329816, preparing the change for the SLEEF
> specific part of the change. Specifically, I'm currently planning on
> including the three SLEEF
On Fri, 5 Apr 2024 12:17:17 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch?
>> This pr is based on previous work and discussion in [pr
>> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
>> 18294](https://github.com/openjdk/jdk/pull/18294).
>>
>> Compared with previous
On Fri, 5 Apr 2024 12:17:17 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch?
>> This pr is based on previous work and discussion in [pr
>> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
>> 18294](https://github.com/openjdk/jdk/pull/18294).
>>
>> Compared with previous
On Thu, 4 Apr 2024 21:55:54 GMT, Mikael Vidstedt wrote:
>> Hamlin Li has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - disable unused-function warnings; add log msg
>> - minor
>
> make/modules/jdk.incubator.vector/Lib.gmk line 44:
>
>>
On Thu, 4 Apr 2024 16:47:44 GMT, Magnus Ihse Bursie wrote:
> Build libsleef using their cmake system and look at the compile command line.
> (You do this by `VERBOSE=1 cmake` IIRC). Then you can see what flags they are
> using. This is what I was referring to as "normal libsleef build". I notic
> Hi,
> Can you help to review the patch?
> This pr is based on previous work and discussion in [pr
> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
> 18294](https://github.com/openjdk/jdk/pull/18294).
>
> Compared with previous prs, the major change in this pr is to integrate the
> sou
On Wed, 3 Apr 2024 14:40:42 GMT, Hamlin Li wrote:
> Hi,
> Can you help to review the patch?
> This pr is based on previous work and discussion in [pr
> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
> 18294](https://github.com/openjdk/jdk/pull/18294).
>
> Compared with previous prs, th
On Wed, 3 Apr 2024 14:40:42 GMT, Hamlin Li wrote:
> Hi,
> Can you help to review the patch?
> This pr is based on previous work and discussion in [pr
> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
> 18294](https://github.com/openjdk/jdk/pull/18294).
>
> Compared with previous prs, th
On Wed, 3 Apr 2024 19:23:01 GMT, Magnus Ihse Bursie wrote:
> Just a quick question after giving this a glance: My understanding was that
> the normal libsleef build set a lot of compiler options, e.g. disabling
> built-in maths etc. You don't seem to set any of these. Have you determined
> tha
On Wed, 3 Apr 2024 14:40:42 GMT, Hamlin Li wrote:
> Hi,
> Can you help to review the patch?
> This pr is based on previous work and discussion in [pr
> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
> 18294](https://github.com/openjdk/jdk/pull/18294).
>
> Compared with previous prs, th
On Fri, 15 Mar 2024 13:58:05 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review this patch?
>> Thanks
>>
>> This is a continuation of work based on [1] by @XiaohongGong, most work was
>> done in that pr. In this new pr, just rebased the code in [1], then added
>> some minor changes (renami
On Thu, 28 Mar 2024 18:41:03 GMT, Paul Sandoz wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix jni includes
>
> Hamlin, thank you for working on this. I think integrating a sub-set of SLEEF
> is valuable (not all
On Thu, 28 Mar 2024 18:41:03 GMT, Paul Sandoz wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix jni includes
>
> Hamlin, thank you for working on this. I think integrating a sub-set of SLEEF
> is valuable (not all
On Fri, 15 Mar 2024 13:58:05 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review this patch?
>> Thanks
>>
>> This is a continuation of work based on [1] by @XiaohongGong, most work was
>> done in that pr. In this new pr, just rebased the code in [1], then added
>> some minor changes (renami
On Mon, 25 Mar 2024 15:13:54 GMT, Andrew Haley wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix jni includes
>
>> > > But that raises an interesting question. What happens if you try to load
>> > > a library compi
On Fri, 15 Mar 2024 13:58:05 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review this patch?
>> Thanks
>>
>> This is a continuation of work based on [1] by @XiaohongGong, most work was
>> done in that pr. In this new pr, just rebased the code in [1], then added
>> some minor changes (renami
On Wed, 27 Mar 2024 14:47:00 GMT, Magnus Ihse Bursie wrote:
> At this point, I think I am not really qualified to continue the discussion.
>
> I will ask around inside Oracle to see if I can find someone who better
> understands the implications of the suggested libsleef integration (with or
>
On Fri, 15 Mar 2024 13:58:05 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review this patch?
>> Thanks
>>
>> This is a continuation of work based on [1] by @XiaohongGong, most work was
>> done in that pr. In this new pr, just rebased the code in [1], then added
>> some minor changes (renami
On Fri, 15 Mar 2024 13:58:05 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review this patch?
>> Thanks
>>
>> This is a continuation of work based on [1] by @XiaohongGong, most work was
>> done in that pr. In this new pr, just rebased the code in [1], then added
>> some minor changes (renami
On Fri, 15 Mar 2024 13:58:05 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review this patch?
>> Thanks
>>
>> This is a continuation of work based on [1] by @XiaohongGong, most work was
>> done in that pr. In this new pr, just rebased the code in [1], then added
>> some minor changes (renami
On Fri, 15 Mar 2024 13:58:05 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review this patch?
>> Thanks
>>
>> This is a continuation of work based on [1] by @XiaohongGong, most work was
>> done in that pr. In this new pr, just rebased the code in [1], then added
>> some minor changes (renami
On Mon, 25 Mar 2024 20:19:04 GMT, Hamlin Li wrote:
> But anyway, it's a furture incremental solution after this pr, am I right? Or
> are we going to change direction?
I'm honestly not sure what is the right way forward. It seems we all agree that
this PR is not the end solution we want. So the
On Mon, 25 Mar 2024 20:19:04 GMT, Hamlin Li wrote:
> It's not necessary to integrate libsleef build sysstem into jdk, we just need
> to integrate the final sources (generated by sleef cmake) into jdk. I have
> tested it, it works.
That is an interesting approach. It will raise the bar for upda
1 - 100 of 240 matches
Mail list logo
