On Mon, 14 Oct 2024 14:57:46 GMT, Hamlin Li <m...@openjdk.org> wrote:
> Hi, > Can you help to review the patch? Previously it's > https://github.com/openjdk/jdk/pull/18605. > This pr is based on https://github.com/openjdk/jdk/pull/20781. > > Thanks! > > ## Test > ### tests: > * test/jdk/jdk/incubator/vector/ > * test/hotspot/jtreg/compiler/vectorapi/ > > ### options: > * -XX:UseSVE=1 -XX:+EnableVectorSupport -XX:+UseVectorStubs > * -XX:UseSVE=0 -XX:+EnableVectorSupport -XX:+UseVectorStubs > * -XX:+EnableVectorSupport -XX:-UseVectorStubs > > ## Performance > > ### Tests > jmh tests are test/micro/org/openjdk/bench/jdk/incubator/vector/operation/ > from vectorIntrinsics branch in panama-vector. It's good to have these tests > in jdk main stream, I will do it in a separate pr later. (These tests are > auto-generated tests from some script&template, it's good to also have those > scrip&template in jdk main stream, but those scrip&template generates more > other tests than what we need here, so better to add these tests and > script&template in another pr). > > ### Options > * +intrinsic: > 'FORK=1;ITER=10;WARMUP_ITER=10;JAVA_OPTIONS=-XX:+UnlockExperimentalVMOptions > -XX:+EnableVectorSupport -XX:+UseVectorStubs' > * -intrinsic: > 'FORK=1;ITER=10;WARMUP_ITER=10;JAVA_OPTIONS=-XX:+UnlockExperimentalVMOptions > -XX:+EnableVectorSupport -XX:-UseVectorStubs' > > ### Performance data > I have re-tested, there is no much difference from > https://github.com/openjdk/jdk/pull/18605, so please check performance data > in that pr. make/autoconf/flags-cflags.m4 line 920: > 918: # ACLE and this flag are required to build the aarch64 SVE related > functions in > 919: # libvectormath. > 920: if test "x${OPENJDK_TARGET_CPU}" = "xaarch64"; then Suggestion: if test "x$OPENJDK_TARGET_CPU" = "xaarch64"; then ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21502#discussion_r1800940513
