On Tue, 9 Apr 2024 20:10:36 GMT, Mikael Vidstedt <mik...@openjdk.org> wrote:
>> Hamlin Li has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - disable unused-function warnings; add log msg >> - minor > > Thank you for the update and for working on this in general. > > I've started working on JDK-8329816, preparing the change for the SLEEF > specific part of the change. Specifically, I'm currently planning on > including the three SLEEF header files, the README and a legal/sleef.md file > in that change. Let me know if you have any thoughts/concerns. > > Also, just for my understanding, would love to understand your thoughts on > the future here (I apologize if this was already discussed elsewhere): > > It seem like SLEEF is (sort of) limited to linux at this point (the SLEEF > README mentions that "Due to limited test capacities, SLEEF is currently only > officially supported on Linux with gcc or llvm/clang." ). That same README > does, however, indicate good test coverage on several architectures in > addition to aarch64 (including x86_64, PPC, RISC-V). With that in mind, it > looks like we could potentially use SLEEF for other architectures on linux in > the future? And potentially additional operating systems as well? Hey, @vidmik I've fixed the performance issue, and update the sleef inline headers and README. It's good for you to integrate these files via JDK-8329816. ------------- PR Comment: https://git.openjdk.org/jdk/pull/18605#issuecomment-2049400793
