On Mon, 25 Mar 2024 20:19:04 GMT, Hamlin Li <m...@openjdk.org> wrote:
> It's not necessary to integrate libsleef build sysstem into jdk, we just need > to integrate the final sources (generated by sleef cmake) into jdk. I have > tested it, it works. That is an interesting approach. It will raise the bar for updating the sleef sources, but if we document the process carefully I guess that will not be an issue -- all imported third party sources needs some kind of curation when re-importing. I just had a quick look at the sleef sources, and it seems a bit more complicated. Apart from the generated source code, they also compile the same source code file multiple times with different defines on the command line. This is not something we have support for in the build system, but then again it is not nearly as difficult to solve as the code generation part, so it can certainly be handled in some way or another. So yes, I agree that using this approach it might actually be feasible to include the libsleef sources in the JDK repo. ------------- PR Comment: https://git.openjdk.org/jdk/pull/18294#issuecomment-2019779075
