On Mon, 8 Jul 2024 16:20:40 GMT, Andrew Haley <a...@openjdk.org> wrote:

> I finally did some measurements. 

Thanks for testing it!

> It would be nice if the JMH test were part of this patch.

OK, I can do that later.

> 
> It mostly looks good, but I can see an odd regression of DoubleMaxVector.TANH 
> (by 39%) on Apple M1. I don't really know why this is, given that tanh(x) is 
> almost certainly based on expm1(x). This probably isn't important, but it is 
> odd.

Yes, it has some regression in TANH, I have modified the code to skip TANH 
(https://github.com/openjdk/jdk/pull/18605/commits/6061c25de00423f2c92c08ce40af4815c0fa3933)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18605#issuecomment-2220231384

Reply via email to