On Wed, 3 Apr 2024 14:40:42 GMT, Hamlin Li <m...@openjdk.org> wrote: > Hi, > Can you help to review the patch? > This pr is based on previous work and discussion in [pr > 16234](https://github.com/openjdk/jdk/pull/16234), [pr > 18294](https://github.com/openjdk/jdk/pull/18294). > > Compared with previous prs, the major change in this pr is to integrate the > source of sleef (for the steps, please check > `src/jdk.incubator.vector/linux/native/libvectormath/README`), rather than > depends on external sleef things (header or lib) at build or run time. > Besides of this change, also modify the previous changes accordingly, e.g. > remove some uncessary files or changes especially in make dir of jdk. > > Besides of the code changes, one important task is to handle the legal > process. > > Thanks!
Just a quick question after giving this a glance: My understanding was that the normal libsleef build set a lot of compiler options, e.g. disabling built-in maths etc. You don't seem to set any of these. Have you determined that they were not needed? ------------- PR Comment: https://git.openjdk.org/jdk/pull/18605#issuecomment-2035409207
